{"id":16505,"url":"https://patchwork.libcamera.org/api/patches/16505/?format=json","web_url":"https://patchwork.libcamera.org/patch/16505/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220701084521.31831-14-tomi.valkeinen@ideasonboard.com>","date":"2022-07-01T08:45:17","name":"[libcamera-devel,v3,13/17] py: unittests.py: Use new events support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"eba1527f902aa66578967593b5315f73b709d5f9","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16505/mbox/","series":[{"id":3241,"url":"https://patchwork.libcamera.org/api/series/3241/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3241","date":"2022-07-01T08:45:04","name":"Python bindings event handling","version":3,"mbox":"https://patchwork.libcamera.org/series/3241/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16505/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16505/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1A33BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  1 Jul 2022 08:45:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D3FA65654;\n\tFri,  1 Jul 2022 10:45:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D512C65697\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  1 Jul 2022 10:45:46 +0200 (CEST)","from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AB6425C;\n\tFri,  1 Jul 2022 10:45:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656665156;\n\tbh=M6y+5uZi7jFH5zs87INDd42XiuZf/QXSalaa9/bjY4c=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ZRNwt/nrjFkTOYlK0QHLgf4yiRg7aw+S6X7ZczipHWctLZOyHk2o1U3mdtwhy5YcQ\n\tXR1GsOc8nxRGP62Exw1lLDnpR1BzxUJLagODeaa46LjPZqmP3gpSWwFBJhIhfyD5R4\n\teDBIyC4CeXH3tVA22OzIlCE96Oam5FherdKQNf1sZHM8kyMXy9kmNVHTVTteDPkeX5\n\t0vPsMGKh6E+79xj9/fkqsQv6/U/gfd53qWsh4iSZHrHq8SI3RldLfAHerWNknQUZFi\n\tZJJpdQVI6uE3bRKW4tu6TBL7zzVKyriWp6SOQY4I2WUuG2tiC1ePeQU/vngXN8uWTt\n\tJg5Id1fO1K3tg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656665146;\n\tbh=M6y+5uZi7jFH5zs87INDd42XiuZf/QXSalaa9/bjY4c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dbhKjCtc55+BbVQEuTt323BOTxo+1UhNWMqzYChnNJ8aYApmuavflkYgmzX1TpyFk\n\tZoi1YV/4VfNebhO+G2a9cSjTOLx9Hl/IjP9lYRbDU1wYzh5u9D0WOR4Fj3DwulOBLv\n\tv983tYYov8imXbw123T162IZyZw2+5PL56PzhzZU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dbhKjCtc\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>","Date":"Fri,  1 Jul 2022 11:45:17 +0300","Message-Id":"<20220701084521.31831-14-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 13/17] py: unittests.py: Use new events\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n test/py/unittests.py | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 794e46be..fab791d1 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -201,9 +201,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n             if not events:\n                 continue\n \n-            ready_reqs = cm.get_ready_requests()\n-\n-            reqs += ready_reqs\n+            for ev in cm.get_events():\n+                self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+                reqs.append(ev.request)\n \n             if len(reqs) == num_bufs:\n                 break\n@@ -267,9 +267,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n         while running:\n             events = sel.select()\n             for key, _ in events:\n-                ready_reqs = cm.get_ready_requests()\n-\n-                reqs += ready_reqs\n+                for ev in cm.get_events():\n+                    self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+                    reqs.append(ev.request)\n \n                 if len(reqs) == num_bufs:\n                     running = False\n","prefixes":["libcamera-devel","v3","13/17"]}