[{"id":24645,"web_url":"https://patchwork.libcamera.org/comment/24645/","msgid":"<20220818135051.yqynvcpdig4jb6dd@uno.localdomain>","date":"2022-08-18T13:50:51","subject":"Re: [libcamera-devel] [PATCH v3 04/17] py: cam.py: Remove todo\n\tcomment","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Tomi\n\nOn Fri, Jul 01, 2022 at 11:45:08AM +0300, Tomi Valkeinen wrote:\n> The comment is no longer valid.\n>\n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/py/cam/cam.py | 3 ---\n> 1 file changed, 3 deletions(-)\n>\n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index 8a82e092..2701d937 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -3,9 +3,6 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2022, Tomi Valkeinen \n>\n> -# \\todo Convert ctx and state dicts to proper classes, and move relevant\n> -# functions to those classes.\n> -\n> from typing import Any\n> import argparse\n> import binascii\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE3C2C3272\n\tfor ;\n\tThu, 18 Aug 2022 13:50:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 392F061FC0;\n\tThu, 18 Aug 2022 15:50:56 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A658A61FA7\n\tfor ;\n\tThu, 18 Aug 2022 15:50:55 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id EEF58100011;\n\tThu, 18 Aug 2022 13:50:53 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660830656;\n\tbh=bfjpWAP+siID2cQWYzmjtAeLL4LFXvYWj7wZbsRmV0w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PtHWwuG5iWKsve3CFjzu1A6mMC6FTiOzC72Av3fiqIkY27XDfICQFEXlwOpg0fenc\n\tlNoshhxS0/H1Cf3qjICvbVA4ui5VOWHeQCAAUg5ArYDL3QKh58GUZ8A3CNK/SgVBNZ\n\t71Le16bSeiWJd4qOiEOAbRwLzZVsO+8kW7E/zF3demQaq+V6MHETOSPGXY1jesf6oO\n\t4ZlKVSbn/bliYgqYXrjHq760U68nGRd8WFFpyRcNvJmQs3UuUdQCUupAxHFdEfcsMQ\n\tXqQ4N5VCofLGX2SNsr7FyvUk1wDFkAsnZacB+xyNpjGKQhcZi+aNBfO9GSEtgS3N5D\n\tN8vRIJoGYtzWw==","Date":"Thu, 18 Aug 2022 15:50:51 +0200","To":"Tomi Valkeinen ","Message-ID":"<20220818135051.yqynvcpdig4jb6dd@uno.localdomain>","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>\n\t<20220701084521.31831-5-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220701084521.31831-5-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 04/17] py: cam.py: Remove todo\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24664,"web_url":"https://patchwork.libcamera.org/comment/24664/","msgid":"","date":"2022-08-18T15:06:06","subject":"Re: [libcamera-devel] [PATCH v3 04/17] py: cam.py: Remove todo\n\tcomment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, Jul 01, 2022 at 11:45:08AM +0300, Tomi Valkeinen wrote:\n> The comment is no longer valid.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam.py | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index 8a82e092..2701d937 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -3,9 +3,6 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2022, Tomi Valkeinen \n> \n> -# \\todo Convert ctx and state dicts to proper classes, and move relevant\n> -# functions to those classes.\n> -\n> from typing import Any\n> import argparse\n> import binascii","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48C0EC3272\n\tfor ;\n\tThu, 18 Aug 2022 15:06:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 548CA61FC0;\n\tThu, 18 Aug 2022 17:06:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6D9861FA7\n\tfor ;\n\tThu, 18 Aug 2022 17:06:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A7B08B;\n\tThu, 18 Aug 2022 17:06:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660835170;\n\tbh=rB3r+pMwg0HorhPeGZ+xH385gU1FJnUQj61jq7nAdIw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MnXzTrZozweccxg/Y0hYvu/9uHqPVOtg03E53xfl90UHAnONrto6285FSu9ogm3fx\n\tGrrKY6cjRs63CxNJWFuqUZ+ViAMk2LRzCC8fq7cJu05G/WQKTLxmhvoggfYj2JbJ18\n\tpV5FFivsu2OQBdTIHGZby/vmFurFyBPkTZP1Op5PkTlJUrH7V/z8PdN4BozelE/CQX\n\tw4KTiGH+fiz/WmkuTDdvwsqL+sAmiMg4ARVnSVTOgBKgomliYj7U+kaNv6kbbTGZ79\n\t96qkF4gR5ntGDXWvhHjkHNbFehzYK40dgFLAU5Lzwk/6SSlFiozTPzVLSANakY5jcW\n\tI1sQltbHP9vAA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660835169;\n\tbh=rB3r+pMwg0HorhPeGZ+xH385gU1FJnUQj61jq7nAdIw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MZCEjMFclJMtgYIUuuMnGvntqGAUjQ6be/VwIYJzEaHUv8JRl/jVxnyU9DUSAkLSf\n\tYXCKTnwo5CldkxGA39qx5BqteegMKuBIKjsSJNO5gKM/1B51EUAGlYs+H6oSGjU/cd\n\tEkkSAwBQr3VDysMb7slYFI428x/8Lu63ho7vtfSo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MZCEjMFc\"; dkim-atps=neutral","Date":"Thu, 18 Aug 2022 18:06:06 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>\n\t<20220701084521.31831-5-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220701084521.31831-5-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 04/17] py: cam.py: Remove todo\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]