{"id":16494,"url":"https://patchwork.libcamera.org/api/patches/16494/?format=json","web_url":"https://patchwork.libcamera.org/patch/16494/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220701084521.31831-3-tomi.valkeinen@ideasonboard.com>","date":"2022-07-01T08:45:06","name":"[libcamera-devel,v3,02/17] py: Add Python logging category","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a168d53203888f3ae1e6caa00697e538aeb1c198","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16494/mbox/","series":[{"id":3241,"url":"https://patchwork.libcamera.org/api/series/3241/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3241","date":"2022-07-01T08:45:04","name":"Python bindings event handling","version":3,"mbox":"https://patchwork.libcamera.org/series/3241/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16494/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16494/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAD11BD808\n\tfor ;\n\tFri, 1 Jul 2022 08:45:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CEF765651;\n\tFri, 1 Jul 2022 10:45:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB1496564E\n\tfor ;\n\tFri, 1 Jul 2022 10:45:41 +0200 (CEST)","from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 284DA6D1;\n\tFri, 1 Jul 2022 10:45:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656665144;\n\tbh=GApko8Xk7fqa9bcs/6OBQN3OzWVj2WUfL+sa81qKAlw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=sVW57PXTfNsW3NMEFTsnTa5FnZV7fMdIxgREGVojzcKDttL9yLE0ps+edc28N6oEc\n\tJz636YxzTWEGQFZ139vlZnNk4jxvNcDGyio3q51bCNxKihKH/3ZbujYgLpcd/XOjzP\n\tHUzWt7RymkSTbxqwb9MZLkJ7vMvNFhjkseR59uwf5F2NIj9n/DkRs7awP90M0asuKM\n\t0C4UzQpBMmWM+dZG0BzbkPRtnKfSJd1tDjTOC/57Wa5o9+mGzx9/35dgZipLBVRKyl\n\tTTDioZ1hWJ1eDV9QGF5/eFGHYcSDux1W1NDJnOYui4gt+Piivyg+C1pAOeYnchEuDw\n\toSNDMToYF+dmQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656665141;\n\tbh=GApko8Xk7fqa9bcs/6OBQN3OzWVj2WUfL+sa81qKAlw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lipsK3GMXDr0bEM/DM77KLZPA0AOPrDv11knQUygRjOmrCajWfMlfG9NfwcBdENyq\n\t4yzMBKg5L+/PURWdHkJsiYzLcO69RJwuTSm5k6L9b+c5Zrp3yGOWNhSSHP9S3sPmbS\n\tNceESUI5YBKt2L9E7zccti/hF9VSfLqUC1aWUX3E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lipsK3GM\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Fri, 1 Jul 2022 11:45:06 +0300","Message-Id":"<20220701084521.31831-3-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 02/17] py: Add Python logging category","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add Python logging category, and use it in handleRequestCompleted().\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/py/libcamera/py_main.cpp | 12 ++++++++++--\n src/py/libcamera/py_main.h | 14 ++++++++++++++\n 2 files changed, 24 insertions(+), 2 deletions(-)\n create mode 100644 src/py/libcamera/py_main.h","diff":"diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 505cc3dc..4b698f77 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -5,6 +5,8 @@\n * Python bindings\n */\n \n+#include \"py_main.h\"\n+\n #include \n #include \n #include \n@@ -23,6 +25,12 @@ namespace py = pybind11;\n \n using namespace libcamera;\n \n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(Python)\n+\n+}\n+\n template\n static py::object valueOrTuple(const ControlValue &cv)\n {\n@@ -120,10 +128,10 @@ static void handleRequestCompleted(Request *req)\n \tsize_t s = write(gEventfd, &v, 8);\n \t/*\n \t * We should never fail, and have no simple means to manage the error,\n-\t * so let's use LOG(Fatal).\n+\t * so let's log a fatal error.\n \t */\n \tif (s != 8)\n-\t\tLOG(Fatal) << \"Unable to write to eventfd\";\n+\t\tLOG(Python, Fatal) << \"Unable to write to eventfd\";\n }\n \n void init_py_enums(py::module &m);\ndiff --git a/src/py/libcamera/py_main.h b/src/py/libcamera/py_main.h\nnew file mode 100644\nindex 00000000..5bb5f2d1\n--- /dev/null\n+++ b/src/py/libcamera/py_main.h\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2022, Tomi Valkeinen \n+ */\n+\n+#pragma once\n+\n+#include \n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Python)\n+\n+}\n","prefixes":["libcamera-devel","v3","02/17"]}