{"id":16493,"url":"https://patchwork.libcamera.org/api/patches/16493/?format=json","web_url":"https://patchwork.libcamera.org/patch/16493/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220701084521.31831-2-tomi.valkeinen@ideasonboard.com>","date":"2022-07-01T08:45:05","name":"[libcamera-devel,v3,01/17] py: cam.py: Fix multi camera capture without -C","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cf4b962b9a74ad5f27edb427bdb47c8bb06472f7","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16493/mbox/","series":[{"id":3241,"url":"https://patchwork.libcamera.org/api/series/3241/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3241","date":"2022-07-01T08:45:04","name":"Python bindings event handling","version":3,"mbox":"https://patchwork.libcamera.org/series/3241/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16493/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16493/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D50EBD808\n\tfor ;\n\tFri, 1 Jul 2022 08:45:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FE976564E;\n\tFri, 1 Jul 2022 10:45:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69F9D6564B\n\tfor ;\n\tFri, 1 Jul 2022 10:45:41 +0200 (CEST)","from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B20546BB;\n\tFri, 1 Jul 2022 10:45:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656665143;\n\tbh=kAL85UrCX4ZS6H5jh0S4WDQbWuTWODAQW0q+OmJ+1ng=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=P+ogX+xQH6TFxAd3rWOBaFnrIR3x4KjzQ/M6dZpnMDqSWnxqB+0SWkrL+Sxy99wew\n\tP51PycKRi2G1/ZI6waptUTIaeGpKggKBHcitw4gA4yhwYTibD5Q1Hz76olf1s3vWDu\n\tM6ffru9Z7XLLtpB/UoRKslCGtM8RGC0kZ77Sdx6xo2OQWuBO93mtDjWT13jS4Duz+N\n\tHhl5fYtYnB+fFdHmQ00kxeQtZ2Hq+6vd+qNWBubX/uu9Hr0BBHD9+GSR0f8InPQMw9\n\tNFEIwjp9LZ9CipikJ4o8P/4hEkG6MoVbDiBWrnZvu5kk3903/prgwZceP6kgKh0ZvK\n\tqB+FVvDWRiBEA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656665141;\n\tbh=kAL85UrCX4ZS6H5jh0S4WDQbWuTWODAQW0q+OmJ+1ng=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sjXw6RLya9MXj3WC1tEdKSN5wOdK893QoUKf0ndS7pBZeSIVWX7HgM1xzdHNUWZJ1\n\tetx8BWDDVRCVh17SJuld0u22aZJNVseKhrsddKgYGlpdWcmD0dxJrrrtJd/SMUp6CD\n\tfRTJy5XcLRJ6GwZiJRcbIpe0OASt+rzaXiO1Sf60="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sjXw6RLy\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Fri, 1 Jul 2022 11:45:05 +0300","Message-Id":"<20220701084521.31831-2-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 01/17] py: cam.py: Fix multi camera\n\tcapture without -C","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"-C flag is supposed to affect only the camera that was previously\ndefined in the arguments. That's not the case, and, e.g.:\n\ncam.py -c2 -C -c3\n\ncauses camera 3 to start capturing, but it stops after the initial\nRequests have been completed.\n\nFix the issue by filtering out camera contexts that do not have -C\ndefined.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/py/cam/cam.py | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 2ae89fa8..8a82e092 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -434,7 +434,10 @@ def main():\n if args.info:\n ctx.do_cmd_info()\n \n- if args.capture:\n+ # Filter out capture contexts which are not marked for capture\n+ contexts = [ctx for ctx in contexts if ctx.opt_capture > 0]\n+\n+ if contexts:\n state = CaptureState(cm, contexts)\n \n if args.renderer == 'null':\n","prefixes":["libcamera-devel","v3","01/17"]}