[{"id":23698,"web_url":"https://patchwork.libcamera.org/comment/23698/","msgid":"<165662904952.1516045.10018766970122103954@Monstersaurus>","date":"2022-06-30T22:44:09","subject":"Re: [libcamera-devel] [PATCH v3 23/23] libcamera: Move\n\tcamera_lens.cpp in src/libcamera/camera_sensor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-06-30 14:39:02)\n> The CameraLens class is tighly copuled with the camera sensor classes.\n\n/tighly/tightly/\n/copuled/coupled/\n\nI think this will make sense yes, but I don't know yet how abstract\ncamera_lens will become. Anyway, this is probably useful for now so:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Move the camera_lens.cpp file in src/libcamera/camera_sensor.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/{ => camera_sensor}/camera_lens.cpp | 0\n> src/libcamera/camera_sensor/meson.build | 1 +\n> src/libcamera/meson.build | 1 -\n> 3 files changed, 1 insertion(+), 1 deletion(-)\n> rename src/libcamera/{ => camera_sensor}/camera_lens.cpp (100%)\n> \n> diff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_sensor/camera_lens.cpp\n> similarity index 100%\n> rename from src/libcamera/camera_lens.cpp\n> rename to src/libcamera/camera_sensor/camera_lens.cpp\n> diff --git a/src/libcamera/camera_sensor/meson.build b/src/libcamera/camera_sensor/meson.build\n> index 991eeeeee29e..b38e3551f644 100644\n> --- a/src/libcamera/camera_sensor/meson.build\n> +++ b/src/libcamera/camera_sensor/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_sources += files([\n> + 'camera_lens.cpp',\n> 'camera_sensor.cpp',\n> 'camera_sensor_helper.cpp',\n> 'camera_sensor_properties.cpp',\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 897fb259a894..dc8f55cf5057 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -5,7 +5,6 @@ libcamera_sources = files([\n> 'byte_stream_buffer.cpp',\n> 'camera.cpp',\n> 'camera_controls.cpp',\n> - 'camera_lens.cpp',\n> 'camera_manager.cpp',\n> 'color_space.cpp',\n> 'controls.cpp',\n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D3B6BE173\n\tfor ;\n\tThu, 30 Jun 2022 22:44:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 887C665633;\n\tFri, 1 Jul 2022 00:44:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 119D860412\n\tfor ;\n\tFri, 1 Jul 2022 00:44:13 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88A5E25C;\n\tFri, 1 Jul 2022 00:44:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656629054;\n\tbh=Rb/A1uHIj/IXqKA53jXTGb6m+LyJXPaxdUwrYaiNj2s=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=v+AeKnnwi7SqQol1uw5qgrXRA5dCew3SbpcDOhogNHTf8970DpdsQ66NXpZQRcwcM\n\tIE67bWdB1GDSPxa5Qe++gF81Db3wQTNDpsX5ffcFVCXEIWWVZT8cbdPY4PY6oRdlgA\n\tECW6AiVbtcqSWYA4bsTp1CRJ1+CV2/VlCPqXTbG0AniHKmaBMFaQgZoc2Dj0Xuo4mX\n\tGEwalwT79BkV9Wofot1PAl+SSH/eJ9C67gPGJGDEP9K3pQP5n74rzJQx01j9pmaUI5\n\tuzRkC6mLDWwxBBeZFCsg6I3Z22iSEXmQ0sXuDXyOdXr6AkkSzAS0P0n4bk7ynEWtiB\n\tVZ55ZvoT/lH2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656629052;\n\tbh=Rb/A1uHIj/IXqKA53jXTGb6m+LyJXPaxdUwrYaiNj2s=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Ey2As63YjM1TUJLIs5T3S1jD3h041ZD+foUunr2++1+8fUXujut2Gv2b3hDCOMUak\n\tUrnro5n+w68bMNcjrn2XU3mIo5O0XLcyPo8BrxRLFQ/s+S7R6gmpqYxIatMicYIy42\n\ta9UOvpt0ew72Ohl2rjKrIElbV/cPajPqRgzSYOI8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ey2As63Y\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220630133902.321099-24-jacopo@jmondi.org>","References":"<20220630133902.321099-1-jacopo@jmondi.org>\n\t<20220630133902.321099-24-jacopo@jmondi.org>","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Jun 2022 23:44:09 +0100","Message-ID":"<165662904952.1516045.10018766970122103954@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 23/23] libcamera: Move\n\tcamera_lens.cpp in src/libcamera/camera_sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]