[{"id":2215,"web_url":"https://patchwork.libcamera.org/comment/2215/","msgid":"<20190711054645.GK1557@wyvern>","date":"2019-07-11T05:46:45","subject":"Re: [libcamera-devel] [PATCH 4/6] test: Add Thread test cases","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your test.\n\nOn 2019-07-10 22:17:06 +0300, Laurent Pinchart wrote:\n> The Thread test case verifies that\n> \n> - a Thread instance is created for the main thread\n> - a new Thread can be created, started, and stopped\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> test/meson.build | 1 +\n> test/threads.cpp | 93 ++++++++++++++++++++++++++++++++++++++++++++++++\n> 2 files changed, 94 insertions(+)\n> create mode 100644 test/threads.cpp\n> \n> diff --git a/test/meson.build b/test/meson.build\n> index 41b54ffd358c..bd0e0d98f0e7 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -21,6 +21,7 @@ public_tests = [\n> \n> internal_tests = [\n> ['camera-sensor', 'camera-sensor.cpp'],\n> + ['threads', 'threads.cpp'],\n> ]\n> \n> foreach t : public_tests\n> diff --git a/test/threads.cpp b/test/threads.cpp\n> new file mode 100644\n> index 000000000000..9a2d39dfd106\n> --- /dev/null\n> +++ b/test/threads.cpp\n> @@ -0,0 +1,93 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * threads.cpp - Threads test\n> + */\n> +\n> +#include \n\nI learnt something new today :-)\n\nReviewed-by: Niklas Söderlund \n\n> +#include \n> +#include \n> +\n> +#include \"thread.h\"\n> +#include \"test.h\"\n> +\n> +using namespace std;\n> +using namespace libcamera;\n> +\n> +class InstrumentedThread : public Thread\n> +{\n> +public:\n> +\tInstrumentedThread(unsigned int iterations)\n> +\t\t: iterations_(iterations)\n> +\t{\n> +\t}\n> +\n> +protected:\n> +\tvoid run()\n> +\t{\n> +\t\tfor (unsigned int i = 0; i < iterations_; ++i) {\n> +\t\t\tthis_thread::sleep_for(chrono::milliseconds(50));\n> +\t\t}\n> +\t}\n> +\n> +private:\n> +\tunsigned int iterations_;\n> +};\n> +\n> +class ThreadTest : public Test\n> +{\n> +protected:\n> +\tint init()\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tint run()\n> +\t{\n> +\t\t/* Test Thread() retrieval for the main thread. */\n> +\t\tThread *thread = Thread::current();\n> +\t\tif (!thread) {\n> +\t\t\tcout << \"Thread::current() failed to main thread\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!thread->isRunning()) {\n> +\t\t\tcout << \"Main thread is not running\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\t/* Test starting the main thread, the test shall not crash. */\n> +\t\tthread->start();\n> +\n> +\t\t/* Test the running state of a custom thread. */\n> +\t\tthread = new Thread();\n> +\t\tthread->start();\n> +\n> +\t\tif (!thread->isRunning()) {\n> +\t\t\tcout << \"Thread is not running after being started\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tthread->exit(0);\n> +\t\tthread->wait();\n> +\n> +\t\tif (thread->isRunning()) {\n> +\t\t\tcout << \"Thread is still running after finishing\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tdelete thread;\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +\n> +\tvoid cleanup()\n> +\t{\n> +\t}\n> +};\n> +\n> +TEST_REGISTER(ThreadTest)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-pl1-x643.google.com (mail-pl1-x643.google.com\n\t[IPv6:2607:f8b0:4864:20::643])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2AB560C23\n\tfor ;\n\tThu, 11 Jul 2019 07:46:49 +0200 (CEST)","by mail-pl1-x643.google.com with SMTP id c2so2398505plz.13\n\tfor ;\n\tWed, 10 Jul 2019 22:46:49 -0700 (PDT)","from localhost (softbank126163157105.bbtec.net. [126.163.157.105])\n\tby smtp.gmail.com with ESMTPSA id\n\tf14sm3896007pfn.53.2019.07.10.22.46.47\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 10 Jul 2019 22:46:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=+5u5iTH/IAqcrg5LyCoxb6ess9JXsoqD2DtuHBuzR38=;\n\tb=nOJ2qC7Pvftwe5S84BPAdhLIXMoxyu8xvMeR5S47W+Ips1oL97nPnx5sGx1aI8wKAx\n\tpWEXTU0kSV+4UddFeOS1bTpGPGe1LAcq44+jeR3jpy4DXP124GxvzIuQjpumOvNZfKTI\n\tT3dqMCgulPtevpEqac4aQXE1o6c9ngZqeq1k57iW36IIMGBpNFd6Ohdi9662q47DoFSx\n\tO3vu1HyhymTDtgpDi8QsiZnRxL23L+o9Rs+QW2tX98wvAS/5IB8RC2BMVciztwQ2cExK\n\tKzgywn5JR2W92vjYYtxqrlto8nA5CNIcQ5VR3vE00mgKOw1lq7xQBuWZJ2Qh9BRch290\n\tLa+w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=+5u5iTH/IAqcrg5LyCoxb6ess9JXsoqD2DtuHBuzR38=;\n\tb=PQG5Fj+v2gsaDFz00S3qZCPiMhH+PuZsBxczXWN3JkIX8wl+apVD1aTEe2FFhdjAp+\n\tJbIiN7/dmWMMMkRzkdojNbPr/C9+7ep5uqdQEuO9Onsy2UD9imF2KyS6H4nf01wrk9IE\n\t/qJvoBK/I9K9fNsrXtpC0y42XKw1osjIvdqkKPmVk/eDjPDEuaQPHiE1PY55jNWyRf3B\n\t7nbo9DvnvrOZtai6ZlXXNyIp+mjbQHCzLj/9csEnWttp0sql1gNm9OGblzs5Vf9kwLRE\n\tbY7380onh/9PJ8Q8gYydjrea8sZpyvdOkgTw/O5nrMvmlf864Z7dJ/Y1v9OQXTNSzB5E\n\tJTfw==","X-Gm-Message-State":"APjAAAXOdqgtVzpnHNiYMV3c32UENJJ3b7xwXfrsaADu9hKYAOAQ6tJW\n\twUNcAme4q4x4LEg/c/6693o=","X-Google-Smtp-Source":"APXvYqzl7sceTyJrcoTy4HsF1DibCoGSs8lGbTxFMklIFwDyFMTrafSc5niBXHubhFUjEB3zz6LwEg==","X-Received":"by 2002:a17:902:8b82:: with SMTP id\n\tay2mr2430334plb.164.1562824008776; \n\tWed, 10 Jul 2019 22:46:48 -0700 (PDT)","Date":"Thu, 11 Jul 2019 14:46:45 +0900","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190711054645.GK1557@wyvern>","References":"<20190710191708.13049-1-laurent.pinchart@ideasonboard.com>\n\t<20190710191708.13049-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190710191708.13049-4-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 4/6] test: Add Thread test cases","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jul 2019 05:46:50 -0000"}}]