[{"id":23684,"web_url":"https://patchwork.libcamera.org/comment/23684/","msgid":"<165658678364.1516045.2827163888301953157@Monstersaurus>","date":"2022-06-30T10:59:43","subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Turn the\n\tcookie into a 64-bit integer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-06-30 10:55:21)\n> To allow associating pointers with FrameBuffer instances, turn the\n\nuintptr_t to be explicit?\n\nEither way, \n\n\nReviewed-by: Kieran Bingham \n\n> cookie into a 64-bit integer. This matches the Request cookie with is\n> also a uint64_t.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/framebuffer.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> index 3b1118d1f06b..36b91d11ed79 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -66,8 +66,8 @@ public:\n> Request *request() const;\n> const FrameMetadata &metadata() const { return metadata_; }\n> \n> - unsigned int cookie() const { return cookie_; }\n> - void setCookie(unsigned int cookie) { cookie_ = cookie; }\n> + uint64_t cookie() const { return cookie_; }\n> + void setCookie(uint64_t cookie) { cookie_ = cookie; }\n> \n> std::unique_ptr releaseFence();\n> \n> @@ -80,7 +80,7 @@ private:\n> \n> FrameMetadata metadata_;\n> \n> - unsigned int cookie_;\n> + uint64_t cookie_;\n> };\n> \n> } /* namespace libcamera */\n> \n> base-commit: 3fa79cc688b540e27f954f156b5ad4bb172ba222\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42CDEBD808\n\tfor ;\n\tThu, 30 Jun 2022 10:59:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C408F6564E;\n\tThu, 30 Jun 2022 12:59:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A1066559A\n\tfor ;\n\tThu, 30 Jun 2022 12:59:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 074F645F;\n\tThu, 30 Jun 2022 12:59:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656586787;\n\tbh=rSg9A+Auo2zgNhkeno/UMb2Wlz4vy8iVyoxJuY248bw=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ffxwMSMyA0M0RmzlnBZLz596vu2Q9ccgJzePeFajn2h+eCHKWW2VO4FGCe3mouryF\n\tR/S2CxgCStaN+w6Idsh418rAB1uU+g275iBnR8hWOy27fakeB8l91nMw9zD93bGSer\n\tbIs+gA/Jx0YYpiByAz7ixqfxMr2IP2XvXiY4utCsOS10Q4RWmeLYCXCrBKc8WrDxMM\n\tGAXZyps9UNFm9BrM8Ph787AAGFRku4Z+gP0Rv1CscglPLMXS7QQL3k3+cVQCpEmWIE\n\tayE5K42ga0Rm55hTNQiXKJ7bdCVNOpbCsq49CXn/ec5keIXHGt8NB/Nq+BtyEmfDHp\n\ttN5roQLHWr1Pg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656586786;\n\tbh=rSg9A+Auo2zgNhkeno/UMb2Wlz4vy8iVyoxJuY248bw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=uB0gW5sgPblMXPuPw/NF2VSBEDybk3/ilpU5+E6AQruBeOUNZZ7EfzXq6c3FTHShk\n\tw1HQD3w5ODxs5ns8vdZwZYpU04cMGPBTbmLcFWoJItkd8MPtORH/jhWoucMcvltQjS\n\t0AGodKTElph022bcPbbXea/RDH/9XzeLZYAiIesM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uB0gW5sg\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220630095521.23723-1-laurent.pinchart@ideasonboard.com>","References":"<20220630095521.23723-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 30 Jun 2022 11:59:43 +0100","Message-ID":"<165658678364.1516045.2827163888301953157@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Turn the\n\tcookie into a 64-bit integer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23685,"web_url":"https://patchwork.libcamera.org/comment/23685/","msgid":"","date":"2022-06-30T11:03:52","subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Turn the\n\tcookie into a 64-bit integer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 30, 2022 at 11:59:43AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-06-30 10:55:21)\n> > To allow associating pointers with FrameBuffer instances, turn the\n> \n> uintptr_t to be explicit?\n\nI've considered it, but the uintptr_t size depends on the architecture,\nuint64_t would be more portable here as applications won't need to care\nabout the exact size if they need to store a non-pointer integer larger\nthan 32 bits.\n\nBeside, we may drop the cookie completely :-) This patch was more of a\ndrive-by fix to make the API consistent.\n\n> Either way, \n> \n> Reviewed-by: Kieran Bingham \n> \n> > cookie into a 64-bit integer. This matches the Request cookie with is\n> > also a uint64_t.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/framebuffer.h | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> > index 3b1118d1f06b..36b91d11ed79 100644\n> > --- a/include/libcamera/framebuffer.h\n> > +++ b/include/libcamera/framebuffer.h\n> > @@ -66,8 +66,8 @@ public:\n> > Request *request() const;\n> > const FrameMetadata &metadata() const { return metadata_; }\n> > \n> > - unsigned int cookie() const { return cookie_; }\n> > - void setCookie(unsigned int cookie) { cookie_ = cookie; }\n> > + uint64_t cookie() const { return cookie_; }\n> > + void setCookie(uint64_t cookie) { cookie_ = cookie; }\n> > \n> > std::unique_ptr releaseFence();\n> > \n> > @@ -80,7 +80,7 @@ private:\n> > \n> > FrameMetadata metadata_;\n> > \n> > - unsigned int cookie_;\n> > + uint64_t cookie_;\n> > };\n> > \n> > } /* namespace libcamera */\n> > \n> > base-commit: 3fa79cc688b540e27f954f156b5ad4bb172ba222","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A534BE173\n\tfor ;\n\tThu, 30 Jun 2022 11:04:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D4B76564E;\n\tThu, 30 Jun 2022 13:04:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EA5C6559A\n\tfor ;\n\tThu, 30 Jun 2022 13:04:12 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D737445F;\n\tThu, 30 Jun 2022 13:04:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656587054;\n\tbh=UqFDZoGQ8tUoxtax5lRQlSyxkWXSD4gtaKEZFAz8cq8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Rw76Vd+x+YNoK8LoxyoGBcWS6gfP7SGlzcX11O4rMup9YTxK9q8pYPLDeK9JBf2q4\n\tBNrQFE+lfR8/Qptn7NIsgGTHpEo9yARgA4xsKp1k/OrJH2/q0zkFNtxpg8zRJ7lIDn\n\tmZA6hAcE38iwQ/dygUmSTF467Zyvxr6RL7YykzN6Zn3eB7kO97gKVNd3z2eMyYzGbc\n\tgjJv7ZSn5Ss7gRd6f9YKnbXVOM8IGwhQM2q7ykIeYdi+jFxFA4XvuCAEcmYQlXQm/g\n\tUfMmwE2x0fxudW7DRr3pXePMlHf0AtstoF4QMc9PoYwHOiS1MQkssUZR9aru6W5Yy0\n\tJfutNeYXGNxaA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656587052;\n\tbh=UqFDZoGQ8tUoxtax5lRQlSyxkWXSD4gtaKEZFAz8cq8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tyRYD6/gVJqw9ik8yReh/6jEHZ8o6VfVOJP5Lx8qfIPajMiWc3TMjnHYwAkjoL3cd\n\tAHYc4B3zHaqUGjxtpOrxrWLM6UCjtPD3dCLW+Jmm7OkH6A4TfuWOLyoSPEK1l+qq8p\n\tGUY6H/9xOWoXzrzWrUO5lqQuICfYevxxM+LRy5FY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tyRYD6/g\"; dkim-atps=neutral","Date":"Thu, 30 Jun 2022 14:03:52 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220630095521.23723-1-laurent.pinchart@ideasonboard.com>\n\t<165658678364.1516045.2827163888301953157@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165658678364.1516045.2827163888301953157@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Turn the\n\tcookie into a 64-bit integer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23686,"web_url":"https://patchwork.libcamera.org/comment/23686/","msgid":"","date":"2022-06-30T11:14:17","subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Turn the\n\tcookie into a 64-bit integer","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 6/30/22 16:33, Laurent Pinchart via libcamera-devel wrote:\n> On Thu, Jun 30, 2022 at 11:59:43AM +0100, Kieran Bingham wrote:\n>> Quoting Laurent Pinchart via libcamera-devel (2022-06-30 10:55:21)\n>>> To allow associating pointers with FrameBuffer instances, turn the\n>> uintptr_t to be explicit?\n> I've considered it, but the uintptr_t size depends on the architecture,\n> uint64_t would be more portable here as applications won't need to care\n> about the exact size if they need to store a non-pointer integer larger\n> than 32 bits.\n>\n> Beside, we may drop the cookie completely :-) This patch was more of a\n> drive-by fix to make the API consistent.\n>\n>> Either way,\n>>\n>> Reviewed-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n>>\n>>> cookie into a 64-bit integer. This matches the Request cookie with is\n>>> also a uint64_t.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> include/libcamera/framebuffer.h | 6 +++---\n>>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n>>> index 3b1118d1f06b..36b91d11ed79 100644\n>>> --- a/include/libcamera/framebuffer.h\n>>> +++ b/include/libcamera/framebuffer.h\n>>> @@ -66,8 +66,8 @@ public:\n>>> Request *request() const;\n>>> const FrameMetadata &metadata() const { return metadata_; }\n>>> \n>>> - unsigned int cookie() const { return cookie_; }\n>>> - void setCookie(unsigned int cookie) { cookie_ = cookie; }\n>>> + uint64_t cookie() const { return cookie_; }\n>>> + void setCookie(uint64_t cookie) { cookie_ = cookie; }\n>>> \n>>> std::unique_ptr releaseFence();\n>>> \n>>> @@ -80,7 +80,7 @@ private:\n>>> \n>>> FrameMetadata metadata_;\n>>> \n>>> - unsigned int cookie_;\n>>> + uint64_t cookie_;\n>>> };\n>>> \n>>> } /* namespace libcamera */\n>>>\n>>> base-commit: 3fa79cc688b540e27f954f156b5ad4bb172ba222","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5BEDBD808\n\tfor ;\n\tThu, 30 Jun 2022 11:14:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C6036564E;\n\tThu, 30 Jun 2022 13:14:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3744F6559A\n\tfor ;\n\tThu, 30 Jun 2022 13:14:24 +0200 (CEST)","from [IPV6:2401:4900:1f3f:ca21:e286:106b:5da4:9482] (unknown\n\t[IPv6:2401:4900:1f3f:ca21:e286:106b:5da4:9482])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DA1B45F;\n\tThu, 30 Jun 2022 13:14:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656587665;\n\tbh=hzNPAzqOMDElkBvYw9x206+QzIYg6EWedFnZKR5AIoc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2Mg4CzzWwMRsVEm5LRVYQjDEqeYueNcpFI4p7nPXLDhKQeSA3Nnuy0URuwOHkHst7\n\tuYlVqYA02inmiLTUChKNPWDDK/T4neKioGLLw14GKWWcsCo0zt+zEskJFPeAW4MG66\n\tJqQ2J2KNrbZZZ80jNgoV6oRHYgqN8ZzxqE9XAVASkGeCLxSlcO2sIJynZWprv4I8qh\n\tDrgCWjslvs6Bx3Nb4m1fA5X33R27/LxPtI1tMfuiq6n0yGSbSswvW0oPZHpN9UzVcl\n\tOL92o8iqrBckI/pTlka/WfqbBd5hVeQVh7k/qy1bYhoes0ifzHMBF3rCSxUqEa+S2a\n\t/GGAQEjhS6qHw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656587663;\n\tbh=hzNPAzqOMDElkBvYw9x206+QzIYg6EWedFnZKR5AIoc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=kYwYbdX0V0UnPrvviAQyEMtt+npzTSDiUo8MqzwgPslFd6MMoWeVu0tX4C8ngtX53\n\tnkz2yIUT7BW2zWkZGuaTrkUZdXDTGWEgoK6wf6dXlVgYOl4us+nuLTYgmLuxUS7Y5g\n\tuiR6rjzIbDjHOg8a8ZaUJy/jla6sET1zQRKXcy30="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kYwYbdX0\"; dkim-atps=neutral","Message-ID":"","Date":"Thu, 30 Jun 2022 16:44:17 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20220630095521.23723-1-laurent.pinchart@ideasonboard.com>\n\t<165658678364.1516045.2827163888301953157@Monstersaurus>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Turn the\n\tcookie into a 64-bit integer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]