[{"id":23931,"web_url":"https://patchwork.libcamera.org/comment/23931/","msgid":"<165788493679.2228597.8254553663133163412@Monstersaurus>","date":"2022-07-15T11:35:36","subject":"Re: [libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on\n\tsrcpads access","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain via libcamera-devel (2022-06-30 07:34:43)\n> Use the std::vector::back() instead of [0] index which corresponds\n> to std::vector::push_back() for tracking of pads. This doesn't\n> introduce a functional change as the gst_libcamera_src_init() will\n> only add one pad but it helps with readability.\n> \n> Signed-off-by: Umang Jain \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 46fd02d2..4813ab96 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> gst_task_set_lock(self->task, &self->stream_lock);\n> \n> state->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n> - gst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n> + gst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());\n> \n> /* C-style friend. */\n> state->src_ = self;\n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17F06BD1F1\n\tfor ;\n\tFri, 15 Jul 2022 11:35:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F18263312;\n\tFri, 15 Jul 2022 13:35:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC8FC6330A\n\tfor ;\n\tFri, 15 Jul 2022 13:35:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B28D993;\n\tFri, 15 Jul 2022 13:35:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657884940;\n\tbh=wFeNIR5fsqgVCPnScKsrN1U3O9vHdNqGlBCRsGKMUqw=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=uveb8lwlPQvFf6ls+JB9pc2CmBZf7Yu5xyzKlOD1FaRhsIShsynhZyiRXbASqHL8G\n\thm9pZ48qH2hyqUh7D2FThQZrx55RSFyHu/UfQNY5l1tUI4dLXgqA8FfXFDtYtlYgL5\n\t8Jv4W11hjEIWk3K5fyhbOWErIuNFTJlMBdYOzTgCoyrOmFrB7Mr7PDpm3fY2DLMBCk\n\tx8ORBqK/K57Wzl89GidIomVOY1ogNrGc0N4IwMLvqPn4fc8LbKq/S/+4cJQVyInaXx\n\tzIvtEBRPumLLIY4EfrqdvVD5WxNW1WFalraeHZBhUIGGPBEwBn38fA//zxNeKFMa0g\n\tVYeDPq657KXaw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657884939;\n\tbh=wFeNIR5fsqgVCPnScKsrN1U3O9vHdNqGlBCRsGKMUqw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Flvo4Rx8gH3aJxN5RGlsq+YAODQ7HHyxKLw9Jx51YWBZ2ByvVFy6LJrirlwpSHWyI\n\tzKXkoRDoFICb37BOqqkNhgicubEHfCqxfuktwGpPy3fLXHNvnx2TBGDA5i2sV62ZXe\n\t8m+YUAihPcwJyDwRsqA5F9z2Dd3r8+c9ukY0WaV0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Flvo4Rx8\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220630063443.357054-1-umang.jain@ideasonboard.com>","References":"\n\t<20220630063443.357054-1-umang.jain@ideasonboard.com>","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Jul 2022 12:35:36 +0100","Message-ID":"<165788493679.2228597.8254553663133163412@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on\n\tsrcpads access","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23932,"web_url":"https://patchwork.libcamera.org/comment/23932/","msgid":"","date":"2022-07-15T11:39:15","subject":"Re: [libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on\n\tsrcpads access","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jul 15, 2022 at 12:35:36PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Umang Jain via libcamera-devel (2022-06-30 07:34:43)\n> > Use the std::vector::back() instead of [0] index which corresponds\n> > to std::vector::push_back() for tracking of pads. This doesn't\n> > introduce a functional change as the gst_libcamera_src_init() will\n> > only add one pad but it helps with readability.\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 46fd02d2..4813ab96 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> > gst_task_set_lock(self->task, &self->stream_lock);\n> > \n> > state->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n> > - gst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n> > + gst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());\n> > \n> > /* C-style friend. */\n> > state->src_ = self;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2BF9BE173\n\tfor ;\n\tFri, 15 Jul 2022 11:39:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C17D6330E;\n\tFri, 15 Jul 2022 13:39:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F5E06330A\n\tfor ;\n\tFri, 15 Jul 2022 13:39:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8F8B993;\n\tFri, 15 Jul 2022 13:39:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657885189;\n\tbh=sNuNCQ+jaSTfKh61yPmbEL6nDd5re6wym44gbsRZYvc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fpFg+kwedmL/f56MbEmqUaHQSk9EEsOpBdz31XiWJ7wVId61S9FiLIuINm9izOVc1\n\t6uB/oz/6UTAQziFCD/g1awdGtoRgxZpWFaMC9QRUp/0s/gjJsPmSr/ymcR5XL772Ez\n\t8gbE9x2eZ8g7QzpQ0ig2fkdjcBncxvKup7VYxA4pdWVvWwCdXDU+LlmCfnuEMiNDfI\n\ta/NZEv3/dQq1zVUSkhEuJxwBkqLUYsTuqeC23RWTJcN3Or9z6QfnWn70QdzAMt+4gf\n\tKHeYekdroRF3Mdru+8mn24dVM0ZCEa2rlOLi6r/PJ9l0lJTRgZzJLjICddBUmgwe4A\n\tdDnUPFSiGpwtA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657885187;\n\tbh=sNuNCQ+jaSTfKh61yPmbEL6nDd5re6wym44gbsRZYvc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mc897eEeDlpnmu6DYeSMxHy2Pki4FFgBZt5h6lsQs8o4W2d+BcnaJHKtklsKyPm4/\n\t3OMu2vGtu4m3nuv9CuhE8BcmvGBdvzr3hvQqN4riRQ3wBi2hQaNHYZNsyg0IARwvWK\n\tyAOglstosAEaGc1ffwfh6Mq1tJ1nEVO0MwIePaV0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mc897eEe\"; dkim-atps=neutral","Date":"Fri, 15 Jul 2022 14:39:15 +0300","To":"Kieran Bingham ","Message-ID":"","References":"\n\t<20220630063443.357054-1-umang.jain@ideasonboard.com>\n\t<165788493679.2228597.8254553663133163412@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165788493679.2228597.8254553663133163412@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on\n\tsrcpads access","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]