[{"id":23667,"web_url":"https://patchwork.libcamera.org/comment/23667/","msgid":"","date":"2022-06-30T00:19:47","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Be pedantic on srcpads\n\taccess","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, Jun 29, 2022 at 06:25:51PM +0530, Umang Jain via libcamera-devel wrote:\n> While the \"src\" pad is added to the element, it is accessed\n> via a index number. If multiple pads are added(in future)\n> and tracked in state->srcpads_, the index might need re-adjusting.\n\nDon't we already support multiple pads ? I don't foresee\nlibcamera_src_init() adding more than one pad, the other ones should be\nadded dynamically by gst_libcamera_src_request_new_pad() as far as I\nunderstand.\n\n> Use the std::vector::back() instead of index, which corresponds\n> to std::vector::push_back() for tracking of pads. It also slightly\n> helps with readability.\n> \n> No functional changes intended.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 46fd02d2..4813ab96 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> \tgst_task_set_lock(self->task, &self->stream_lock);\n> \n> \tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n> -\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n> +\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());\n\nI'm fine with the code change, but the commit message should be reworded\nif my understanding is right and this function will never add more than\none pad.\n\n> \n> \t/* C-style friend. */\n> \tstate->src_ = self;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A6A6BE173\n\tfor ;\n\tThu, 30 Jun 2022 00:20:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1F5665635;\n\tThu, 30 Jun 2022 02:20:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2675C6059D\n\tfor ;\n\tThu, 30 Jun 2022 02:20:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C82B59D;\n\tThu, 30 Jun 2022 02:20:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656548408;\n\tbh=u6CH9QeHGRtmzEGPcf0CPDh9gwXAwrT9TE5c5dnhMHs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wcSwYkM+BN4Lvc/9ki0QYplFKAKikY6t3PCLFTIAHYOLb3pqzVZcblsR9AKT6zVuT\n\tB0V1ZJBHsnmiPJ4UFIk+bQr6yY9hCBgOMpuVns9gM7k/sAz87K7FkUAJNOHy1muVG5\n\tnEi/2vSrFhs0NwanW4pHpOnqm7b6qz6lHUkHnTEu0k3PFQSIiIITQXkuBKrRsi3x7O\n\ti6qWJ//4xkVYzlLsbW9HMpzGRnDMgF3zmvWjltQz0IyUl+vZ4SNyrgnXKVoeiyvccr\n\tvLu4qhJmdg3Fkv70KTwbmIK/71L3jtzCN8cB+8h7s1iMwQXsITrYDsilUj93jolDzD\n\t+5BZmVHgzdMig==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656548407;\n\tbh=u6CH9QeHGRtmzEGPcf0CPDh9gwXAwrT9TE5c5dnhMHs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o/wuBomfQ7KDbwA/3PWHMZCKcErU9YKFoP4kI/jg0Aq5PigdznjS96iXrCp8PcZPQ\n\twGovqaJcUFURNfIJRO8KIzZrOgfQABN8cH/nyOqE/L4RnUw3x3Mj9+5QekMXShxXJm\n\tmnAWEv7NQk87yK1HRArD5GX+acD2ZMBLnRHPFago="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o/wuBomf\"; dkim-atps=neutral","Date":"Thu, 30 Jun 2022 03:19:47 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220629125551.330470-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220629125551.330470-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Be pedantic on srcpads\n\taccess","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, vedantparanjape160201@gmail.com,\n\tnicolas.dufresne@collabora.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23668,"web_url":"https://patchwork.libcamera.org/comment/23668/","msgid":"<76626e4a-ad93-4fd9-a312-c9bff20b9cb4@ideasonboard.com>","date":"2022-06-30T06:02:12","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Be pedantic on srcpads\n\taccess","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 6/30/22 05:49, Laurent Pinchart wrote:\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Wed, Jun 29, 2022 at 06:25:51PM +0530, Umang Jain via libcamera-devel wrote:\n>> While the \"src\" pad is added to the element, it is accessed\n>> via a index number. If multiple pads are added(in future)\n>> and tracked in state->srcpads_, the index might need re-adjusting.\n> Don't we already support multiple pads ? I don't foresee\n> libcamera_src_init() adding more than one pad, the other ones should be\n> added dynamically by gst_libcamera_src_request_new_pad() as far as I\n> understand.\n\n\nAh yes, that's correct. I didn't come across request_new_pad() earlier.\n\n>\n>> Use the std::vector::back() instead of index, which corresponds\n>> to std::vector::push_back() for tracking of pads. It also slightly\n>> helps with readability.\n>>\n>> No functional changes intended.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n>> index 46fd02d2..4813ab96 100644\n>> --- a/src/gstreamer/gstlibcamerasrc.cpp\n>> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n>> @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n>> \tgst_task_set_lock(self->task, &self->stream_lock);\n>> \n>> \tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n>> -\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n>> +\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());\n> I'm fine with the code change, but the commit message should be reworded\n> if my understanding is right and this function will never add more than\n> one pad.\n\n\nSubmitting v1.1 with commit message change.\n\n>\n>> \n>> \t/* C-style friend. */\n>> \tstate->src_ = self;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50DFFBD808\n\tfor ;\n\tThu, 30 Jun 2022 06:02:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B7B96564E;\n\tThu, 30 Jun 2022 08:02:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBC7160403\n\tfor ;\n\tThu, 30 Jun 2022 08:02:20 +0200 (CEST)","from [IPV6:2401:4900:1f3f:ca21:e286:106b:5da4:9482] (unknown\n\t[IPv6:2401:4900:1f3f:ca21:e286:106b:5da4:9482])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7D8C45F;\n\tThu, 30 Jun 2022 08:02:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656568941;\n\tbh=gauPwkuH/C96rsgkDGmOUYUWSCi83uGaOgJlILVmcpc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NYmEu9jyeoiD2UiTw26vVJQx47rjWFdzi4tq9/kqM363K6R0r0tYhWgLgeNj+IZoa\n\thPgsMMH10jTLLDFZVnL9nG1TPC2125dVzbFYuhVw8/UrwroPl4j7kaxvjIJPFCoaEM\n\tL3rviVpKDanPQeRoXs/kQYA6sDIFK95QOWW2P8b9UFeI38PUJ/+h+OGt9JgQ/4d6nb\n\tvX4eKUgUdnp6Cr6qLmkSmB3PXhAYWzPOfMhzcYFVtlxNjLBHnskEhfJljhrkFO4rnL\n\tHnm6mpX9lugNF21+m/TddheUj9FbkPvGE94qzVVJHXQqHMRQHxV5/gIMkN7NsgsStJ\n\thkNwF0t6Tgjaw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656568940;\n\tbh=gauPwkuH/C96rsgkDGmOUYUWSCi83uGaOgJlILVmcpc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=JQa2fSUhztxxMlyt51r9PO5OvIvyu6QqPb7RgdL7NhjPRGcPY45yqVTF8NRhKyXdc\n\to5nnWW8VKZxAtWANy19fnWggRyszQgJuoO0d4PjxbI3cfCK1Gxx/EH9fzKOvtxNO/z\n\tnVL95U4yupaOCXU1s5RnpC3pkeNHydxCfiJV30/4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JQa2fSUh\"; dkim-atps=neutral","Message-ID":"<76626e4a-ad93-4fd9-a312-c9bff20b9cb4@ideasonboard.com>","Date":"Thu, 30 Jun 2022 11:32:12 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20220629125551.330470-1-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Be pedantic on srcpads\n\taccess","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org, vedantparanjape160201@gmail.com,\n\tnicolas.dufresne@collabora.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23681,"web_url":"https://patchwork.libcamera.org/comment/23681/","msgid":"","date":"2022-06-30T10:17:30","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Be pedantic on srcpads\n\taccess","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Hello Umang,\n\nThanks for the patch. here's the rb tag with Laurent's suggestion on\ncommit message, since multi pads is already supported.\n\nReviewed-by: Vedant Paranjape \n\n\nOn Wed, Jun 29, 2022 at 2:56 PM Umang Jain wrote:\n>\n> While the \"src\" pad is added to the element, it is accessed\n> via a index number. If multiple pads are added(in future)\n> and tracked in state->srcpads_, the index might need re-adjusting.\n>\n> Use the std::vector::back() instead of index, which corresponds\n> to std::vector::push_back() for tracking of pads. It also slightly\n> helps with readability.\n>\n> No functional changes intended.\n>\n> Signed-off-by: Umang Jain \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 46fd02d2..4813ab96 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> gst_task_set_lock(self->task, &self->stream_lock);\n>\n> state->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n> - gst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n> + gst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());\n>\n> /* C-style friend. */\n> state->src_ = self;\n> --\n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27269BE173\n\tfor ;\n\tThu, 30 Jun 2022 10:17:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E64D865650;\n\tThu, 30 Jun 2022 12:17:43 +0200 (CEST)","from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com\n\t[IPv6:2607:f8b0:4864:20::112a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFD6C6564E\n\tfor ;\n\tThu, 30 Jun 2022 12:17:42 +0200 (CEST)","by mail-yw1-x112a.google.com with SMTP id\n\t00721157ae682-3178acf2a92so174109897b3.6\n\tfor ;\n\tThu, 30 Jun 2022 03:17:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656584263;\n\tbh=GhskUbE6mm4XEljDdwJytRK6eF3lDSfzxKRlXlApJp4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=d97GXT366ALALCMEbFc+7eRWZPulUDM2A8E1KIW18DLH8MoG7/ptgzL/tuZyiYLBk\n\tzThbXmRAr3h7P0FY+b/yi0ptZ2ckGQBoGz5SyZSEkfH0HiWnTl/FiruuFXiTOyDn67\n\tTFUePfNhQwOaZaQ0BhB8dRPhTUTpvt88JgsmCtmpsj2jy/5k2VSyiKrHqTwjgQZPaV\n\tNVIvFOzcCG0iEv+vqTqenTaLOKmxuin58R4uWfQ4b7K/QqAD+WUGMaAr7pZdFABj/T\n\tegwVYXli26oc6hyPK/S91Rkjti43lg5D/UCO2NnrEMJl4iXgCF0FvrJ/e5DyS9KCfq\n\t/xrOGBG30D3tQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=OlVC5Vdu4gBf12tawggIFhlZlHHJ7iLNiEHdBKjKLnk=;\n\tb=DdNhDV/AnTtTcghLLR0cTAFj3PUvxhNCnNOYeLs9q42m2CKfYPXlzNhXAEODXK8RLi\n\tJHWULQlwqulHt4XnQOoi1TzRK3D+8P+0ZGE9KLzTSOd1mClKaPPvu4pfObpJXIOp/wql\n\tCvWeRq+YfDlF7ZckPCmCNbIs8Jyc2V0JZQKPaLzKibkAvP1L8UCCHPJ/v9wcZ5k/Aegp\n\tPSHa5E0JB+p2l3rqZ9aIr5lKt6z71Jl4+aWMVd7ULP4ePGB3STHEIDnmjEJ7ySX+MSKl\n\t1IH9DjXEZGJQCDXuoTngxGnJiHDRI87TfBEeG7MNhzBCfoZxazEUCiZf+b2sAXF9QrIe\n\tkE6w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DdNhDV/A\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=OlVC5Vdu4gBf12tawggIFhlZlHHJ7iLNiEHdBKjKLnk=;\n\tb=nVIL6P3qevd6XgBYnLbeeoMUs5o7/hsvJnfwvUvpYprKsY6kTBCVb/cMIl4OiF73oF\n\tlFNKNbAaRDh33ECanKlsZpXeRhev0/uja6m91UcH9OfZZQl+ZTFHgI0TwVVxNw/v9+0Q\n\tHgo2BoEr+LpJvC1giQOhh6ENSYHM7DMZBRROqTKYkjgpx2ornlfzShE7UHjhpShhB1Jw\n\t1VdVDDxzWRfZ54D4llSEKY0IbDeMd0fFSF8vjuSrWbQIBt3cZ0RYSpyPHg9XFyIz/pZe\n\tABpWXJcfIslIqD5m+3022x9M/4J8brFhBF5h8IHpnG9//n1U4Jn1aGWnLwcDFlKNDApS\n\tIAkQ==","X-Gm-Message-State":"AJIora8l9IvkeSuLywNLrcS3xmk0QIg4HB/HILEC6WKi7C7kD4yrYjyh\n\tyaHf7z9iJL1KyTSzEFRl7TQ8ozfTwehnJwD+8L5eOufUI5Fj6A==","X-Google-Smtp-Source":"AGRyM1t+blcDWw68ZMcmNCyu5RECbRWUcg2aBUEYq5cs3Ow/y7uJx6bfx/tbKuX1285yn3DludeY3KAXjMbjAyK71dU=","X-Received":"by 2002:a81:bd51:0:b0:31b:db72:88a1 with SMTP id\n\tn17-20020a81bd51000000b0031bdb7288a1mr9269457ywk.208.1656584261733;\n\tThu, 30 Jun 2022 03:17:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20220629125551.330470-1-umang.jain@ideasonboard.com>","In-Reply-To":"<20220629125551.330470-1-umang.jain@ideasonboard.com>","Date":"Thu, 30 Jun 2022 12:17:30 +0200","Message-ID":"","To":"Umang Jain ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Be pedantic on srcpads\n\taccess","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Vedant Paranjape via libcamera-devel\n\t","Reply-To":"Vedant Paranjape ","Cc":"LibCamera Devel ,\n\tNicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]