[{"id":24038,"web_url":"https://patchwork.libcamera.org/comment/24038/","msgid":"<Ytm1V5mzYuePCcg8@pendragon.ideasonboard.com>","date":"2022-07-21T20:21:43","subject":"Re: [libcamera-devel] [PATCH v2 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kunal,\n\nThank you for the patch.\n\nOn Wed, Jun 29, 2022 at 12:42:38AM +0530, Kunal Agarwal via libcamera-devel wrote:\n> Currently there is no defined precision for data types\n> which results in compilation errors for shader.\n\nThat's true for OpenGL ES only, I'd update this to\n\nThe OpenGL ES shading language has no default precision declared\nimplicitly for floats in fragment shaders. The lack of an explicit\ndefault precision results in shader compilation errors\n\n> Adding precision mediump for sufficient and required\n> range and accuracy. Also suitable for textures.\n\nWhat do you mean by \"Also suitable for textures\" ?\n\n> Precision highp also works but is not supported by some\n> older hardware devices and consumes more memory.\n\nWhich hardware would that be ? If you don't know, I'd write this as\n\nSpecify a default precision of mediump for floats. This matches the\nother fragment shaders, and is guaranteed by the OpenGL ES shader\nlanguage specification to be supported by all devices, while the higher\nprecision highp is optional.\n\nIf you're fine with the above modifications, there's no need to resubmit\nthe patch, I can update the commit message when applying.\n\n> Signed-off-by: Kunal Agarwal <kunalagarwal1072002@gmail.com>\n> ---\n>  src/qcam/assets/shader/bayer_8.frag | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 4ece44ab..7e35ca88 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -15,6 +15,9 @@ Copyright (C) 2021, Linaro\n>  */\n>  \n>  //Pixel Shader\n> +#ifdef GL_ES\n> +precision mediump float;\n> +#endif\n>  \n>  /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n>  uniform sampler2D       tex_y;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71C71BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 20:21:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33F336330F;\n\tThu, 21 Jul 2022 22:21:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5944F603F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 22:21:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D315A496;\n\tThu, 21 Jul 2022 22:21:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658434908;\n\tbh=sq0ZYhoXSwxa/kASI8HwveT+tfMxkeG7pKHaT5UsXHI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=T8yqQK4qNJB381X57DLc6bJIk7nrpNYxWSoATew7nICe3nvitqu1WOeS2WKKVoTxk\n\tlzh2+RCxLtwtS5RCEqTNpIHQSa0g+r+ZZE1SiUsjmMsjGJj+rkAP2QKj4KRS8OEoZ7\n\tHXuftJyu0DX13fXEsdfrRT/kMv+BrcU7IvqmEf6xprCD/ikjcK7475c/D4y4WxfrC3\n\tHADzhOPWGXMXJOqizdcLsG/QlBlg+LJbcdgv9n0ko0KbYY2SBGyaBqfT9RljvqGb3k\n\t7J3h6aojDSB9VoZAxG0/IKp4XPGV8JLndiIAuqi/6av6GHVljUGNvhE9geM2fNif/q\n\tjhzV0ExZS194A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658434906;\n\tbh=sq0ZYhoXSwxa/kASI8HwveT+tfMxkeG7pKHaT5UsXHI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e+8294/AxinQEZrqyFkfRUj8REKYMLm9nlY/yo44KYWgmUq+2lw6dxZLbPXZUyEdm\n\t5Z2PoyKXETGAedG+T7AmyDDmgIYXSopolqzhVoJYmReNzFrWhYp3lgigXktlFhfIaL\n\tIXraAjkVszfrwD22BvrEyD1bbkcNjvmUhTfx/i18="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e+8294/A\"; dkim-atps=neutral","Date":"Thu, 21 Jul 2022 23:21:43 +0300","To":"Kunal Agarwal <kunalagarwal1072002@gmail.com>","Message-ID":"<Ytm1V5mzYuePCcg8@pendragon.ideasonboard.com>","References":"<20220628191238.78202-1-kunalagarwal1072002@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220628191238.78202-1-kunalagarwal1072002@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":24039,"web_url":"https://patchwork.libcamera.org/comment/24039/","msgid":"<Ytm1pa2fGRICsDy9@pendragon.ideasonboard.com>","date":"2022-07-21T20:23:01","subject":"Re: [libcamera-devel] [PATCH v2 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jul 21, 2022 at 11:21:45PM +0300, Laurent Pinchart wrote:\n> Hi Kunal,\n> \n> Thank you for the patch.\n> \n> On Wed, Jun 29, 2022 at 12:42:38AM +0530, Kunal Agarwal via libcamera-devel wrote:\n> > Currently there is no defined precision for data types\n> > which results in compilation errors for shader.\n> \n> That's true for OpenGL ES only, I'd update this to\n> \n> The OpenGL ES shading language has no default precision declared\n> implicitly for floats in fragment shaders. The lack of an explicit\n> default precision results in shader compilation errors\n> \n> > Adding precision mediump for sufficient and required\n> > range and accuracy. Also suitable for textures.\n> \n> What do you mean by \"Also suitable for textures\" ?\n> \n> > Precision highp also works but is not supported by some\n> > older hardware devices and consumes more memory.\n> \n> Which hardware would that be ? If you don't know, I'd write this as\n> \n> Specify a default precision of mediump for floats. This matches the\n> other fragment shaders, and is guaranteed by the OpenGL ES shader\n> language specification to be supported by all devices, while the higher\n> precision highp is optional.\n> \n> If you're fine with the above modifications, there's no need to resubmit\n> the patch, I can update the commit message when applying.\n\nAnd I forgot to mention,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> > Signed-off-by: Kunal Agarwal <kunalagarwal1072002@gmail.com>\n> > ---\n> >  src/qcam/assets/shader/bayer_8.frag | 3 +++\n> >  1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> > index 4ece44ab..7e35ca88 100644\n> > --- a/src/qcam/assets/shader/bayer_8.frag\n> > +++ b/src/qcam/assets/shader/bayer_8.frag\n> > @@ -15,6 +15,9 @@ Copyright (C) 2021, Linaro\n> >  */\n> >  \n> >  //Pixel Shader\n> > +#ifdef GL_ES\n> > +precision mediump float;\n> > +#endif\n> >  \n> >  /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n> >  uniform sampler2D       tex_y;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45A75BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 20:23:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 043ED6330F;\n\tThu, 21 Jul 2022 22:23:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0A36601B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 22:23:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30337496;\n\tThu, 21 Jul 2022 22:23:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658434985;\n\tbh=dAD0NV+c1L0R8+ZXfIcJ/VtEbnaI8BMpRUqx4/dnJtw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ubtaC66NeezjFzXTROi3fVbCyBNq6j2SzWogkzGh5y6h3OwMTEWRTbC+Q9W/MdNJv\n\t/ZWdZkvql8MMMUqRJefyrsJSbnkPgtVSXwTmDuKxHHacrt7dLo4RHNK63d2itMnzg0\n\t+yO+Fy0B1wWY/8AVhfhqwoG+Hy7LlbkJW4On9hlJhuk4BOWPdHnOJsKmKkY55tsMdH\n\tCYEL5u93VkZRnwP5znxy4x4d13Q/Vlx4vN6Olu9b4GrGBdLK6LyQZ/vUHqFYIT1gLz\n\t+ywxo0VvNOGv9XHZAQ5qWYSGRjZGGnlUHUdD7cuVLi5/lUSjV8xquVOw8sUylaXkxk\n\tcixV5BnAh7aqw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658434983;\n\tbh=dAD0NV+c1L0R8+ZXfIcJ/VtEbnaI8BMpRUqx4/dnJtw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MbKyCnCX24Sgrl1w8HqJsMh/NT29TCU9s8geqkxeSM3JWWlxof2XgiU9wxE2W5pK4\n\tSCB9LtJx3HS46GowasZIreVWvhGTFpUcy/4yqnUx/Oby57Pnldle/6oRL2QyfNDuiP\n\tITq9/wgZKtNXCQUSD7yXdo5SRojDIUqOwPEVPZas="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MbKyCnCX\"; dkim-atps=neutral","Date":"Thu, 21 Jul 2022 23:23:01 +0300","To":"Kunal Agarwal <kunalagarwal1072002@gmail.com>","Message-ID":"<Ytm1pa2fGRICsDy9@pendragon.ideasonboard.com>","References":"<20220628191238.78202-1-kunalagarwal1072002@gmail.com>\n\t<Ytm1V5mzYuePCcg8@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<Ytm1V5mzYuePCcg8@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":24052,"web_url":"https://patchwork.libcamera.org/comment/24052/","msgid":"<CAJP1LGaB_maJ0ufdMig4-ZNHYmDx8dt5MDRrr=083BpThpJgEA@mail.gmail.com>","date":"2022-07-22T09:00:24","subject":"Re: [libcamera-devel] [PATCH v2 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","submitter":{"id":116,"url":"https://patchwork.libcamera.org/api/people/116/","name":"Kunal Agarwal","email":"kunalagarwal1072002@gmail.com"},"content":"Hi Laurent,\n\n> That's true for OpenGL ES only, I'd update this to\n>\n> The OpenGL ES shading language has no default precision declared\n> implicitly for floats in fragment shaders. The lack of an explicit\n> default precision results in shader compilation errors\n\nYes, mentioning OpenGl ES would be required. Thanks\n\n> What do you mean by \"Also suitable for textures\" ?\n\nThis can be ignored I think. Not very sure of it. Read it somewhere\n\n> Which hardware would that be ? If you don't know, I'd write this as\n>\n> Specify a default precision of mediump for floats. This matches the\n> other fragment shaders, and is guaranteed by the OpenGL ES shader\n> language specification to be supported by all devices, while the higher\n> precision highp is optional.\n\nNow that I read about it again, that limitation is only for some older phones.\n\n> If you're fine with the above modifications, there's no need to resubmit\n> the patch, I can update the commit message when applying.\n\nYes, That would be great. Thanks\n\nRegards,\n\nKunal Agarwal\n\n\n\n\nOn Fri, Jul 22, 2022 at 1:53 AM Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> On Thu, Jul 21, 2022 at 11:21:45PM +0300, Laurent Pinchart wrote:\n> > Hi Kunal,\n> >\n> > Thank you for the patch.\n> >\n> > On Wed, Jun 29, 2022 at 12:42:38AM +0530, Kunal Agarwal via libcamera-devel wrote:\n> > > Currently there is no defined precision for data types\n> > > which results in compilation errors for shader.\n> >\n> > That's true for OpenGL ES only, I'd update this to\n> >\n> > The OpenGL ES shading language has no default precision declared\n> > implicitly for floats in fragment shaders. The lack of an explicit\n> > default precision results in shader compilation errors\n> >\n> > > Adding precision mediump for sufficient and required\n> > > range and accuracy. Also suitable for textures.\n> >\n> > What do you mean by \"Also suitable for textures\" ?\n> >\n> > > Precision highp also works but is not supported by some\n> > > older hardware devices and consumes more memory.\n> >\n> > Which hardware would that be ? If you don't know, I'd write this as\n> >\n> > Specify a default precision of mediump for floats. This matches the\n> > other fragment shaders, and is guaranteed by the OpenGL ES shader\n> > language specification to be supported by all devices, while the higher\n> > precision highp is optional.\n> >\n> > If you're fine with the above modifications, there's no need to resubmit\n> > the patch, I can update the commit message when applying.\n>\n> And I forgot to mention,\n>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> > > Signed-off-by: Kunal Agarwal <kunalagarwal1072002@gmail.com>\n> > > ---\n> > >  src/qcam/assets/shader/bayer_8.frag | 3 +++\n> > >  1 file changed, 3 insertions(+)\n> > >\n> > > diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> > > index 4ece44ab..7e35ca88 100644\n> > > --- a/src/qcam/assets/shader/bayer_8.frag\n> > > +++ b/src/qcam/assets/shader/bayer_8.frag\n> > > @@ -15,6 +15,9 @@ Copyright (C) 2021, Linaro\n> > >  */\n> > >\n> > >  //Pixel Shader\n> > > +#ifdef GL_ES\n> > > +precision mediump float;\n> > > +#endif\n> > >\n> > >  /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n> > >  uniform sampler2D       tex_y;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75163BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Jul 2022 09:00:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAFA463314;\n\tFri, 22 Jul 2022 11:00:38 +0200 (CEST)","from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com\n\t[IPv6:2607:f8b0:4864:20::e2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AF1B6330B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Jul 2022 11:00:37 +0200 (CEST)","by mail-vs1-xe2d.google.com with SMTP id t127so3764374vsb.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Jul 2022 02:00:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658480438;\n\tbh=SGhXfZ2X7MNRwIjyiIsucLbeMktctjBa9nTHA1tAG4I=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Wp3fkWXsjTiTofNGIZvYlBZJGfuZ56qfow3EB6Unc1CoSddwdLJfRJ3uoOEgGye4Q\n\tct2esQR7zn31jSTuMRg4ehEECCaXZYnTLvD5EtPBa37OEIzufTao0fDp09xE4J5/ZA\n\tibSZ1FRzaDrzDMAaSlfUW0MhpsjH7c6Ga4iZSoY48Y4rcnG9JYz1n9iSFlN9VmbqhN\n\tCJb+9fDyscC+Qpqqf89G+XUd2eGRWkNsPrZa6IjHTqG1FHoZ78e32QLy17GgXFc2kq\n\t4dBPsFtwnkN31RgZ+cN0XcrZxsNjNtYzS6Twe03UMafF6hkshUlwExqrNie1fCAlw4\n\t9ALzRyAwnfpaQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=3vQgwMVDZDoefdyLQnFT2eJII+XPT34SjP2mXSb7t+w=;\n\tb=jmrc/PDCVBlDajdSIoy91i9tCfhZyjyVdXigtHTOvUgpeQ9X5Tu32bbmRDajU7JWQz\n\taBiqQfe4RijWU62K+qxJkQrCSLf9GDj71BBNyhwG8xDzQ0hWZqdu05sbqMXcDct0aElW\n\tKNt6JqeKF2FurRv6c8hTDS1YML2IM1XrgR9wMH9brLb7FVFf+/XA2OpNqsW6T42j0x2K\n\tnyP6wh0X0FbyBtQh5EnNkLYGaM0eYI191c7OgaVBkvcPxgYTme1P8AwjHCLnkA8xC55f\n\tlJVtF8gVMclK+wBBY5VnyRYJ/LU1EtfayM7vQNnxEqydVGk309aDMBAbKvCo9GkQe6KQ\n\tZiug=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jmrc/PDC\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=3vQgwMVDZDoefdyLQnFT2eJII+XPT34SjP2mXSb7t+w=;\n\tb=t8Hzw2/hnYi4TBmXZl8rwSBgYR4cEsb8W3xXUf+iucy7DLYw3BQ5V6d9bpk1LXy980\n\tjcbmW0mwUX4GDLNlEM0GFym5VTdE3vrBlej7/VA0lkx5pIIoBG5n1ByyO9nx4DVUzvtf\n\tP6eaMGfZB4Ff6Nq2qcONpE5S7RRGG7JtbnTdrKp1kwoSdlS3gDcfD4fHHiGF+gv3gHMO\n\t8zhpbGDx0jRgmJ9Wd2CsCWdSsQOKTWyRKJ9GK7ppYRlOmNrRYSuIIloAkw0d6Dzo5Zqh\n\tKLnvs/MAwkdlmY7S0zxgLnfS9qHzIAcMmMqNZYqEre4cUzg36XXtLwyEw09UdGJKVFN1\n\tDC0Q==","X-Gm-Message-State":"AJIora9bdo7R4AQk66WciDCfkRHTUqnMRS0Ut2kKREbIUAa0w8lgK77P\n\tTdwNFewv5FkXAW1Tl9fv+yWOkqM21dL5EkBjBoyYQDbkHPA=","X-Google-Smtp-Source":"AGRyM1ugocT3Jc8mJk/XyHmW59bu70wrHcpFpegHm+2T9bN5DfHqysTaRFWMg0P+6WEj/Xv6PVgKEAh+y8P7RCWH11o=","X-Received":"by 2002:a67:cc1a:0:b0:358:3a5f:fec1 with SMTP id\n\tq26-20020a67cc1a000000b003583a5ffec1mr695093vsl.61.1658480435983;\n\tFri, 22 Jul 2022 02:00:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20220628191238.78202-1-kunalagarwal1072002@gmail.com>\n\t<Ytm1V5mzYuePCcg8@pendragon.ideasonboard.com>\n\t<Ytm1pa2fGRICsDy9@pendragon.ideasonboard.com>","In-Reply-To":"<Ytm1pa2fGRICsDy9@pendragon.ideasonboard.com>","Date":"Fri, 22 Jul 2022 14:30:24 +0530","Message-ID":"<CAJP1LGaB_maJ0ufdMig4-ZNHYmDx8dt5MDRrr=083BpThpJgEA@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kunal Agarwal via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Kunal Agarwal <kunalagarwal1072002@gmail.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]