[{"id":23876,"web_url":"https://patchwork.libcamera.org/comment/23876/","msgid":"<20220714145401.p42u5cndzeqgqvj2@uno.localdomain>","date":"2022-07-14T14:54:01","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: rkisp1: ipa: Rename\n\tctrls_ to sensorCtrls_","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Daniel,\n\nOn Tue, Jun 28, 2022 at 11:06:55AM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> As additional controls will be added to the IPA (like lens), we want to\n> have more specific names for each ControlInfoMap.\n>\n> Signed-off-by: Daniel Semkowicz \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 7d6f0b39..3511a054 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -65,7 +65,7 @@ private:\n> \tstd::map buffers_;\n> \tstd::map mappedBuffers_;\n>\n> -\tControlInfoMap ctrls_;\n> +\tControlInfoMap sensorCtrls_;\n>\n> \t/* Camera sensor controls. */\n> \tbool autoExposure_;\n> @@ -148,16 +148,16 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> \tif (entityControls.empty())\n> \t\treturn -EINVAL;\n>\n> -\tctrls_ = entityControls.at(0);\n> +\tsensorCtrls_ = entityControls.at(0);\n>\n> -\tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n> -\tif (itExp == ctrls_.end()) {\n> +\tconst auto itExp = sensorCtrls_.find(V4L2_CID_EXPOSURE);\n> +\tif (itExp == sensorCtrls_.end()) {\n> \t\tLOG(IPARkISP1, Error) << \"Can't find exposure control\";\n> \t\treturn -EINVAL;\n> \t}\n>\n> -\tconst auto itGain = ctrls_.find(V4L2_CID_ANALOGUE_GAIN);\n> -\tif (itGain == ctrls_.end()) {\n> +\tconst auto itGain = sensorCtrls_.find(V4L2_CID_ANALOGUE_GAIN);\n> +\tif (itGain == sensorCtrls_.end()) {\n> \t\tLOG(IPARkISP1, Error) << \"Can't find gain control\";\n> \t\treturn -EINVAL;\n> \t}\n> @@ -284,7 +284,7 @@ void IPARkISP1::setControls(unsigned int frame)\n> \tuint32_t exposure = context_.frameContext.agc.exposure;\n> \tuint32_t gain = camHelper_->gainCode(context_.frameContext.agc.gain);\n>\n> -\tControlList ctrls(ctrls_);\n> +\tControlList ctrls(sensorCtrls_);\n> \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure));\n> \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain));\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DA26BD1F1\n\tfor ;\n\tThu, 14 Jul 2022 14:54:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D060163312;\n\tThu, 14 Jul 2022 16:54:05 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26B0D6330D\n\tfor ;\n\tThu, 14 Jul 2022 16:54:04 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 6A952100006;\n\tThu, 14 Jul 2022 14:54:03 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657810445;\n\tbh=NOrpfZ8YKARZ8kXVLf7sOnBt85kNR6GBRolS7Chtehw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ExqHwMHIau2C+a43KNxvNDt2inQPqW7nq5UGBBwfJmFQG1oZOhD7z8NM0/PMLdbwr\n\tJEj+kxfc+EXiCKOslFNS1wHmyRfOzZphAoPwdCHW6mzChbTzEaz1lvFP9ErKwjSl7x\n\tuUa8+XRlt6jKFuzLepC3oMyIwvvJCi479w4vgmDPO2aj4t4xEuP8P1SLWTmeWnfH/I\n\txShneSUeLP1vmqzUFi1gqSVs7nwXhBIYvfMYSxlpMLfHbC4o4DTir6EvUxm1OOrA0S\n\tPgROXrE57PZVI2AIBPrPRJ95HXEpglWwrMsjqFnpPA+V3ATOdeF61QkAb0wUzLVzxL\n\tLpefL/spvTuFQ==","Date":"Thu, 14 Jul 2022 16:54:01 +0200","To":"Daniel Semkowicz ","Message-ID":"<20220714145401.p42u5cndzeqgqvj2@uno.localdomain>","References":"<20220628090656.19572-1-dse@thaumatec.com>\n\t<20220628090656.19572-3-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220628090656.19572-3-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: rkisp1: ipa: Rename\n\tctrls_ to sensorCtrls_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]