[{"id":2221,"web_url":"https://patchwork.libcamera.org/comment/2221/","msgid":"<20190711062430.GI5247@pendragon.ideasonboard.com>","date":"2019-07-11T06:24:30","subject":"Re: [libcamera-devel] [PATCH v3 7/7] libcamera: ipa: meson: build\n\tdummy IPA that needs isolation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 10, 2019 at 03:44:50AM +0900, Paul Elder wrote:\n> Add the dummy IPA that needs isolation to meson. At the same time, clean\n> up the IPA meson to facilitate adding more IPAs.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v3:\n> - remove sub install directory for IPAs\n> \n> Changes in v2:\n> - make a sub install directory for IPAs, to keep them separate from the\n> proxies\n> - remove shim compilation\n> \n> src/ipa/meson.build | 21 ++++++++++++---------\n> 1 file changed, 12 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 3c33a37..2b9863b 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -1,15 +1,18 @@\n> -ipa_dummy_sources = files([\n> - 'ipa_dummy.cpp',\n> -])\n> +ipa_dummy_sources = [\n> + ['ipa_dummy', 'ipa_dummy.cpp'],\n> + ['ipa_dummy_isolate', 'ipa_dummy_isolate.cpp'],\n> +]\n> \n> ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> \n> -ipa_dummy = shared_library('ipa_dummy',\n> - ipa_dummy_sources,\n> - name_prefix : '',\n> - include_directories : libcamera_includes,\n> - install : true,\n> - install_dir : ipa_install_dir)\n> +foreach t : ipa_dummy_sources\n> + ipa = shared_module(t[0],\n> + t[1],\n> + name_prefix : '',\n> + include_directories : libcamera_includes,\n> + install : true,\n> + install_dir : ipa_install_dir)\n> +endforeach\n> \n> config_h.set('IPA_MODULE_DIR',\n> '\"' + join_paths(get_option('prefix'), ipa_install_dir) + '\"')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9209060C23\n\tfor ;\n\tThu, 11 Jul 2019 08:24:58 +0200 (CEST)","from pendragon.ideasonboard.com (softbank126163157105.bbtec.net\n\t[126.163.157.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3478D31C;\n\tThu, 11 Jul 2019 08:24:56 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562826298;\n\tbh=mlq+yEE2OuGchLklut/N1FIngfletNMzgKr5lK/h6eo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=guMBWrfRixdOIWomvYsQK3zCqAUXCE0VA4VqR/wKO3+pZ2KsGjjZonQQO1kjSaBU2\n\taDL+IXtaQ8P2TDPkMHSjbhreyzFlXg+S9NrV7VkqePfMzU5pazMeQn8O47Ine73nJh\n\t4dxU3feukyebZulfMXAtEswBpQEa1f/5F6jcs3pk=","Date":"Thu, 11 Jul 2019 09:24:30 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190711062430.GI5247@pendragon.ideasonboard.com>","References":"<20190709184450.32023-1-paul.elder@ideasonboard.com>\n\t<20190709184450.32023-8-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190709184450.32023-8-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 7/7] libcamera: ipa: meson: build\n\tdummy IPA that needs isolation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jul 2019 06:24:58 -0000"}}]