{"id":16387,"url":"https://patchwork.libcamera.org/api/patches/16387/?format=json","web_url":"https://patchwork.libcamera.org/patch/16387/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220627162732.33160-7-jacopo@jmondi.org>","date":"2022-06-27T16:27:23","name":"[libcamera-devel,06/15] libcamera: ipu3: Initialize DelayedControls with camera properties","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"1c5858d68064ef68f6b8015b1a255e9ed671060e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16387/mbox/","series":[{"id":3224,"url":"https://patchwork.libcamera.org/api/series/3224/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3224","date":"2022-06-27T16:27:17","name":"Internal controls, sensor delays and IPA init/configure rework","version":1,"mbox":"https://patchwork.libcamera.org/series/3224/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16387/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16387/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1BBBBD808\n\tfor ;\n\tMon, 27 Jun 2022 16:27:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55EDC65645;\n\tMon, 27 Jun 2022 18:27:52 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39ACF65644\n\tfor ;\n\tMon, 27 Jun 2022 18:27:46 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 315F220009;\n\tMon, 27 Jun 2022 16:27:44 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656347272;\n\tbh=DTtd03qxnOavgVCgD4PzR0t9PU2WvibBUcL0Q4807Ro=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=N+ulLedzUIpoIPbgIBzCvOxSA7IagkQWfH3nClsV0PJIGvJOjAdBVPh9s8pz6DAlE\n\tvGU7kB2Euxukgds5DIVy9tDLwPsjVihiJqvscJlxLVv6S32QE1QCWiHQYCPSk3eP5H\n\tCr1PFx201vr/rUXHaQtC48vq5gRXBW4+qwIneq/FHK0mTJTXSQQma/AY9+gvxElYye\n\tvrygXjZCja1ZwTo0H/lydzNiWt+HGRw9CZ8v3iYjauopHv/Pn1KwBHbn2rP1KL4vbJ\n\tpXqKu9sOWlL74kjQyJNaV5jEWb1OEkY1QtD2us2xfaMHzgKzCBJY4ZVM3dLaYWL1n0\n\tzv+NUSOgUZ62Q==","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 27 Jun 2022 18:27:23 +0200","Message-Id":"<20220627162732.33160-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.36.1","In-Reply-To":"<20220627162732.33160-1-jacopo@jmondi.org>","References":"<20220627162732.33160-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 06/15] libcamera: ipu3: Initialize\n\tDelayedControls with camera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the sensor control delays as reported by the camera sensor\nproperties map to intialize delayed controls for the IPU3 platform.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 30 ++++++++++++++++++++++------\n 1 file changed, 24 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex b7dda282faab..19d022c584ed 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1127,13 +1127,31 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t\tcontinue;\n \n \t\t/*\n-\t\t * \\todo Read delay values from the sensor itself or from a\n-\t\t * a sensor database. For now use generic values taken from\n-\t\t * the Raspberry Pi and listed as 'generic values'.\n+\t\t * Get the sensor delays and validate the required controls\n+\t\t * are reported.\n \t\t */\n-\t\tstd::unordered_map params = {\n-\t\t\t{ V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n-\t\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n+\t\tconst CameraSensor::SensorDelays &sensorDelays = cio2->sensor()->sensorDelays();\n+\t\tif (!sensorDelays.count(&controls::internal::ExposureTime) ||\n+\t\t !sensorDelays.count(&controls::internal::draft::SensorAnalogueGain)) {\n+\t\t\tLOG(IPU3, Error) << \"Missing sensor control delays\";\n+\t\t\treturn -ENODEV;\n+\t\t}\n+\n+\t\tconst std::unordered_map params{\n+\t\t\t{\n+\t\t\t\tV4L2_CID_ANALOGUE_GAIN,\n+\t\t\t\t{\n+\t\t\t\t\tsensorDelays.at(&controls::internal::draft::SensorAnalogueGain),\n+\t\t\t\t\tfalse,\n+\t\t\t\t},\n+\t\t\t},\n+\t\t\t{\n+\t\t\t\tV4L2_CID_EXPOSURE,\n+\t\t\t\t{\n+\t\t\t\t\tsensorDelays.at(&controls::internal::ExposureTime),\n+\t\t\t\t\tfalse,\n+\t\t\t\t},\n+\t\t\t},\n \t\t};\n \n \t\tdata->delayedCtrls_ =\n","prefixes":["libcamera-devel","06/15"]}