[{"id":23611,"web_url":"https://patchwork.libcamera.org/comment/23611/","msgid":"","date":"2022-06-27T15:46:32","subject":"Re: [libcamera-devel] [PATCH 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kunal,\n\nThank you for the patch.\n\nOn Mon, Jun 27, 2022 at 08:54:05PM +0530, Kunal Agarwal via libcamera-devel wrote:\n> Add precision for data types\n\nThis explains what the patch does, but is missing the most important\npiece of information: why is this needed ? A word about why you picked\nmediump would also be helpful.\n\nhttps://cbea.ms/git-commit/#why-not-how is a good read when it comes to\nhow to write good commit messages.\n\nThe same applies to patch 2/2.\n\n> Signed-off-by: Kunal Agarwal \n> ---\n> src/qcam/assets/shader/bayer_8.frag | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\n> index 4ece44ab..7e35ca88 100644\n> --- a/src/qcam/assets/shader/bayer_8.frag\n> +++ b/src/qcam/assets/shader/bayer_8.frag\n> @@ -15,6 +15,9 @@ Copyright (C) 2021, Linaro\n> */\n> \n> //Pixel Shader\n> +#ifdef GL_ES\n> +precision mediump float;\n> +#endif\n> \n> /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n> uniform sampler2D tex_y;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73F4FBE173\n\tfor ;\n\tMon, 27 Jun 2022 15:46:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A791465635;\n\tMon, 27 Jun 2022 17:46:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A11036059B\n\tfor ;\n\tMon, 27 Jun 2022 17:46:51 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17A001C82;\n\tMon, 27 Jun 2022 17:46:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656344812;\n\tbh=VAaqM62JzIVZXSZQb5Z+d3S6/IWCnNQBB34BP2lD0Is=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ho5Qi1gcX+1a+/gJW6iJ0oVWe7AHTTUQl0mRp/fG/7UQucL0cpT7OXeA3TGuNF8gC\n\tfjpLLD/XfnWtVj6GG1NC67QEXsLrBaGxu36ECvYV+vJPIENWEvs0noZpgpNh+1j8nR\n\t/4cU8E4rEGronKaeCfPQoKufa0M94yvnO3DzDrY4kj0TmOO0N6xDg+XjeIXt9zPa/a\n\tdcFdtbvw0pNh0hSAQ5YXFJmfC7WQE3ktWyghrmS88Efx98s5ZsU93V/tO0Xlkl8bPd\n\t96/kzt9LfNSBVswjI4b1wDua9+nYq/SMsBrNlqGTyO9ChZs8NnG9O/p8FoUsua7Zow\n\tVaL5JTN+v4hBA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656344811;\n\tbh=VAaqM62JzIVZXSZQb5Z+d3S6/IWCnNQBB34BP2lD0Is=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U2uInHcYjruOmou13jx+H/4eiqdKhH08NRfRP5/BxxOyAWhUsq6S70fN5AC2CMJB/\n\tljLB3Q7MnVShG7yz/1FFxy4BzZ+uUA6AtkcrJKym2H4ZJ2d3oNrtQXPzx+yjI0TPgI\n\temVcCJ5YkEJS1A2qHKRjcaFgcnUV6KukJekvXGSY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"U2uInHcY\"; dkim-atps=neutral","Date":"Mon, 27 Jun 2022 18:46:32 +0300","To":"Kunal Agarwal ","Message-ID":"","References":"<20220627152405.36654-1-kunalagarwal1072002@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220627152405.36654-1-kunalagarwal1072002@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] qcam: assets: shader:\n\tbayer_8.frag: Add precision","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]