[{"id":23613,"web_url":"https://patchwork.libcamera.org/comment/23613/","msgid":"<20220627161016.rs3r7myglz2qs7w4@uno.localdomain>","date":"2022-06-27T16:10:16","subject":"Re: [libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Daniel,\n\nOn Mon, Jun 27, 2022 at 02:28:06PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> parseFrames() return value was ignored. If there was an error during\n> frame parsing, parsing was not stopped correctly.\n>\n> Signed-off-by: Daniel Semkowicz \n\nReviewed-by: Jacopo Mondi \n\nFYI:\nLaurent has give his RB tag on v2. Patch submitters are expected to\ncollect tags and add them to their next version they send.\n\nThanks\n j\n\n> ---\n> src/cam/capture_script.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/cam/capture_script.cpp b/src/cam/capture_script.cpp\n> index 6278a152..695de37b 100644\n> --- a/src/cam/capture_script.cpp\n> +++ b/src/cam/capture_script.cpp\n> @@ -150,7 +150,9 @@ int CaptureScript::parseScript(FILE *script)\n> \t\tstd::string section = eventScalarValue(event);\n>\n> \t\tif (section == \"frames\") {\n> -\t\t\tparseFrames();\n> +\t\t\tret = parseFrames();\n> +\t\t\tif (ret)\n> +\t\t\t\treturn ret;\n> \t\t} else {\n> \t\t\tstd::cerr << \"Unsupported section '\" << section << \"'\"\n> \t\t\t\t << std::endl;\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01C61BE173\n\tfor ;\n\tMon, 27 Jun 2022 16:10:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 546D965635;\n\tMon, 27 Jun 2022 18:10:21 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 108F06059B\n\tfor ;\n\tMon, 27 Jun 2022 18:10:20 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 05E2A20000B;\n\tMon, 27 Jun 2022 16:10:18 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656346221;\n\tbh=aOD84YjtO4pG7mf1qnH443I7zfrREDaetsLDj6RByl4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wdsMPVBW5tlicPbZAaE4KJI9W/doQAy8i42WN9KVc+RSz/mRjZs61xG5APtELmfs1\n\tZt1Jco6IVe4cKZvpAFNEDycImK9vUSmbla6KunDP4cNgDwFWP4iX8OCA5ZZDel1AiL\n\tsT6guoWQUvPDIhd/UQcyIAEParss/6sU8vmPyBCPPiiUyQWhr2vWE+RglRJdlZwZiD\n\t5kkWc4VcC0urPlxtdaQpVOCd8m+H2wtWxGAYyCuuXHlSwKRfttdw2ei4aXDGGCLl+d\n\tmkEUWFtlyV2SSnFJ3O4jUvwINmvfR3EPa0Dwu80yI1jUoKYz23vwZbp3203MxW5Het\n\t83Sbl1G6f4zBw==","Date":"Mon, 27 Jun 2022 18:10:16 +0200","To":"Daniel Semkowicz ","Message-ID":"<20220627161016.rs3r7myglz2qs7w4@uno.localdomain>","References":"<20220627122806.29586-1-dse@thaumatec.com>\n\t<20220627122806.29586-3-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220627122806.29586-3-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23630,"web_url":"https://patchwork.libcamera.org/comment/23630/","msgid":"","date":"2022-06-28T06:45:02","subject":"Re: [libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"content":"Hi Jacopo,\n\nOn Mon, Jun 27, 2022 at 6:10 PM Jacopo Mondi wrote:\n>\n> Hi Daniel,\n>\n> On Mon, Jun 27, 2022 at 02:28:06PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> > parseFrames() return value was ignored. If there was an error during\n> > frame parsing, parsing was not stopped correctly.\n> >\n> > Signed-off-by: Daniel Semkowicz \n>\n> Reviewed-by: Jacopo Mondi \n>\n> FYI:\n> Laurent has give his RB tag on v2. Patch submitters are expected to\n> collect tags and add them to their next version they send.\n>\n> Thanks\n> j\n\nThank you for the review.\n\nSorry for the mistakes... It is new to me to push changes using mailing\nlist. I have read some instructions about this way of working, but\napparently there are still things that I haven't learned before I came\ninto contact with them in practice.\n\nBest regards\nDaniel\n\n>\n> > ---\n> > src/cam/capture_script.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/cam/capture_script.cpp b/src/cam/capture_script.cpp\n> > index 6278a152..695de37b 100644\n> > --- a/src/cam/capture_script.cpp\n> > +++ b/src/cam/capture_script.cpp\n> > @@ -150,7 +150,9 @@ int CaptureScript::parseScript(FILE *script)\n> > std::string section = eventScalarValue(event);\n> >\n> > if (section == \"frames\") {\n> > - parseFrames();\n> > + ret = parseFrames();\n> > + if (ret)\n> > + return ret;\n> > } else {\n> > std::cerr << \"Unsupported section '\" << section << \"'\"\n> > << std::endl;\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D70A1BE173\n\tfor ;\n\tTue, 28 Jun 2022 06:45:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 573DD61FB1;\n\tTue, 28 Jun 2022 08:45:15 +0200 (CEST)","from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com\n\t[IPv6:2a00:1450:4864:20::22f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E27D061FB1\n\tfor ;\n\tTue, 28 Jun 2022 08:45:13 +0200 (CEST)","by mail-lj1-x22f.google.com with SMTP id u14so320396ljh.2\n\tfor ;\n\tMon, 27 Jun 2022 23:45:13 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656398715;\n\tbh=EFMuOvvAvDrQrwX8xONlZh7MsQLARSxtV0d1N2bB7CM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=A/NBJWouZI8Nw8CIBb2C9pulo6b7zDTBJq6Ym968ncLOaijPURdDRaeUenTEAWK/6\n\tS/PuHtsnx0l2uVVX596/BG8wiHhtBRyu0z/+ROJIAWdxwjF9WzWfhuDswq+Y1Sgrln\n\t6trOOauEXi4y7namyaxXofGAa8kKtDIl4jLs1LdZ1Mgg4nqa9V3pNI4KdeB7r4+j7w\n\tl4ypHu11g5TpgrDCUXy74T2Xmw9Sq5LzXMJ7uTFtmQhwnyz+7tRnBirza6UT2K3p+9\n\t9IEGWD69u2Vz/De6Hsgz35AMW57U95bTAqN7uTrrxshJnllEyNrTs6CKJ8xNyCg66r\n\tgzHecjTmcmm0w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ClalIX/q7+6Cy59Z8GhsoxNmkr1+1zpSy4Ian8fGDtY=;\n\tb=tFHJ6HikY4UO1fcSJ4l2tz3zDO6k+u8q87LKmBCpUFv+Q2vES8czT4tFxJRi3KjJBs\n\t5G5MXcTOIhWGqc3uzU1NiCZfpnbUy67TL4h0jU1RNMPlfeRFJ81QCrSRfreKoqSUFKHa\n\tqHkMjbdrUyjdSUt4Tbs1rYuNL8g+WBgaPisob4esrulP+DuFAiFaI92gLqQVyU9lrhOQ\n\t0GrNIpg9lySo0VwrYmN/sPZ30B9VonbAbCVmIqt2En9y3RUg7HVh6AKKUqVfV5dgHXnb\n\tXZT1wWh6lwR3+WmXGg49s2Ulqjkqtwx1HB4ubAPSaSXjAfR5icht4tvOaadZDTkam1T9\n\tamng=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"tFHJ6Hik\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ClalIX/q7+6Cy59Z8GhsoxNmkr1+1zpSy4Ian8fGDtY=;\n\tb=xt9KWnUBQL8pnUdvRW9iwdekMK8ThPbP6VwyyhkAKtgUxjV8Vnl/bKI2RyBnX2M9zb\n\twqGh4ZrzlGCSAgwcvg0rBcb/SOKcdUBydTvGhHg9DVTczcLm5ZeZqcwyowg3XE1p2wyE\n\tgMB1N8PkTim336kUDE38/9xRHXvqc4C6/zF6c3+ruBuW+uo3LEpboXu24mI+2ctJ927l\n\tuJcRo11HlhX+h4EeyoGWXRzwLNHFmhWMPINyk5SJLkvyDHfXMjR70XPMgaEkKwKkxBxl\n\t706THeyZU4qDWArevCrqn4Fq/3XNAwGNTppu2IdTB1qYhDTKYAW7ZI1+cKwU0iT/3dhr\n\trICg==","X-Gm-Message-State":"AJIora8j/+MClZTvl8qKu2HQHeF8DpyhyvgChYH3k/bBiXHS+6mQF+T7\n\tgwLvZepaSgGSrFE0EhuaL2A3cFhopgBn0gXm4GY/1A==","X-Google-Smtp-Source":"AGRyM1v/9z4D44PpAYQcSqkA2TatPII8yJlhlvrAQAjYKASyOZYMvBq2RFFiItMU4PusnwjmiUNbeF1t2W54B+70w1Y=","X-Received":"by 2002:a2e:95d0:0:b0:25a:7add:cad0 with SMTP id\n\ty16-20020a2e95d0000000b0025a7addcad0mr8603588ljh.283.1656398713230;\n\tMon, 27 Jun 2022 23:45:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20220627122806.29586-1-dse@thaumatec.com>\n\t<20220627122806.29586-3-dse@thaumatec.com>\n\t<20220627161016.rs3r7myglz2qs7w4@uno.localdomain>","In-Reply-To":"<20220627161016.rs3r7myglz2qs7w4@uno.localdomain>","Date":"Tue, 28 Jun 2022 08:45:02 +0200","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24425,"web_url":"https://patchwork.libcamera.org/comment/24425/","msgid":"<20220808103149.GS311202@pyrite.rasen.tech>","date":"2022-08-08T10:31:49","subject":"Re: [libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Daniel,\n\nOn Mon, Jun 27, 2022 at 02:28:06PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> parseFrames() return value was ignored. If there was an error during\n> frame parsing, parsing was not stopped correctly.\n> \n> Signed-off-by: Daniel Semkowicz \n\nReviewed-by: Paul Elder \n\n> ---\n> src/cam/capture_script.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/capture_script.cpp b/src/cam/capture_script.cpp\n> index 6278a152..695de37b 100644\n> --- a/src/cam/capture_script.cpp\n> +++ b/src/cam/capture_script.cpp\n> @@ -150,7 +150,9 @@ int CaptureScript::parseScript(FILE *script)\n> \t\tstd::string section = eventScalarValue(event);\n> \n> \t\tif (section == \"frames\") {\n> -\t\t\tparseFrames();\n> +\t\t\tret = parseFrames();\n> +\t\t\tif (ret)\n> +\t\t\t\treturn ret;\n> \t\t} else {\n> \t\t\tstd::cerr << \"Unsupported section '\" << section << \"'\"\n> \t\t\t\t << std::endl;\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78CFFBE173\n\tfor ;\n\tMon, 8 Aug 2022 10:31:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 014296332B;\n\tMon, 8 Aug 2022 12:31:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9851663315\n\tfor ;\n\tMon, 8 Aug 2022 12:31:56 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E8D7481;\n\tMon, 8 Aug 2022 12:31:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659954718;\n\tbh=vSU4soPVSzDkfnBJJbH/BGjG5ZD2KWJZzqYzfcDc1aM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=h88sGmRXV1qfhWEP7BX1kJSZ4Lr9HKB4WtZByk/Q8Alp6PNtXoU73TY2H/P8+Dkac\n\tcJ+HfLX6INpUi1hwsQBhXoasEvgHRQw5sLUWwykxsps8yqBEC4l1/EtvPsIe1XKYdt\n\t2WwmODJIthh1s7wOBB4U6rXzsFkPYzdtekrQwZ8CIGX3xEU2dSxkaaESETaMO1+Fyx\n\t22K/3WYKiKCD76o9MB+fUyYZRmcdzCL9YuN/RImx1C8NvvzHv01dYVPJM2AX1r+/+h\n\twH3z/nqVUtjmYon15aSYSZ3nFtp9+6LT7e93kTHUNsu8vtActp+lQDNOwN5j7ZZzp1\n\tNG8Hb5DNDSY7A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659954716;\n\tbh=vSU4soPVSzDkfnBJJbH/BGjG5ZD2KWJZzqYzfcDc1aM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SJb/lPgTA90h+isDKy70X0KBsDen0TVP9v/9y7f6sYhp3bLQYOmP70z1dlwc0G4u4\n\thp8rJtNaBddOsLEaCs+LaHPcuGpp1kFkKJPH47i1uIkbvifrGBMeEhRqF7Ko5nXG+s\n\tkT/QZjh6SDmP6UA1egYE619i35swiFc3SPKoftXY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SJb/lPgT\"; dkim-atps=neutral","Date":"Mon, 8 Aug 2022 19:31:49 +0900","To":"Daniel Semkowicz ","Message-ID":"<20220808103149.GS311202@pyrite.rasen.tech>","References":"<20220627122806.29586-1-dse@thaumatec.com>\n\t<20220627122806.29586-3-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220627122806.29586-3-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]