[{"id":23590,"web_url":"https://patchwork.libcamera.org/comment/23590/","msgid":"<20220627081214.wgloctf7r22cqvcd@uno.localdomain>","date":"2022-06-27T08:12:14","subject":"Re: [libcamera-devel] [PATCH v2] README: Add some extra optional\n\tdependancies for cam sinks","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Sat, Jun 25, 2022 at 02:15:53AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> From: Eric Curtin \n>\n> KMS sink requires some DRM libraries, SDL sink requires some SDL\n> libraries.\n>\n> Suggested-by: Pavel Machek \n> Signed-off-by: Eric Curtin \n> Signed-off-by: Laurent Pinchart \n> ---\n> A v2 just to make sure we're on the same page.\n>\n> README.rst | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n>\n> diff --git a/README.rst b/README.rst\n> index 05ebcec4c4c1..b9e72d81b90c 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -87,7 +87,13 @@ for gstreamer: [optional]\n> libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n>\n> for cam: [optional]\n> - libevent-dev\n> + libevent-dev is required to support cam, however the following\n> + optional dependencies bring more functionality to the cam test\n\nfunctionalty or functionalities ?\nThe dictionary I've found says it's both countable and uncountable o_0\n\n> + tool:\n> +\n> + - libdrm-dev: Enables the KMS sink\n> + - libsdl2-dev: Enables the SDL sink\n> + - libsdl2-image-dev: Supports MJPEG on the SDL sink\n\nThe content looks good\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> for qcam: [optional]\n> qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 080E2BE173\n\tfor ;\n\tMon, 27 Jun 2022 08:12:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21C8365635;\n\tMon, 27 Jun 2022 10:12:18 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0E1860412\n\tfor ;\n\tMon, 27 Jun 2022 10:12:16 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5B65E60013;\n\tMon, 27 Jun 2022 08:12:16 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656317538;\n\tbh=RlMgmxeOmy5McvJn6Z05TIL1HqTETUZMBb+Dhj6L6EA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3guHSGWLbQ3L3iZq8GyosktJJmt0W87IK7lqRdEML7dLgfPokSy8t8vfskgl4zl5x\n\tjtk/7/AKwMlArXKGd5FDCgHJG1cQ8uAOMVuyH6+pgs1l56nMm2Zc2+9/8l+K1ez0bA\n\to3X6+hWVuHQbGqWxxUcsW7N/sDYQhX/FOGz5DHci9Rs2PMBOf2UdTsq4UP1uRG+rWb\n\tt7ImtLHQBaY4LTgYRTUwx+xwov2oY32Uu7MOFuRv/MrVCtnJLYkufnstXVtkOQkxvy\n\t7AYmsx/ti7q9PJCh0cy8TLJ49RFXk/1GrCn0ImSeF8TDW4iSu8g6Cayfg8WhtqH2BH\n\tGuD355C1k1pPA==","Date":"Mon, 27 Jun 2022 10:12:14 +0200","To":"Laurent Pinchart ","Message-ID":"<20220627081214.wgloctf7r22cqvcd@uno.localdomain>","References":"<165607485532.1149771.12526676719332647089@Monstersaurus>\n\t<20220624231553.2137-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220624231553.2137-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] README: Add some extra optional\n\tdependancies for cam sinks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23592,"web_url":"https://patchwork.libcamera.org/comment/23592/","msgid":"","date":"2022-06-27T08:20:43","subject":"Re: [libcamera-devel] [PATCH v2] README: Add some extra optional\n\tdependancies for cam sinks","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jun 27, 2022 at 10:12:14AM +0200, Jacopo Mondi wrote:\n> Hi Laurent\n> \n> On Sat, Jun 25, 2022 at 02:15:53AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > From: Eric Curtin \n> >\n> > KMS sink requires some DRM libraries, SDL sink requires some SDL\n> > libraries.\n> >\n> > Suggested-by: Pavel Machek \n> > Signed-off-by: Eric Curtin \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > A v2 just to make sure we're on the same page.\n> >\n> > README.rst | 8 +++++++-\n> > 1 file changed, 7 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/README.rst b/README.rst\n> > index 05ebcec4c4c1..b9e72d81b90c 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -87,7 +87,13 @@ for gstreamer: [optional]\n> > libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> >\n> > for cam: [optional]\n> > - libevent-dev\n> > + libevent-dev is required to support cam, however the following\n> > + optional dependencies bring more functionality to the cam test\n> \n> functionalty or functionalities ?\n> The dictionary I've found says it's both countable and uncountable o_0\n\nShould I use both then ? :-)\n\nAccording to https://en.wiktionary.org/wiki/functionality, it's\nuncountable in the meaning we use here.\n\n> > + tool:\n> > +\n> > + - libdrm-dev: Enables the KMS sink\n> > + - libsdl2-dev: Enables the SDL sink\n> > + - libsdl2-image-dev: Supports MJPEG on the SDL sink\n> \n> The content looks good\n> Reviewed-by: Jacopo Mondi \n> \n> >\n> > for qcam: [optional]\n> > qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33C8DBD808\n\tfor ;\n\tMon, 27 Jun 2022 08:21:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8449865635;\n\tMon, 27 Jun 2022 10:21:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E6DF60412\n\tfor ;\n\tMon, 27 Jun 2022 10:21:02 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 805CB47C;\n\tMon, 27 Jun 2022 10:21:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656318063;\n\tbh=yqPhcpoH6Yk5EzsM/qywtq/62QgSfDSn6WfST2Il2XE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f25bfeAy78+JhZM3mDnLJV5CbSgQ4vWmxfSBuK34wmIRX1VVIV7AouFpUCzIYYZ3J\n\tkUZPyLimX/ObUyj6KlHYX3+eU0TCFSHZDbJfA+fymoL1wPxI8L4znIxS/KjLTw9XXF\n\tlGmDvy4EMfVKk/fdINt6+8k5f3tiVXqbTFGForxfwE14KNPLJn9T9Q6CAbW1EuCmB/\n\toteQGGv/3CoLOzfitl+ogpCy3TyNq4IOU5pklnFKBWIK+MuSin5dP+4LeQjS4EM1Wv\n\tUeWvkQ3qhIapxbcQp0JVUkAc17K/SjqhE+M378GYLKh40s5Q2CXwp+R7EcLNw+o+0A\n\txJHe+pF0MAtgg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656318061;\n\tbh=yqPhcpoH6Yk5EzsM/qywtq/62QgSfDSn6WfST2Il2XE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qkPCUaVMH7AIwPbRJATWUBjhCIlQwoaNp0f8i0hSsYzFGuqdxFbeUzC2SzbRNVqAE\n\ttFSMAbzIgoXsF6lW6W/4Z21hBAESfmEWRAZSU1HmjO1WbZP3OcRpkB5ncrZ+w3jASM\n\tI3N+Stfgo2yoI74t9ULyi+Hm03FARMAg3jxqrbJQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qkPCUaVM\"; dkim-atps=neutral","Date":"Mon, 27 Jun 2022 11:20:43 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<165607485532.1149771.12526676719332647089@Monstersaurus>\n\t<20220624231553.2137-1-laurent.pinchart@ideasonboard.com>\n\t<20220627081214.wgloctf7r22cqvcd@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220627081214.wgloctf7r22cqvcd@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2] README: Add some extra optional\n\tdependancies for cam sinks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23594,"web_url":"https://patchwork.libcamera.org/comment/23594/","msgid":"","date":"2022-06-27T09:29:06","subject":"Re: [libcamera-devel] [PATCH v2] README: Add some extra optional\n\tdependancies for cam sinks","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Mon, 27 Jun 2022 at 09:21, Laurent Pinchart via libcamera-devel\n wrote:\n>\n> On Mon, Jun 27, 2022 at 10:12:14AM +0200, Jacopo Mondi wrote:\n> > Hi Laurent\n> >\n> > On Sat, Jun 25, 2022 at 02:15:53AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > From: Eric Curtin \n> > >\n> > > KMS sink requires some DRM libraries, SDL sink requires some SDL\n> > > libraries.\n> > >\n> > > Suggested-by: Pavel Machek \n> > > Signed-off-by: Eric Curtin \n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > A v2 just to make sure we're on the same page.\n> > >\n> > > README.rst | 8 +++++++-\n> > > 1 file changed, 7 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/README.rst b/README.rst\n> > > index 05ebcec4c4c1..b9e72d81b90c 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -87,7 +87,13 @@ for gstreamer: [optional]\n> > > libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > >\n> > > for cam: [optional]\n> > > - libevent-dev\n> > > + libevent-dev is required to support cam, however the following\n> > > + optional dependencies bring more functionality to the cam test\n> >\n> > functionalty or functionalities ?\n> > The dictionary I've found says it's both countable and uncountable o_0\n>\n> Should I use both then ? :-)\n>\n> According to https://en.wiktionary.org/wiki/functionality, it's\n> uncountable in the meaning we use here.\n\nBoth are correct. English is funny like this, you can use fish and\nfishes to mean plural fish (although it would be weird to see fishes\nin any book published after 1400 AD, lol). Both functionalty and\nfunctionalities sound equally correct to me.\n\nv2 looks good to me.\n\n\n>\n> > > + tool:\n> > > +\n> > > + - libdrm-dev: Enables the KMS sink\n> > > + - libsdl2-dev: Enables the SDL sink\n> > > + - libsdl2-image-dev: Supports MJPEG on the SDL sink\n> >\n> > The content looks good\n> > Reviewed-by: Jacopo Mondi \n> >\n> > >\n> > > for qcam: [optional]\n> > > qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B126BD808\n\tfor ;\n\tMon, 27 Jun 2022 09:29:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 971A765633;\n\tMon, 27 Jun 2022 11:29:28 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1642560412\n\tfor ;\n\tMon, 27 Jun 2022 11:29:25 +0200 (CEST)","from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n\t[209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-593-dg7UTaYoPhifhZTS6QsEqw-1; Mon, 27 Jun 2022 05:29:23 -0400","by mail-qv1-f72.google.com with SMTP id\n\ts11-20020a0562140cab00b0046e7d2b24b3so8827937qvs.16\n\tfor ;\n\tMon, 27 Jun 2022 02:29:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656322168;\n\tbh=cuC4bs7IowNza+ub2ILEpYd5cy6grFc5d3xvP3g01kU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gwy+5Wk6TP3LjlG8IJqzyZIM6FTCx+7sfL7wDO0oCjM+OtZeSh3etjgkjA+V/L1+w\n\tBKyZFH+DSy7qEDTlOxe1e8eIOQtOOrL2FChzGVfp8NbS1N77bxFwNb7PKhKqYxmLpg\n\tYmcIG/6fxBAmVmd0XtxAl3MkzSd2Bi4lhUBCiCQSsBTj9JW4sBN9kl9wOh2lq6jyfM\n\tLYWq69CALJkyznbNHwgk8V13LmeFQOnga7mkogz4vzp4XUk4k4WCOD8WV3YZQlRS1W\n\trIkU57YfolUJA6vEfy5hCPh0Bt5eLkGUAaZ5V5LudVj95W9koxot+2u6GjbntaYbsA\n\tDC/ycMKsV5RHg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1656322164;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=RDsykWOQHUQiHPUntv6/yHtlL2zPIJrpvRRyCLr9ew0=;\n\tb=Ng+TjoLUDQ/EM1aTlAVX2tBTZ9g/l5I7koNeoU1tbM19hMZcHmVY58dbm9lYNKMOOYHVfB\n\tlbnKnpuS0SXsTGayXZ6ti0jOdXlTIeFlWhbD9mKzASBiLd9uj6ioWuEX5wmsQ0W7EAPiBD\n\tiqv8KTSMy4gY/JeNU5rmmhYxHD0OKJs="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"Ng+TjoLU\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com"],"X-MC-Unique":"dg7UTaYoPhifhZTS6QsEqw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RDsykWOQHUQiHPUntv6/yHtlL2zPIJrpvRRyCLr9ew0=;\n\tb=TUlsVAAqDA/6NRQ8pALiC3GxKA2sfbGj6YrpQnAKHEs/LJ6OA5P2n+eYAQ/fz27iaG\n\t4vu4/065jmCpoJYjuDXfPQFhYBwHYsifizXi/bgEScnk2qbc1tlvcdVadUWAm/7BAzDU\n\tsouNhOGWdVJwK6sdoV4OIZJ/llj07rgkJ9pqD09Yf84gAk3rjuqTNKaI3i58DdNo+7fi\n\tQQGD3gD03Fx1UgtWtTdHi+UvekE+G+avUNx5uaqAdAPQhUphuKhIRwlxAfJXHWsQl/Mq\n\tgLWyf2lOR0brHCE29exeEK+dqda+hcEkZ5uo5sIg2lW6Nvm4ecyHvmscYry3hd7KElKo\n\tNuKA==","X-Gm-Message-State":"AJIora/cQef+Sns8d+bJ/HgrVdepaqG7tgRKMHRVpLCkr7Nslhe7sE1R\n\thEx6RQVnWoOtdCBcMR6Epr5n0Pg9LrCIvr4S+f3KRMFAvSop8Ae0yHLPLJNqWDmkinSzfmgKRZX\n\tgm8l3jFq5BAwvNocQN1YYeLC67swSQVrUDgoYJpXKNCfsR0JxOw==","X-Received":["by 2002:a05:622a:1883:b0:305:1ce4:59d2 with SMTP id\n\tv3-20020a05622a188300b003051ce459d2mr8247862qtc.638.1656322162315; \n\tMon, 27 Jun 2022 02:29:22 -0700 (PDT)","by 2002:a05:622a:1883:b0:305:1ce4:59d2 with SMTP id\n\tv3-20020a05622a188300b003051ce459d2mr8247850qtc.638.1656322162041;\n\tMon, 27 Jun 2022 02:29:22 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1tlO/iiaFmGoZFE0mooulbnyVTvdlx5n7wuk9uX+ktZxEnKx53hMIUPL4jKk0VdFJWVMZH05zf2AU49meoptF4=","MIME-Version":"1.0","References":"<165607485532.1149771.12526676719332647089@Monstersaurus>\n\t<20220624231553.2137-1-laurent.pinchart@ideasonboard.com>\n\t<20220627081214.wgloctf7r22cqvcd@uno.localdomain>\n\t","In-Reply-To":"","Date":"Mon, 27 Jun 2022 10:29:06 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2] README: Add some extra optional\n\tdependancies for cam sinks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]