[{"id":23572,"web_url":"https://patchwork.libcamera.org/comment/23572/","msgid":"<165607395926.1149771.16404230775973122460@Monstersaurus>","date":"2022-06-24T12:32:39","subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-06-24 08:35:26)\n> Add an optional sensor_temperature field to the DeviceStatus structure. If a\n> temperature measurement is available for a frame, the value is returned out\n> through the SensorTemperature control in the Request metadata.\n> \n> Additionally, provide the sensor temperature value from the std::ostream &operator<<\n> overload.\n> \n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/cam_helper.cpp | 8 +++++---\n> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> src/ipa/raspberrypi/controller/device_status.h | 3 +++\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> 4 files changed, 13 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/raspberrypi/cam_helper.cpp\n> index 74179399e86a..3f81d4187d4d 100644\n> --- a/src/ipa/raspberrypi/cam_helper.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper.cpp\n> @@ -185,9 +185,9 @@ void CamHelper::parseEmbeddedData(Span buffer,\n> metadata.Merge(parsedMetadata);\n> \n> /*\n> - * Overwrite the exposure/gain values in the existing DeviceStatus with\n> - * values from the parsed embedded buffer. Fetch it first in case any\n> - * other fields were set meaningfully.\n> + * Overwrite the exposure/gain, frame length and sensor temperature values\n> + * in the existing DeviceStatus with values from the parsed embedded buffer.\n> + * Fetch it first in case any other fields were set meaningfully.\n> */\n> DeviceStatus deviceStatus, parsedDeviceStatus;\n> if (metadata.Get(\"device.status\", deviceStatus) ||\n> @@ -199,6 +199,8 @@ void CamHelper::parseEmbeddedData(Span buffer,\n> deviceStatus.shutter_speed = parsedDeviceStatus.shutter_speed;\n> deviceStatus.analogue_gain = parsedDeviceStatus.analogue_gain;\n> deviceStatus.frame_length = parsedDeviceStatus.frame_length;\n> + if (parsedDeviceStatus.sensor_temperature)\n> + deviceStatus.sensor_temperature = parsedDeviceStatus.sensor_temperature;\n> \n> LOG(IPARPI, Debug) << \"Metadata updated - \" << deviceStatus;\n> \n> diff --git a/src/ipa/raspberrypi/controller/device_status.cpp b/src/ipa/raspberrypi/controller/device_status.cpp\n> index f052ea8b7bed..05897fc15b50 100644\n> --- a/src/ipa/raspberrypi/controller/device_status.cpp\n> +++ b/src/ipa/raspberrypi/controller/device_status.cpp\n> @@ -17,5 +17,8 @@ std::ostream &operator<<(std::ostream &out, const DeviceStatus &d)\n> << \" Lens: \" << d.lens_position\n> << \" Flash: \" << d.flash_intensity;\n> \n> + if (d.sensor_temperature)\n> + out << \" Temperature: \" << *d.sensor_temperature;\n> +\n> return out;\n> }\n> diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\n> index c4a5d9c8e8c7..eca3bf4b042e 100644\n> --- a/src/ipa/raspberrypi/controller/device_status.h\n> +++ b/src/ipa/raspberrypi/controller/device_status.h\n> @@ -7,6 +7,7 @@\n> #pragma once\n> \n> #include \n> +#include \n> \n> #include \n> \n> @@ -36,4 +37,6 @@ struct DeviceStatus {\n> double aperture;\n> /* proportional to brightness with 0 = no flash, 1 = maximum flash */\n> double flash_intensity;\n> + /* Sensor reported temperature value (in degrees) */\n> + std::optional sensor_temperature;\n> };\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 3b126bb5175e..cb0025a17aff 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -491,6 +491,8 @@ void IPARPi::reportMetadata()\n> libcameraMetadata_.set(controls::AnalogueGain, deviceStatus->analogue_gain);\n> libcameraMetadata_.set(controls::FrameDuration,\n> helper_->Exposure(deviceStatus->frame_length).get());\n> + if (deviceStatus->sensor_temperature)\n> + libcameraMetadata_.set(controls::SensorTemperature, *deviceStatus->sensor_temperature);\n> }\n> \n> AgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 883CBBE173\n\tfor ;\n\tFri, 24 Jun 2022 12:32:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1662600EC;\n\tFri, 24 Jun 2022 14:32:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 576F8600EC\n\tfor ;\n\tFri, 24 Jun 2022 14:32:42 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE86347C;\n\tFri, 24 Jun 2022 14:32:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656073964;\n\tbh=OlD1ACJRxrZj0WYJpyNLWRoF7jjqY9CqifdlW6XEzwc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=O4tymXWDahYKbNAoMSQAYRKDUYQZIjLwD+Qh1eiaxvy3w3MiOdytQ7fSvX4jUc3kK\n\txJRGHFC2r4ANn1VF1vkUtVeTWIX2ZtzRGUCAHC2g2JzI3PsciyXOMPQflskb7wexb7\n\tDcFFSMwB5KSFWp46/1MqeVjnpXFOUWOST8TYBz0ABW4GNGF/3xM1uTk4EBX3+ZtdPz\n\t7jLfD24i9SkO85QfHFrtVCGquj4EJWARB+kAcM9zElnli7MX/JSeHlHLug0DMgeh6r\n\tOowkbD8ISQiHlw9mN9i/d3K3fkrhs3h6XHIGoF4PSDT8PSUribn+U3z1ommG1lAb7K\n\t+/nwWoWtbYeKg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656073962;\n\tbh=OlD1ACJRxrZj0WYJpyNLWRoF7jjqY9CqifdlW6XEzwc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=TynpkK7E2k924ex0BDORY9vBqLAF842ia1kFDfmTUsC31Y6CGcehs/ssrsiyKx97F\n\tMXQw8t+IWRPlQhzyGCqxhrDidc0YfHosfNPPkAaEoQ6KbwBJkEOk7L4ptaCosTnlx4\n\ts63ggvov91VC1n8bZUb5xWbbWUp6axYwFQQlhyS4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TynpkK7E\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220624073528.26670-3-naush@raspberrypi.com>","References":"<20220624073528.26670-1-naush@raspberrypi.com>\n\t<20220624073528.26670-3-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Jun 2022 13:32:39 +0100","Message-ID":"<165607395926.1149771.16404230775973122460@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23635,"web_url":"https://patchwork.libcamera.org/comment/23635/","msgid":"","date":"2022-06-28T08:28:12","subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch!\n\nAll looks fine to me...\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\nOn Fri, 24 Jun 2022 at 13:32, Kieran Bingham via libcamera-devel\n wrote:\n>\n> Quoting Naushir Patuck via libcamera-devel (2022-06-24 08:35:26)\n> > Add an optional sensor_temperature field to the DeviceStatus structure. If a\n> > temperature measurement is available for a frame, the value is returned out\n> > through the SensorTemperature control in the Request metadata.\n> >\n> > Additionally, provide the sensor temperature value from the std::ostream &operator<<\n> > overload.\n> >\n> > Signed-off-by: Naushir Patuck \n>\n>\n> Reviewed-by: Kieran Bingham \n>\n> > ---\n> > src/ipa/raspberrypi/cam_helper.cpp | 8 +++++---\n> > src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> > src/ipa/raspberrypi/controller/device_status.h | 3 +++\n> > src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> > 4 files changed, 13 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/raspberrypi/cam_helper.cpp\n> > index 74179399e86a..3f81d4187d4d 100644\n> > --- a/src/ipa/raspberrypi/cam_helper.cpp\n> > +++ b/src/ipa/raspberrypi/cam_helper.cpp\n> > @@ -185,9 +185,9 @@ void CamHelper::parseEmbeddedData(Span buffer,\n> > metadata.Merge(parsedMetadata);\n> >\n> > /*\n> > - * Overwrite the exposure/gain values in the existing DeviceStatus with\n> > - * values from the parsed embedded buffer. Fetch it first in case any\n> > - * other fields were set meaningfully.\n> > + * Overwrite the exposure/gain, frame length and sensor temperature values\n> > + * in the existing DeviceStatus with values from the parsed embedded buffer.\n> > + * Fetch it first in case any other fields were set meaningfully.\n> > */\n> > DeviceStatus deviceStatus, parsedDeviceStatus;\n> > if (metadata.Get(\"device.status\", deviceStatus) ||\n> > @@ -199,6 +199,8 @@ void CamHelper::parseEmbeddedData(Span buffer,\n> > deviceStatus.shutter_speed = parsedDeviceStatus.shutter_speed;\n> > deviceStatus.analogue_gain = parsedDeviceStatus.analogue_gain;\n> > deviceStatus.frame_length = parsedDeviceStatus.frame_length;\n> > + if (parsedDeviceStatus.sensor_temperature)\n> > + deviceStatus.sensor_temperature = parsedDeviceStatus.sensor_temperature;\n> >\n> > LOG(IPARPI, Debug) << \"Metadata updated - \" << deviceStatus;\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/device_status.cpp b/src/ipa/raspberrypi/controller/device_status.cpp\n> > index f052ea8b7bed..05897fc15b50 100644\n> > --- a/src/ipa/raspberrypi/controller/device_status.cpp\n> > +++ b/src/ipa/raspberrypi/controller/device_status.cpp\n> > @@ -17,5 +17,8 @@ std::ostream &operator<<(std::ostream &out, const DeviceStatus &d)\n> > << \" Lens: \" << d.lens_position\n> > << \" Flash: \" << d.flash_intensity;\n> >\n> > + if (d.sensor_temperature)\n> > + out << \" Temperature: \" << *d.sensor_temperature;\n> > +\n> > return out;\n> > }\n> > diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\n> > index c4a5d9c8e8c7..eca3bf4b042e 100644\n> > --- a/src/ipa/raspberrypi/controller/device_status.h\n> > +++ b/src/ipa/raspberrypi/controller/device_status.h\n> > @@ -7,6 +7,7 @@\n> > #pragma once\n> >\n> > #include \n> > +#include \n> >\n> > #include \n> >\n> > @@ -36,4 +37,6 @@ struct DeviceStatus {\n> > double aperture;\n> > /* proportional to brightness with 0 = no flash, 1 = maximum flash */\n> > double flash_intensity;\n> > + /* Sensor reported temperature value (in degrees) */\n> > + std::optional sensor_temperature;\n> > };\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 3b126bb5175e..cb0025a17aff 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -491,6 +491,8 @@ void IPARPi::reportMetadata()\n> > libcameraMetadata_.set(controls::AnalogueGain, deviceStatus->analogue_gain);\n> > libcameraMetadata_.set(controls::FrameDuration,\n> > helper_->Exposure(deviceStatus->frame_length).get());\n> > + if (deviceStatus->sensor_temperature)\n> > + libcameraMetadata_.set(controls::SensorTemperature, *deviceStatus->sensor_temperature);\n> > }\n> >\n> > AgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n> > --\n> > 2.25.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F178DBD808\n\tfor ;\n\tTue, 28 Jun 2022 08:28:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5781165635;\n\tTue, 28 Jun 2022 10:28:25 +0200 (CEST)","from mail-ed1-x529.google.com (mail-ed1-x529.google.com\n\t[IPv6:2a00:1450:4864:20::529])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25BA16559A\n\tfor ;\n\tTue, 28 Jun 2022 10:28:23 +0200 (CEST)","by mail-ed1-x529.google.com with SMTP id z7so16412134edm.13\n\tfor ;\n\tTue, 28 Jun 2022 01:28:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656404905;\n\tbh=b9G3com9M8jkyIZwtaO3G7OgvN7nrmqScaFvkA5Gtyw=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=B7++Eh011YB3e0pO5YfWKEDb3prV1nHcJf+Ua++ea0ew/9uw6V195eDHXe+hhKVQK\n\tTeeJmevduXOOkGXUA2uu7A9enFHoFvwizmtOCAgFZt17iJ7pmCse4Mceyou5n/0htS\n\tRs+TQWLGcjPtN5zdpaH9D0d2Vg8Mbxn3jkHhOunAcQM7mh0nwrA6LCvpd2ER3+ETEs\n\tm4ObLjnoWDBVxv18fIr95zlO4357fqJgf8eIM26MNZSntOZyio5EWe7ND57LqzQobu\n\tEKOabZOBnB7WfVRimAWtXKzra+NOrkSspqZtpdr0OUDXErLNI5J3tTRjvKIh5DKHzF\n\tDMv4fCTy5D2Ig==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Y3dFs+cEXO2k0UPGY+uAft8AgRpTscmWCcuXtMwikDw=;\n\tb=Wo9BQz8QrqX7xwvWxsGPhZFsJb/BvMxlV5mgW2njMcteEVEzKQ887qCUTXxa4la6kD\n\t8H7yax+zuTrhAxWT7WVMOUSg78YnCS3BGpKUsy66GxlrrOD9/o+uF6e5bJbHRpAUC1E9\n\tBrnKoimd2ogarglvqRciUfCJLjd4dwnUPFCE5k2KQ9ZzcrJx6+TJRnJoUOLXrU3t466g\n\th+Lk3HM2MGQvfv3R6nyL1WyFevUrwkUUIGKhL4a5OunF7U+7tBCK99eprrMyBDWFfBpn\n\t8oLrGPrqqoVmxxRqM/H5lwMNfDrdc7ugQCvCL76T0uOm98D2yFjmgbUwuVeE6ilz3xun\n\tI4cQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Wo9BQz8Q\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Y3dFs+cEXO2k0UPGY+uAft8AgRpTscmWCcuXtMwikDw=;\n\tb=f0bVoVKEEuirGRGcB2nah2qKi4+ztAbuviXioq1o5QAq1qY6yOORo26WL/E7LQ4Hu1\n\tngZnSLWTfH2trVUMlX+8s5nzhhe2LT2ksMLoBd8gJx4P2ejEIesGGNlzzWMN3/dptQFW\n\tHqXB8bNHILGbcL1Z+C1YXQR8Oxbkt6N3BAnHPewLRtOBepOAOX8XiU5GKmAcLBS/FAfD\n\t0Zy/63g7tuhc/bPOdxWTi422G0fccUGpM871Cdv/oruNtphOny3eHlBoD5XpmENA42kN\n\tswddFi4Vse/om3lwzE4YitVjtDwTNuMcvyAx3R7SIU1FguTxQC8i3j/aeExanNRUDzNl\n\t2jOQ==","X-Gm-Message-State":"AJIora8LVRG8ncqeW5zAI8Yqg2kDXX7j+lIJ+9wwu4k23JxzZ7ZC8fNK\n\tEVVis+scnDS3+OhFh2EJpS7ISv3mfdTn4z6gEw1aPA==","X-Google-Smtp-Source":"AGRyM1vJxtVIcq8DckvFFX8IaUVGz7trtcX6n8bB1UWWSxWTvX4VJKADFg4yXaLPD68JPt8YpXHspg1QALzTuJFJUd8=","X-Received":"by 2002:a05:6402:5109:b0:437:6e67:6fa5 with SMTP id\n\tm9-20020a056402510900b004376e676fa5mr20597815edd.149.1656404902702;\n\tTue, 28 Jun 2022 01:28:22 -0700 (PDT)","MIME-Version":"1.0","References":"<20220624073528.26670-1-naush@raspberrypi.com>\n\t<20220624073528.26670-3-naush@raspberrypi.com>\n\t<165607395926.1149771.16404230775973122460@Monstersaurus>","In-Reply-To":"<165607395926.1149771.16404230775973122460@Monstersaurus>","Date":"Tue, 28 Jun 2022 09:28:12 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]