[{"id":23634,"web_url":"https://patchwork.libcamera.org/comment/23634/","msgid":"","date":"2022-06-28T08:25:42","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: controls: Add\n\tSensorTemperature control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch!\n\nOn Fri, 24 Jun 2022 at 08:35, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Add a SensorTemperature control to return the temperature of the camera sensor\n> in Celsius. This control will only be present in the Request metadata if a\n> thermal sensor is available to the camera sensor.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Kieran Bingham \n> ---\n> src/libcamera/control_ids.yaml | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index cd1d4512bf2e..ecab3ae97260 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -367,6 +367,16 @@ controls:\n>\n> size: [2]\n>\n> + - SensorTemperature:\n> + type: float\n> + description: |\n> + Temperature measure from the camera sensor in Celsius. This is typically\n> + obtained by a thermal sensor present on-die or in the camera module. The\n> + range of reported temperatures is device dependent.\n> +\n> + The SensorTemperature control will only be returned in metadata if a\n> + themal sensor is present.\n> +\n\nLooks good to me. I suppose we could define a device independent range\nstarting at absolute zero, but it's probably not worth the trouble!\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> - SensorTimestamp:\n> type: int64_t\n> description: |\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77E7ABD808\n\tfor ;\n\tTue, 28 Jun 2022 08:25:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E13665635;\n\tTue, 28 Jun 2022 10:25:55 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 158BD6559A\n\tfor ;\n\tTue, 28 Jun 2022 10:25:54 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id ej4so16443590edb.7\n\tfor ;\n\tTue, 28 Jun 2022 01:25:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656404755;\n\tbh=dnxS5RYjhR54jy1zEQNedsuuzoUOR/yiuAQAR+SL5pQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=K8ncVG9uce7cz7ssI/9gFl5Z1+vvEsO0R2h1w1LYeeb4jjW2mQ1tfJdeSBqmNez/s\n\tluIIhpiWpvejywzWvi+Nu6/+3gjfyJXg04B09JtCJuiedF79l7hfwf5lJ3gKgoyFEr\n\tXgRLwdHLzioOA5uSmNaX13C9KtPU+zmPkIawdJwd09njzRvlT9EgWrowBZAl7aLLx6\n\tnKPddXyDnIfrPbxWQ+3N4SlPdTToKd6iNd+DaLTWDFQiEnDwZ2Ir40+JN0Xwxq0tI0\n\tJK0VOkUDZxhSuqrFTDgBcyPuYK8k699+uUFt/CMHD1K6ZIrOWiq9H0YEUI4iHjMHyQ\n\t5gQXtenPHE1fA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=M2VknNtdr2q3zyi9DCu0zu98j+acbRlt9GPCN6loMao=;\n\tb=Ia18QCamzEZMurJe4elyt4/SN9dIKXXixfO70D1wgyRF7JLoyRqq+r0p2hHpt8geew\n\tn9qtVStxBp6UMhe+0FfyR8MDmHCX69TceSREPnGXGGr75Dy2uWM5lfS+8yVeeaIGqf1S\n\tTCeZxoPs/+A6v62ZvUoSvUx1b23H0mQpolarJMA2CP/OUCECf/ALymHzLwGIsAfyglfj\n\t2LFcEloEDTh2W+jok07rIV6l/79mDQaW1ZYgoTFZxr2vo00C3FVDBGJWTECLlU+mIJnn\n\tYurJPanN7cQoNZuiItW0G9tJqty0HH+IvXfZpfj3b/dE5a+9c0ALlbL34usa0ZBIeHjM\n\toB4Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Ia18QCam\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=M2VknNtdr2q3zyi9DCu0zu98j+acbRlt9GPCN6loMao=;\n\tb=4+fr/HivMZjVW4RTK0uwQ1m0SzXwMriyJMEqof2yMtog7dEt7ZP8Jq3oQ8QpQpF6eT\n\tHuN/P3Ph/RxlFu8kgDjzZUSz6SGSJK+LPiVdzjync8kXRf8HlFZ1ecGqnJWZFytsr+CS\n\tE8Li5fi6FBGcKf4/LzjVN77yChJZNiZZ1CnXloYoUSjDncXg5BVUkwRqOLVTW6YoQBcD\n\t9ue/XKBqwPLjC3Oe+USxQdqPFyPB7pZn1cVjO1nH5ZlOBK0wJqtEOC8dIHTob6qvalq/\n\tNN0orEFijggf7FzZdtJDRiOlk2zxrn3YkRZtXtTibnAUkkOhmln879mlcZ5HQ0nuuOy3\n\t0xcQ==","X-Gm-Message-State":"AJIora9+cvKTHgSzIUBx4B9IAnAHjrrQghdJyjLsvLkt3/OVnCcSluVU\n\tNesEFcYV0XWTqiRRO6Ey+Dom3O1ZqlGR1OpsAUNjGdA2OV/qLQ==","X-Google-Smtp-Source":"AGRyM1ux6z1pUD4rH0L+DTAmnFaRB4cYLMiSrolyx+aNrqAAsLFJrKMZVAWzLMCVkqi0ro3ddOTFQCsK3gy46CSIMn0=","X-Received":"by 2002:a05:6402:22a1:b0:437:78c2:d02b with SMTP id\n\tcx1-20020a05640222a100b0043778c2d02bmr17740423edb.64.1656404753565;\n\tTue, 28 Jun 2022 01:25:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20220624073528.26670-1-naush@raspberrypi.com>\n\t<20220624073528.26670-2-naush@raspberrypi.com>","In-Reply-To":"<20220624073528.26670-2-naush@raspberrypi.com>","Date":"Tue, 28 Jun 2022 09:25:42 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: controls: Add\n\tSensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]