[{"id":23561,"web_url":"https://patchwork.libcamera.org/comment/23561/","msgid":"<20220624073226.GI3309559@pyrite.rasen.tech>","date":"2022-06-24T07:32:26","subject":"Re: [libcamera-devel] [PATCH v4.1 06/12] ipa: libipa: module: Make\n\tthe Module class Loggable","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Fri, Jun 24, 2022 at 02:27:41AM +0300, Laurent Pinchart wrote:\n> To help attribute messages logged by the Module class to a particular\n> IPA module, make the class loggable. The logPrefix() function must be\n> implemented by the IPA module-specific derived class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> Changes since v4:\n> \n> - Fix the commit message\n> ---\n> src/ipa/libipa/module.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h\n> index 00d5785e1aa0..cd67912f1b0c 100644\n> --- a/src/ipa/libipa/module.h\n> +++ b/src/ipa/libipa/module.h\n> @@ -27,7 +27,7 @@ namespace ipa {\n> \n> template \t typename _Params, typename _Stats>\n> -class Module\n> +class Module : public Loggable\n> {\n> public:\n> \tusing Context = _Context;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87DE2BD808\n\tfor ;\n\tFri, 24 Jun 2022 07:32:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7A9965635;\n\tFri, 24 Jun 2022 09:32:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6917165631\n\tfor ;\n\tFri, 24 Jun 2022 09:32:35 +0200 (CEST)","from pyrite.rasen.tech (softbank114048060123.bbtec.net\n\t[114.48.60.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD1BDDD;\n\tFri, 24 Jun 2022 09:32:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656055956;\n\tbh=aYxknG+pbj3CoPZXjIKNARe/vdnNILyAMJG7IIfF+II=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OAj29Q+/wXJr4TVvxbsuHugWFE49mYfLDpKajpyrS1XK0soRZA+zQvPBfVxgmnXTH\n\tn1p5BR2o9KhFw8q6pGG/+HbfVzQvBmFzVmD9EH52qGGTmt6Sebh7+oZbVrcTnhJn49\n\tlImYqXaqHYcoib8/hg3PIkKYMMK+lDXdLoWNiADgkZpXRy8Ig4e1XNoM/1Z21dgO8Y\n\t9A/FdtG4SC+HiUwWTXIlM7s/8Hm9azsRu/RBdwPQfjLzi/aptnc0tohcI0yP6feehY\n\tntHXX+EVlWF2OymZz/+eKCOlC8k64Ax81+PN+7LueKYWtRrC0GyyudD76OsQnBxdb6\n\toYXTvIxKyjY3w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656055955;\n\tbh=aYxknG+pbj3CoPZXjIKNARe/vdnNILyAMJG7IIfF+II=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rdRzMMlEvXPQpxOfr4rZ6IRHtSQElxP8TwpA6FuGOwC9lR/a9pO+cqpGGW9zzizJs\n\teuEm58cEuHV1mmDtguIBcrAc9lwgdrn5AvKZAg8v5fy67KBS6+nLZJfTjCGJnTuLf+\n\tM3AD2ZOfnKHGdBUN1pWrghBlvwuXBh5n2ktb3H44="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rdRzMMlE\"; dkim-atps=neutral","Date":"Fri, 24 Jun 2022 16:32:26 +0900","To":"Laurent Pinchart ","Message-ID":"<20220624073226.GI3309559@pyrite.rasen.tech>","References":"\n\t<20220623232741.19753-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220623232741.19753-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4.1 06/12] ipa: libipa: module: Make\n\tthe Module class Loggable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]