[{"id":23624,"web_url":"https://patchwork.libcamera.org/comment/23624/","msgid":"<2c8c6681eba97f78ce4a57141b3d714d150e6a5a.camel@collabora.com>","date":"2022-06-27T21:01:19","subject":"Re: [libcamera-devel] [PATCH 06/13] gstreamer: Rename queued\n\trequests queue to queuedRequests_","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Hi Laurent,\n\nLe vendredi 24 juin 2022 à 02:22 +0300, Laurent Pinchart a écrit :\n> To prepare for the addition of a completed requests queue, rename the\n> existing queued requests queue from requests_ to queuedRequests_.\n> \n> Signed-off-by: Laurent Pinchart \n\nWorks for me.\n\nReviewed-by: Nicolas Dufresne \n\nregards,\nNicolas\n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index a1fab71d4f09..02fc913764f8 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -108,7 +108,7 @@ struct GstLibcameraSrcState {\n> \tstd::shared_ptr cam_;\n> \tstd::unique_ptr config_;\n> \tstd::vector srcpads_;\n> -\tstd::queue> requests_;\n> +\tstd::queue> queuedRequests_;\n> \tguint group_id_;\n> \n> \tvoid requestCompleted(Request *request);\n> @@ -155,8 +155,8 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n> \n> \tGST_DEBUG_OBJECT(src_, \"buffers are ready\");\n> \n> -\tstd::unique_ptr wrap = std::move(requests_.front());\n> -\trequests_.pop();\n> +\tstd::unique_ptr wrap = std::move(queuedRequests_.front());\n> +\tqueuedRequests_.pop();\n> \n> \tg_return_if_fail(wrap->request_.get() == request);\n> \n> @@ -311,7 +311,7 @@ gst_libcamera_src_task_run(gpointer user_data)\n> \t\tGLibLocker lock(GST_OBJECT(self));\n> \t\tGST_TRACE_OBJECT(self, \"Requesting buffers\");\n> \t\tstate->cam_->queueRequest(wrap->request_.get());\n> -\t\tstate->requests_.push(std::move(wrap));\n> +\t\tstate->queuedRequests_.push(std::move(wrap));\n> \n> \t\t/* The RequestWrap will be deleted in the completion handler. */\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00993BE173\n\tfor ;\n\tMon, 27 Jun 2022 21:01:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F2D965635;\n\tMon, 27 Jun 2022 23:01:30 +0200 (CEST)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E1E36059B\n\tfor ;\n\tMon, 27 Jun 2022 23:01:29 +0200 (CEST)","from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net\n\t[192.222.136.102])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id 619A46601628;\n\tMon, 27 Jun 2022 22:01:28 +0100 (BST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656363690;\n\tbh=Wol9tnGoYfis7msGBRWjdmdYs81GWWc6wo1JJYDvfe8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OCjNsR271rj46J2uStyojejqS6ePc4BZCPwT2ODd0EvJtpDXnC+ZXPOyIlP4N5P9a\n\t2BWG48BcXKO40P5Jnn5wD0gC/7oCf9BaGJadR+puha1R/CN6gmKu21qo8TJ4b9By8s\n\tMsfxAFkTQzuJDD7NQ2QWeM+PjjG0eIlR99LtiNyq4OeEHi7GyHIdKchVnmvH5f+KZT\n\tVmRD/5bmFUCLP6Ip1wiRzSvFMZpntC55vtPT6/vTeV5f5GCIl7sKYB6TVRmpYaB4Fa\n\tMNHnwSAbE37ZsQsnkFpgIykBKRbXFEv2sfwPP2iSXlK0ckUhDz71Wql8oRbvKscBJF\n\t1C6aNsGqv8pvQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1656363688;\n\tbh=Wol9tnGoYfis7msGBRWjdmdYs81GWWc6wo1JJYDvfe8=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=NsWFp2o9aZKzeTAsx2xEplxfSR75Lf2X7xTMWssrs/qx6q9qQSNUob/YZVnDPelMk\n\trzPH9eN/DbHJ7pKmViERJj/IcotTV8UGkESGmoHIbkbiK5Q0sYf4UdHDlVjrWBO3Dv\n\tgY2mfpinoVpZv7r6LvA00Gc3XW4RPPDR+Glamgk9RnS4Dv4hj5MMqPe7w3k8kZEsD/\n\tTWZTMNxg3Z7vYQ2Z7jeH13QLgKV7xvL1tLFTfVfKaJBxFeiy8VSwdE1t+NcUSviaFa\n\tNvYEhgPk90twBcTNAXyegMeNE/7cvUxfmG7+/5A63P4a4gEv9oIjclLoCSZx0pq+WT\n\tAWSbqMQG6mbVQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"NsWFp2o9\"; dkim-atps=neutral","Message-ID":"<2c8c6681eba97f78ce4a57141b3d714d150e6a5a.camel@collabora.com>","To":"Laurent Pinchart , \n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 27 Jun 2022 17:01:19 -0400","In-Reply-To":"<20220623232210.18742-7-laurent.pinchart@ideasonboard.com>","References":"<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>\n\t<20220623232210.18742-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.44.2 (3.44.2-1.fc36) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH 06/13] gstreamer: Rename queued\n\trequests queue to queuedRequests_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicolas Dufresne via libcamera-devel\n\t","Reply-To":"Nicolas Dufresne ","Cc":"Vedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23660,"web_url":"https://patchwork.libcamera.org/comment/23660/","msgid":"<74d4d94f-6202-5617-4f22-f40567e3d17e@ideasonboard.com>","date":"2022-06-29T11:43:21","subject":"Re: [libcamera-devel] [PATCH 06/13] gstreamer: Rename queued\n\trequests queue to queuedRequests_","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 6/24/22 04:52, Laurent Pinchart via libcamera-devel wrote:\n> To prepare for the addition of a completed requests queue, rename the\n> existing queued requests queue from requests_ to queuedRequests_.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index a1fab71d4f09..02fc913764f8 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -108,7 +108,7 @@ struct GstLibcameraSrcState {\n> \tstd::shared_ptr cam_;\n> \tstd::unique_ptr config_;\n> \tstd::vector srcpads_;\n> -\tstd::queue> requests_;\n> +\tstd::queue> queuedRequests_;\n> \tguint group_id_;\n> \n> \tvoid requestCompleted(Request *request);\n> @@ -155,8 +155,8 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n> \n> \tGST_DEBUG_OBJECT(src_, \"buffers are ready\");\n> \n> -\tstd::unique_ptr wrap = std::move(requests_.front());\n> -\trequests_.pop();\n> +\tstd::unique_ptr wrap = std::move(queuedRequests_.front());\n> +\tqueuedRequests_.pop();\n> \n> \tg_return_if_fail(wrap->request_.get() == request);\n> \n> @@ -311,7 +311,7 @@ gst_libcamera_src_task_run(gpointer user_data)\n> \t\tGLibLocker lock(GST_OBJECT(self));\n> \t\tGST_TRACE_OBJECT(self, \"Requesting buffers\");\n> \t\tstate->cam_->queueRequest(wrap->request_.get());\n> -\t\tstate->requests_.push(std::move(wrap));\n> +\t\tstate->queuedRequests_.push(std::move(wrap));\n> \n> \t\t/* The RequestWrap will be deleted in the completion handler. */\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E39CBD808\n\tfor ;\n\tWed, 29 Jun 2022 11:43:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BC5C65635;\n\tWed, 29 Jun 2022 13:43:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D49C60412\n\tfor ;\n\tWed, 29 Jun 2022 13:43:29 +0200 (CEST)","from [IPV6:2401:4900:1f3f:ca21:e286:106b:5da4:9482] (unknown\n\t[IPv6:2401:4900:1f3f:ca21:e286:106b:5da4:9482])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 287DA3D7;\n\tWed, 29 Jun 2022 13:43:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656503011;\n\tbh=yKOcDsDmU3f1sS9DoslJQYCovJrpJ1v5XeUcgY8xSwA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CoklI3ysauHM+1k8SHw0hKIX6HW62B5IQmhVlSYQlWpp2RpXy1SHbWiDNucUXogVg\n\tq2eQN8HeTazfNlI/hY3MygaLClQGpp9oHKYk6pTQ7l6/iVTwTU2pblLPBvjBxsPoH9\n\tULjrFuuOJRFo9K+sPTxaAWZ6ps4kTowAe3c8L6+dCkCIzIzMnkReJlElQk6Prpw7rr\n\trkXzx+buJ1p0K8lFLdC0dSQVwGotpZDcCIeJAOSaqNH71M5KInHVBHpZEB/J7mUuk0\n\tClTDsrME9QeYJbcbDw6ddbkEI5L7rLV691/jIJ5nfzw31rMfZu5KlQP/qFzNu6Ze3N\n\t5Ih4OOb5dalAA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656503008;\n\tbh=yKOcDsDmU3f1sS9DoslJQYCovJrpJ1v5XeUcgY8xSwA=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Ap7jgxQKzWYc+1qERzSE0+jYkdABiPDJQSaqodj2bXlNcrAA1UI4iJAL8EKm+OTi7\n\teXLjX6Kx2KM5LN2bp43LUeUQEgD1PKEnD8pEHlQaCCH+N7pWKRL+1nCUkKVpiyLEop\n\tIn+HbixddagRBEqlfz37ZqXe/vCzvnsi2lxQQCME="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ap7jgxQK\"; dkim-atps=neutral","Message-ID":"<74d4d94f-6202-5617-4f22-f40567e3d17e@ideasonboard.com>","Date":"Wed, 29 Jun 2022 17:13:21 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>\n\t<20220623232210.18742-7-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220623232210.18742-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 06/13] gstreamer: Rename queued\n\trequests queue to queuedRequests_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"Nicolas Dufresne ,\n\tVedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]