{"id":16340,"url":"https://patchwork.libcamera.org/api/patches/16340/?format=json","web_url":"https://patchwork.libcamera.org/patch/16340/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220623144736.78537-3-tomi.valkeinen@ideasonboard.com>","date":"2022-06-23T14:47:31","name":"[libcamera-devel,RFC,v1,2/7] py: Add Python logging category","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a3eb53d8bd26abaab8989f53d5aec314c82bcc0d","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16340/mbox/","series":[{"id":3213,"url":"https://patchwork.libcamera.org/api/series/3213/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3213","date":"2022-06-23T14:47:29","name":"Python bindings event handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3213/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16340/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16340/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04595BD808\n\tfor ;\n\tThu, 23 Jun 2022 14:48:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F8BA6563F;\n\tThu, 23 Jun 2022 16:48:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CB3265635\n\tfor ;\n\tThu, 23 Jun 2022 16:47:58 +0200 (CEST)","from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D21FD80A;\n\tThu, 23 Jun 2022 16:47:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655995683;\n\tbh=EmB0VW8svYaSSYkOiGp3wWK3DCinwXd6t/TOpLxDyEk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=fXnO4KqrO3fCP4oJz/kf5ppvNxfRPWiv+Ppo6G7/luM/JLkDjo38tlnzOmVxJmPJ7\n\tVl9GqgVbnDJssQ6Lap124okpyUKBJjDG5yCkGrt7q9G1zYNsgejdH8GaMu4I2VEH0D\n\tUtEhKSo0KZ6hBaL48EO0cGAWwOTaRese6T82BtyNosGk6AFoMy0pjDZ/X7AVfT3XVJ\n\t4ssyir5lIC0Tu6EalTpDtpGWjABIByK5aVXNuYZaXl/R4s3GDU8xZeUKMndhVnSzsp\n\tkYxqeWb467/Dm9Mhiewmqt+g1OgILqzGRiYhebCD58WBpR0SF/HtZqEfdKP9VrI5yw\n\tyKTzF8pBs4LAQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655995678;\n\tbh=EmB0VW8svYaSSYkOiGp3wWK3DCinwXd6t/TOpLxDyEk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XhKTZ4SNMb0QFM2w1T0InsDtJnswbASpBP2Qf4KAKBRQpjWSWUEz5eYFEe1pllvq7\n\ty/r5NEgJH+OmAp0sZvW8GZU0TxtST/57S1ACdMTqD2wVXoKwHyDIp9zN6Bo6xARHHR\n\tX55q/GZs5rgO2kozvx9BF43WITqMgdMps+M22kjY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XhKTZ4SN\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Thu, 23 Jun 2022 17:47:31 +0300","Message-Id":"<20220623144736.78537-3-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220623144736.78537-1-tomi.valkeinen@ideasonboard.com>","References":"<20220623144736.78537-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC v1 2/7] py: Add Python logging category","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add Python logging category, and use it in handleRequestCompleted().\n\nSigned-off-by: Tomi Valkeinen \n---\n src/py/libcamera/py_main.cpp | 8 ++++++--\n src/py/libcamera/py_main.h | 12 ++++++++++++\n 2 files changed, 18 insertions(+), 2 deletions(-)\n create mode 100644 src/py/libcamera/py_main.h","diff":"diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 505cc3dc..17b17f60 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -5,6 +5,8 @@\n * Python bindings\n */\n \n+#include \"py_main.h\"\n+\n #include \n #include \n #include \n@@ -23,6 +25,8 @@ namespace py = pybind11;\n \n using namespace libcamera;\n \n+LOG_DEFINE_CATEGORY(Python)\n+\n template\n static py::object valueOrTuple(const ControlValue &cv)\n {\n@@ -120,10 +124,10 @@ static void handleRequestCompleted(Request *req)\n \tsize_t s = write(gEventfd, &v, 8);\n \t/*\n \t * We should never fail, and have no simple means to manage the error,\n-\t * so let's use LOG(Fatal).\n+\t * so let's use LOG(Python, Fatal).\n \t */\n \tif (s != 8)\n-\t\tLOG(Fatal) << \"Unable to write to eventfd\";\n+\t\tLOG(Python, Fatal) << \"Unable to write to eventfd\";\n }\n \n void init_py_enums(py::module &m);\ndiff --git a/src/py/libcamera/py_main.h b/src/py/libcamera/py_main.h\nnew file mode 100644\nindex 00000000..1b543a55\n--- /dev/null\n+++ b/src/py/libcamera/py_main.h\n@@ -0,0 +1,12 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2022, Tomi Valkeinen \n+ */\n+\n+#pragma once\n+\n+#include \n+\n+using namespace libcamera;\n+\n+LOG_DECLARE_CATEGORY(Python)\n","prefixes":["libcamera-devel","RFC","v1","2/7"]}