[{"id":23554,"web_url":"https://patchwork.libcamera.org/comment/23554/","msgid":"<165600111137.1149771.15284484998822194259@Monstersaurus>","date":"2022-06-23T16:18:31","subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-06-23 15:44:09)\n> Add a sensor_temperature field to the DeviceStatus structure. The default value\n> of -300.0 indicates a temperature measurement is unavilable. If a temperature\n\n/unavilable/unavailable/\n\n> measurement is available for a frame, the value is returned out through the\n> SensorTemperature control in the Request metadata.\n\nRather than a 'fake default' - I think std::optional could come\nto the rescue here.\n\n> \n> Additionally, provide the sensor temperature value from the std::ostream &operator<<\n> overload.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n> src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> 4 files changed, 12 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/raspberrypi/cam_helper.cpp\n> index 74179399e86a..046428de8545 100644\n> --- a/src/ipa/raspberrypi/cam_helper.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper.cpp\n> @@ -185,9 +185,9 @@ void CamHelper::parseEmbeddedData(Span buffer,\n> metadata.Merge(parsedMetadata);\n> \n> /*\n> - * Overwrite the exposure/gain values in the existing DeviceStatus with\n> - * values from the parsed embedded buffer. Fetch it first in case any\n> - * other fields were set meaningfully.\n> + * Overwrite the exposure/gain, frame length and sensor temperature values\n> + * in the existing DeviceStatus with values from the parsed embedded buffer.\n> + * Fetch it first in case any other fields were set meaningfully.\n> */\n> DeviceStatus deviceStatus, parsedDeviceStatus;\n> if (metadata.Get(\"device.status\", deviceStatus) ||\n> @@ -199,6 +199,7 @@ void CamHelper::parseEmbeddedData(Span buffer,\n> deviceStatus.shutter_speed = parsedDeviceStatus.shutter_speed;\n> deviceStatus.analogue_gain = parsedDeviceStatus.analogue_gain;\n> deviceStatus.frame_length = parsedDeviceStatus.frame_length;\n> + deviceStatus.sensor_temperature = parsedDeviceStatus.sensor_temperature;\n> \n> LOG(IPARPI, Debug) << \"Metadata updated - \" << deviceStatus;\n> \n> diff --git a/src/ipa/raspberrypi/controller/device_status.cpp b/src/ipa/raspberrypi/controller/device_status.cpp\n> index f052ea8b7bed..1a376eecb1c3 100644\n> --- a/src/ipa/raspberrypi/controller/device_status.cpp\n> +++ b/src/ipa/raspberrypi/controller/device_status.cpp\n> @@ -17,5 +17,8 @@ std::ostream &operator<<(std::ostream &out, const DeviceStatus &d)\n> << \" Lens: \" << d.lens_position\n> << \" Flash: \" << d.flash_intensity;\n> \n> + if (d.sensor_temperature != -300)\n> + out << \" Temperature: \" << d.sensor_temperature;\n> +\n> return out;\n> }\n> diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\n> index c4a5d9c8e8c7..53cfeedc2956 100644\n> --- a/src/ipa/raspberrypi/controller/device_status.h\n> +++ b/src/ipa/raspberrypi/controller/device_status.h\n> @@ -19,7 +19,7 @@ struct DeviceStatus {\n> DeviceStatus()\n> : shutter_speed(std::chrono::seconds(0)), frame_length(0),\n> analogue_gain(0.0), lens_position(0.0), aperture(0.0),\n> - flash_intensity(0.0)\n> + flash_intensity(0.0), sensor_temperature(-300.0)\n> {\n> }\n> \n> @@ -36,4 +36,6 @@ struct DeviceStatus {\n> double aperture;\n> /* proportional to brightness with 0 = no flash, 1 = maximum flash */\n> double flash_intensity;\n> + /* Sensor reported temperature value (in degrees) */\n> + double sensor_temperature;\n> };\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 3b126bb5175e..fb91c8d11f6c 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -491,6 +491,8 @@ void IPARPi::reportMetadata()\n> libcameraMetadata_.set(controls::AnalogueGain, deviceStatus->analogue_gain);\n> libcameraMetadata_.set(controls::FrameDuration,\n> helper_->Exposure(deviceStatus->frame_length).get());\n> + if (deviceStatus->sensor_temperature != -300)\n> + libcameraMetadata_.set(controls::SensorTemperature, deviceStatus->sensor_temperature);\n> }\n> \n> AgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67AECBD808\n\tfor ;\n\tThu, 23 Jun 2022 16:18:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A88CA65635;\n\tThu, 23 Jun 2022 18:18:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FF3D6048F\n\tfor ;\n\tThu, 23 Jun 2022 18:18:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D75ADD;\n\tThu, 23 Jun 2022 18:18:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656001115;\n\tbh=uP2tlwtgo11lruIK93Dp6d1gYhIgYIQerojcKZx55xc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=zVIdFw9jMrBxuFUv7H3j8pOu9P2LoEoj6pJX6M9NlKA+O2MI0fBAtbGnV4EqCwEzT\n\t8XkHzDZ1GrUWbNJS/FJxeihcSEvUiBkNdbjuZOjc/Ih7t6wazZwaiT+tG2xYR79lzQ\n\tYPGZTE0TxbO0RzZHhDw48mBPd+HUX+5R1qv8ejwPpnUW9i05D4KzYOaqdmLohQk05Q\n\tGiMXsKWSEOVi9HM6DoHVfw0fV2TszIuF4W4Lv16rI9BBytY2OVNwqu23ZrhhDrcM5t\n\ttUHkEbbqWlO2MmYFX3pAFv7RFZlpOgRpKWVMlgltPsHcQY+fJXBRV0EKuDXUzm+8IF\n\tikU0KG7Afph9w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656001113;\n\tbh=uP2tlwtgo11lruIK93Dp6d1gYhIgYIQerojcKZx55xc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=JZ/LmTkYfhQL9aD0uhBAt0LXZPvsJHb0n17qc4c5jnaCWzv0KB0udJwE2GO8K1O9j\n\t9QaT16Z/6mzAYNL8gwrG8Yz6PQr9cTC921RUshSlnGKaPEh9XrQuQDig51HXkXmXtR\n\t6WoTxWA5Vob8G+cLCa7BGSQHma/KFw1rMbYJxWlM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JZ/LmTkY\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220623144410.20725-3-naush@raspberrypi.com>","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t<20220623144410.20725-3-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 23 Jun 2022 17:18:31 +0100","Message-ID":"<165600111137.1149771.15284484998822194259@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23560,"web_url":"https://patchwork.libcamera.org/comment/23560/","msgid":"","date":"2022-06-24T07:12:54","subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThank you for your feedback.\n\nOn Thu, 23 Jun 2022 at 17:18, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Naushir Patuck via libcamera-devel (2022-06-23 15:44:09)\n> > Add a sensor_temperature field to the DeviceStatus structure. The\n> default value\n> > of -300.0 indicates a temperature measurement is unavilable. If a\n> temperature\n>\n> /unavilable/unavailable/\n>\n> > measurement is available for a frame, the value is returned out through\n> the\n> > SensorTemperature control in the Request metadata.\n>\n> Rather than a 'fake default' - I think std::optional could come\n> to the rescue here.\n>\n\nI did consider std::optional, but decided against it to keep in the\n\"spirit\" of the\nDeviceStatus structure. We have lens_position, aperture and\nflash_intensity fields\nthat are optional but set with a default invalid value.\n\nHaving said that, I much prefer the std::optional approach as well, and I\nwill change\nto use it. As a separate patch, I will also switch the other optional\nfields to use std::optional.\n\nRegards,\nNaush\n\n\n\n>\n> >\n> > Additionally, provide the sensor temperature value from the std::ostream\n> &operator<<\n> > overload.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/raspberrypi/cam_helper.cpp | 7 ++++---\n> > src/ipa/raspberrypi/controller/device_status.cpp | 3 +++\n> > src/ipa/raspberrypi/controller/device_status.h | 4 +++-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> > 4 files changed, 12 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/cam_helper.cpp\n> b/src/ipa/raspberrypi/cam_helper.cpp\n> > index 74179399e86a..046428de8545 100644\n> > --- a/src/ipa/raspberrypi/cam_helper.cpp\n> > +++ b/src/ipa/raspberrypi/cam_helper.cpp\n> > @@ -185,9 +185,9 @@ void CamHelper::parseEmbeddedData(Span uint8_t> buffer,\n> > metadata.Merge(parsedMetadata);\n> >\n> > /*\n> > - * Overwrite the exposure/gain values in the existing\n> DeviceStatus with\n> > - * values from the parsed embedded buffer. Fetch it first in\n> case any\n> > - * other fields were set meaningfully.\n> > + * Overwrite the exposure/gain, frame length and sensor\n> temperature values\n> > + * in the existing DeviceStatus with values from the parsed\n> embedded buffer.\n> > + * Fetch it first in case any other fields were set meaningfully.\n> > */\n> > DeviceStatus deviceStatus, parsedDeviceStatus;\n> > if (metadata.Get(\"device.status\", deviceStatus) ||\n> > @@ -199,6 +199,7 @@ void CamHelper::parseEmbeddedData(Span uint8_t> buffer,\n> > deviceStatus.shutter_speed = parsedDeviceStatus.shutter_speed;\n> > deviceStatus.analogue_gain = parsedDeviceStatus.analogue_gain;\n> > deviceStatus.frame_length = parsedDeviceStatus.frame_length;\n> > + deviceStatus.sensor_temperature =\n> parsedDeviceStatus.sensor_temperature;\n> >\n> > LOG(IPARPI, Debug) << \"Metadata updated - \" << deviceStatus;\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/device_status.cpp\n> b/src/ipa/raspberrypi/controller/device_status.cpp\n> > index f052ea8b7bed..1a376eecb1c3 100644\n> > --- a/src/ipa/raspberrypi/controller/device_status.cpp\n> > +++ b/src/ipa/raspberrypi/controller/device_status.cpp\n> > @@ -17,5 +17,8 @@ std::ostream &operator<<(std::ostream &out, const\n> DeviceStatus &d)\n> > << \" Lens: \" << d.lens_position\n> > << \" Flash: \" << d.flash_intensity;\n> >\n> > + if (d.sensor_temperature != -300)\n> > + out << \" Temperature: \" << d.sensor_temperature;\n> > +\n> > return out;\n> > }\n> > diff --git a/src/ipa/raspberrypi/controller/device_status.h\n> b/src/ipa/raspberrypi/controller/device_status.h\n> > index c4a5d9c8e8c7..53cfeedc2956 100644\n> > --- a/src/ipa/raspberrypi/controller/device_status.h\n> > +++ b/src/ipa/raspberrypi/controller/device_status.h\n> > @@ -19,7 +19,7 @@ struct DeviceStatus {\n> > DeviceStatus()\n> > : shutter_speed(std::chrono::seconds(0)),\n> frame_length(0),\n> > analogue_gain(0.0), lens_position(0.0), aperture(0.0),\n> > - flash_intensity(0.0)\n> > + flash_intensity(0.0), sensor_temperature(-300.0)\n> > {\n> > }\n> >\n> > @@ -36,4 +36,6 @@ struct DeviceStatus {\n> > double aperture;\n> > /* proportional to brightness with 0 = no flash, 1 = maximum\n> flash */\n> > double flash_intensity;\n> > + /* Sensor reported temperature value (in degrees) */\n> > + double sensor_temperature;\n> > };\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 3b126bb5175e..fb91c8d11f6c 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -491,6 +491,8 @@ void IPARPi::reportMetadata()\n> > libcameraMetadata_.set(controls::AnalogueGain,\n> deviceStatus->analogue_gain);\n> > libcameraMetadata_.set(controls::FrameDuration,\n> >\n> helper_->Exposure(deviceStatus->frame_length).get());\n> > + if (deviceStatus->sensor_temperature != -300)\n> > +\n> libcameraMetadata_.set(controls::SensorTemperature,\n> deviceStatus->sensor_temperature);\n> > }\n> >\n> > AgcStatus *agcStatus =\n> rpiMetadata_.GetLocked(\"agc.status\");\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04D96BE173\n\tfor ;\n\tFri, 24 Jun 2022 07:13:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F09465637;\n\tFri, 24 Jun 2022 09:13:10 +0200 (CEST)","from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36F8665631\n\tfor ;\n\tFri, 24 Jun 2022 09:13:09 +0200 (CEST)","by mail-lj1-x229.google.com with SMTP id j22so1825516ljg.0\n\tfor ;\n\tFri, 24 Jun 2022 00:13:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656054790;\n\tbh=aG8OYAbjI26+9ykHU04b/qB0KXMfHZejAum6etrr7/s=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TJx77ZzVa74a5/AsptUeP6q8+mlb1af2K42UTCSxej+P0IEEGiLEqTo7r8hfkJcCL\n\tI5PCiq2EU8NmWv91chtYDDW3cPmLIGz3/XfRx4DuP6zQh/bVSaLhM/OIYvOVHPm8bJ\n\tBW9Gs5y/ZJsCpxaWF2jr12CUyl4qyzRFqzZEJ/TGzpD9Qe19Su50lKVoo82mTrPHlT\n\tyOeabWh/HmH8D1fCtzvlRM4C2GlzoxQPtJIQxAONMkZ6EC8Ep614rF9sKjMBnAkstL\n\tEE0WbQrAEWkarD7HUKZSwwQt6IKNrcvP8bFiO7PGXTbzZDQlVMdke9wlwTj9wgp1zr\n\tEN8cjxjriHGAQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=gYGayZzEg4gZ6baisraANXxyumsswOcVtU2+3impWNM=;\n\tb=t6Y+ZIXnDQgZSULw106Hx5304yjs7rEWOaNstXsliKxzh5VpkyNsWOtPbmayOZGaY+\n\tpst1kT04nx32cAy5iSrPkMzT65aEEc92XsfOXN50TkwLsxcm5n4ttVnM+jdxG21qQ+Oi\n\tHk94PyPBJfwKdd4czIh0Vaco+9uGlZgt+1d2Rkiz1ZkucSBl4zF9zqkHinj5aSSvIf8I\n\tYxVWVSG6s0oHWCzMPfYfCT6IOzNrJYCkVmGqbaE3LxpfXxnscrQ/vCiM2gpTEf8fOMnz\n\tGRYk6rlzoGHZr5LTzY8pExnSDV/lEZDQjCAHWJ2hhTWUBx38dtnSGkDUwJrq5Q1aTwuS\n\t4Mjg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"t6Y+ZIXn\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=gYGayZzEg4gZ6baisraANXxyumsswOcVtU2+3impWNM=;\n\tb=3hsvBOmfwyFBbOs3VoKsqBeZFB45n+5ipBqckqK+Jm1e1OdxKMDl3ZbgN/wFJs9Hi0\n\ti2L5FAxuhq2nieN8x7Lbo8Xa8aFQ6C6c8RJ/TSkQui/0ASaFffXZY0jyeDjaQE0vGh5/\n\tsJ0TN1g0WYtxIlmAj6NVueIwa5CsARevGasjjOGyYAOA1s8JigPQR9FRDT5JSSXmkNJy\n\tp8ynA8A+VBR0KEC23FU7ypYpNvVviGuDOjobMTdtVqhL2hoAVfZVBHw8F/JwIO1jXK9/\n\tTxB7K+WD2JYglorOHqBArGH9P0hsAeaQG0ArEmaK0EZO4jJ+PJ6gGG2WQsxQo2aiCghn\n\tDG5A==","X-Gm-Message-State":"AJIora+S3dnxp6Ie8g9q6ltKQFhAt8av/ursxGTqjVVS+CmbXp+iqMpG\n\tS3K4v6VUYbBFxnkzsC9zST5FkTtnYR8eHNAYSGcU3FnCXqrfig==","X-Google-Smtp-Source":"AGRyM1vvSTBVizWHr29uKWJPojuGORrGozDzvp9LdvWnzGwfsmyQItPK2mPT9H1G1J5BvvAQwk2L+piHyJG/VK6uk4Q=","X-Received":"by 2002:a05:651c:24b:b0:259:85b:ac09 with SMTP id\n\tx11-20020a05651c024b00b00259085bac09mr6717205ljn.46.1656054788320;\n\tFri, 24 Jun 2022 00:13:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t<20220623144410.20725-3-naush@raspberrypi.com>\n\t<165600111137.1149771.15284484998822194259@Monstersaurus>","In-Reply-To":"<165600111137.1149771.15284484998822194259@Monstersaurus>","Date":"Fri, 24 Jun 2022 08:12:54 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"000000000000630dbf05e22c4ddb\"","Subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: raspberrypi: Add sensor\n\ttemperature to DeviceStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]