[{"id":23553,"web_url":"https://patchwork.libcamera.org/comment/23553/","msgid":"<165600090164.1149771.5236953098858459074@Monstersaurus>","date":"2022-06-23T16:15:01","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: controls: Add\n\tSensorTemperature control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-06-23 15:44:08)\n> Add a SensorTemperature control to return the temperature of the camera sensor\n> in Celsius. This control will only be present in the Request metadata if a\n> thermal sensor is available to the camera sensor.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index cd1d4512bf2e..ecab3ae97260 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -367,6 +367,16 @@ controls:\n> \n> size: [2]\n> \n> + - SensorTemperature:\n> + type: float\n> + description: |\n> + Temperature measure from the camera sensor in Celsius. This is typically\n> + obtained by a thermal sensor present on-die or in the camera module. The\n> + range of reported temperatures is device dependent.\n> +\n> + The SensorTemperature control will only be returned in metadata if a\n> + themal sensor is present.\n\nHrm - I don't know if we 'need' to say this last bit, but it seems\ncorrect. Presumably there are other metadata fields that are optional\nto provide and are only in the metadata if they are available.\n\nReviewed-by: Kieran Bingham \n\n> +\n> - SensorTimestamp:\n> type: int64_t\n> description: |\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6FFEBE173\n\tfor ;\n\tThu, 23 Jun 2022 16:15:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE0C965637;\n\tThu, 23 Jun 2022 18:15:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC30C6048F\n\tfor ;\n\tThu, 23 Jun 2022 18:15:04 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 917986BB;\n\tThu, 23 Jun 2022 18:15:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656000905;\n\tbh=mCHtZgWqQE95PptQEGHYkuCnkPJM+VMaal6u05CF/JQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=SaCTtxPo+HH6gbol2iDWHrHBtE+5ocLp3LuwexaivUww6h061+Gc6a5qDJroLX0GM\n\tneqZVWhhS0Ro9nEcWAFEmfyH1Xvh5h59vmY1iuHKVc12NHzfEeozf0Zd8EzNBEDJmk\n\t1r7lr+F2YFNYzdB4A+llJ3i7zzcfIyw+YJ6hSRVnjv4+NaADe4JAZZXaIT+2Q6R7FO\n\tEiSVDToss1M4Vh8j/kE21PoeznvN7NLb1+7rVo1tNuNZ+OJTNmiJA4i3hoRjjff9Nc\n\t64jVAE4MHghrPHoEFJgn/cTIqNeNSV8sTpmFJ12Nss1DgNdlkEbV1K1k93bZ3NAYV7\n\ttbSaM4MM75SrQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656000904;\n\tbh=mCHtZgWqQE95PptQEGHYkuCnkPJM+VMaal6u05CF/JQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=jsci3K4Jq9MtIUg7VQZ+7ws5osQ/DP/+Vp4p/JD94Vsv5wpffaHc+9NZ50bzSGoBh\n\tv1nkJhcRw3t+RDBEmvcIgwzGeSStQCmy0V/7512dNZDYoeYz6TQp79V4y6PZPGpkFe\n\tk/tc78p7ldu6m7wNXpUSGzr5XqPwgsjR9pKqjqK0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jsci3K4J\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220623144410.20725-2-naush@raspberrypi.com>","References":"<20220623144410.20725-1-naush@raspberrypi.com>\n\t<20220623144410.20725-2-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 23 Jun 2022 17:15:01 +0100","Message-ID":"<165600090164.1149771.5236953098858459074@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: controls: Add\n\tSensorTemperature control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]