[{"id":23556,"web_url":"https://patchwork.libcamera.org/comment/23556/","msgid":"<165600155631.1149771.1838998945618700714@Monstersaurus>","date":"2022-06-23T16:25:56","subject":"Re: [libcamera-devel] [PATCH] py: Honour the pycamera meson option","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Javier Martinez Canillas (2022-06-23 13:41:40)\n> The libcamera Python bindings are attempted to be built unconditionally,\n> even when there is a meson feature option to disable it. Make the meson\n> build file in the sub-dir to exit earlier if pycamera has been disabled.\n> \n\ns/ to exit/ exit/\n\nSeems reasonable, I wonder if there are other components that don't\nadhere to the disabled option too, as I expect the dep.found() pattern\nis used elsewhere. And the 'disabled' only makes it optional to find it\n(which it still can).\n\nAny interest in checking other uses to go along side this? (Probably as\none patch) - otherwise, merging this if agreed should still be a\nresolution to the current issue.\n\n--\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Javier Martinez Canillas \n> ---\n> \n> src/py/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index eb8845388692..5efae1baec8c 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -2,7 +2,7 @@\n> \n> py3_dep = dependency('python3', required : get_option('pycamera'))\n> \n> -if not py3_dep.found()\n> +if get_option('pycamera').disabled() or not py3_dep.found()\n> pycamera_enabled = false\n> subdir_done()\n> endif\n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1D83BE173\n\tfor ;\n\tThu, 23 Jun 2022 16:26:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0D2265635;\n\tThu, 23 Jun 2022 18:26:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C2736048F\n\tfor ;\n\tThu, 23 Jun 2022 18:25:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB479DD;\n\tThu, 23 Jun 2022 18:25:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656001561;\n\tbh=aILdLC6BpR3IzzaR7QcpQEmUR/cjnsbwgqo56grmi2w=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=eEFhO2MLqK07XYn/L+Qo9OuZ28qaxWY/l0rws11K0EpNgWVIC6Jm7+eXf4pOwjgpC\n\tKG355Ca/UngiK4hPScW9cr7+1SNRigdyK2RDuqsuNxBkZja88UsRq/ssnTB11Kz7Ml\n\tWsjQE1Xik2p5rnywznGr8oEQnEraVAevbM2khS7sgk7Z65iHQ/bRuusEnuWW+N2792\n\tvscvklufXArWzh8/0smq6hBv2GL0+hCE68Eq9WZjSzoPv1v2WV341H9kvaoywdXUTu\n\tHobu94NAZ6jDgicA/K/iKuMkSgjvYKR3K5LIBXzyemETkry72BIAMWUbwMKDm+dLuo\n\tNhl3lKWXprpqA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656001558;\n\tbh=aILdLC6BpR3IzzaR7QcpQEmUR/cjnsbwgqo56grmi2w=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=MmGTwfcByYFnU1mxYCU4O6F+bdn/r3+/GtU+3g7Rq+75g84/024X8s9vIIRPudeWo\n\tuZeRjyXZdm48O7ciTSweXUY9eU66sSykqSk5ZK54Ny2om9CqGmWAHUd9Pkmujk9GZb\n\tQL4le/YJ2OaPnIexnKmuv+2QDePEGyj1zlBp892I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MmGTwfcB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220623124140.610241-1-javierm@redhat.com>","References":"<20220623124140.610241-1-javierm@redhat.com>","To":"Javier Martinez Canillas ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 23 Jun 2022 17:25:56 +0100","Message-ID":"<165600155631.1149771.1838998945618700714@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] py: Honour the pycamera meson option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23557,"web_url":"https://patchwork.libcamera.org/comment/23557/","msgid":"","date":"2022-06-23T17:06:47","subject":"Re: [libcamera-devel] [PATCH] py: Honour the pycamera meson option","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Thu, Jun 23, 2022 at 05:25:56PM +0100, Kieran Bingham wrote:\n> Quoting Javier Martinez Canillas (2022-06-23 13:41:40)\n> > The libcamera Python bindings are attempted to be built unconditionally,\n> > even when there is a meson feature option to disable it. Make the meson\n> > build file in the sub-dir to exit earlier if pycamera has been disabled.\n> \n> s/ to exit/ exit/\n> \n> Seems reasonable, I wonder if there are other components that don't\n> adhere to the disabled option too, as I expect the dep.found() pattern\n> is used elsewhere. And the 'disabled' only makes it optional to find it\n> (which it still can).\n> \n> Any interest in checking other uses to go along side this? (Probably as\n> one patch) - otherwise, merging this if agreed should still be a\n> resolution to the current issue.\n\nhttps://mesonbuild.com/Build-options.html#features\n\n\"disabled do not look for the dependency and always return 'not-found'.\"\n\nI've just tested it, and I confirm the behaviour. If I set pycamera to\ndisabled, then it doesn't get built, even if the dependency exists.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Javier Martinez Canillas \n> > ---\n> > \n> > src/py/libcamera/meson.build | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> > index eb8845388692..5efae1baec8c 100644\n> > --- a/src/py/libcamera/meson.build\n> > +++ b/src/py/libcamera/meson.build\n> > @@ -2,7 +2,7 @@\n> > \n> > py3_dep = dependency('python3', required : get_option('pycamera'))\n> > \n> > -if not py3_dep.found()\n> > +if get_option('pycamera').disabled() or not py3_dep.found()\n> > pycamera_enabled = false\n> > subdir_done()\n> > endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3087FBE173\n\tfor ;\n\tThu, 23 Jun 2022 17:07:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EEC465635;\n\tThu, 23 Jun 2022 19:07:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C2376048F\n\tfor ;\n\tThu, 23 Jun 2022 19:07:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86AC2DD;\n\tThu, 23 Jun 2022 19:07:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656004025;\n\tbh=EDgiEDxeJiFy3VQ+A/6vdaIoKlwaYgriW+XCuSzeaZY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nGPBX/XwuKetrUteN0EligKTmbzEJlbB3nGjlAoIBaMB/RwgyY9TVtL+B6EnxiZfh\n\t/FyAgA82dq5EOS5T9C9IM51MMVwRleF+dw9RRcJM7mYpRBCtYNwQUntmOqygS4pMqY\n\tNp5g7C/WqW9nUTmtRIneCvluJY/QHqW6PE9gODw6ZNwM8g+KjmFFPXj62hs0Y1OPoD\n\tucCG7IWwNyC0BiL9lKYu2SGFMHVLVV6JH+dDk2l3EWvNiZeSfQeBGPF37+5r5HaMrA\n\tTEK5QcLOKSNfEvOt/Vojt+VvCaetQUMPoER9Z30V2G+QYR1u+6XXZee5UtNHDbAUd7\n\tEVGmqhBoTUPNw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656004022;\n\tbh=EDgiEDxeJiFy3VQ+A/6vdaIoKlwaYgriW+XCuSzeaZY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pPq6syqRq+PQ+zPejTtX7vYy48BFDD4uuAZGn6tvc6UhOjtSwi3uAYspKqEFikKj5\n\tJNwpdWG6K7tR6H+ZE5JmTmjm+/lm0tlHkvUA7nVQJ8bIbC0LVYZrc9wQ/G6ycTdK85\n\t064Q5pg2ECesahDiBv70FnX0Ls6SSNFwju4SuypQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pPq6syqR\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 20:06:47 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220623124140.610241-1-javierm@redhat.com>\n\t<165600155631.1149771.1838998945618700714@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165600155631.1149771.1838998945618700714@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] py: Honour the pycamera meson option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23559,"web_url":"https://patchwork.libcamera.org/comment/23559/","msgid":"<00df6f94-7e6c-90d9-fab6-0c4075b1752f@redhat.com>","date":"2022-06-23T23:17:32","subject":"Re: [libcamera-devel] [PATCH] py: Honour the pycamera meson option","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Hello Laurent,\n\nOn 6/23/22 19:06, Laurent Pinchart wrote:\n> Hello,\n> \n> On Thu, Jun 23, 2022 at 05:25:56PM +0100, Kieran Bingham wrote:\n>> Quoting Javier Martinez Canillas (2022-06-23 13:41:40)\n>>> The libcamera Python bindings are attempted to be built unconditionally,\n>>> even when there is a meson feature option to disable it. Make the meson\n>>> build file in the sub-dir to exit earlier if pycamera has been disabled.\n>>\n>> s/ to exit/ exit/\n>>\n>> Seems reasonable, I wonder if there are other components that don't\n>> adhere to the disabled option too, as I expect the dep.found() pattern\n>> is used elsewhere. And the 'disabled' only makes it optional to find it\n>> (which it still can).\n>>\n>> Any interest in checking other uses to go along side this? (Probably as\n>> one patch) - otherwise, merging this if agreed should still be a\n>> resolution to the current issue.\n> \n> https://mesonbuild.com/Build-options.html#features\n> \n> \"disabled do not look for the dependency and always return 'not-found'.\"\n> \n> I've just tested it, and I confirm the behaviour. If I set pycamera to\n> disabled, then it doesn't get built, even if the dependency exists.\n> \nYou are right. I just tested dropping this patch from the package and it\ndoes indeed still build. I wonder why it failed for me before that lead\nme to write this patch. Maybe I did something silly when testing my pkg\nbuild...\n\nFeel free to discard this patch, sorry to the noise.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D34E7BE173\n\tfor ;\n\tThu, 23 Jun 2022 23:17:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD0C965637;\n\tFri, 24 Jun 2022 01:17:39 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A0AF61FB2\n\tfor ;\n\tFri, 24 Jun 2022 01:17:37 +0200 (CEST)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-142-idA6JqezNy-CeqKFHFrHWw-1; Thu, 23 Jun 2022 19:17:34 -0400","by mail-wm1-f70.google.com with SMTP id\n\th205-20020a1c21d6000000b003a03a8475c6so106563wmh.8\n\tfor ;\n\tThu, 23 Jun 2022 16:17:34 -0700 (PDT)","from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\tf11-20020a05600c4e8b00b0039c4945c753sm5445454wmq.39.2022.06.23.16.17.32\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 23 Jun 2022 16:17:33 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656026259;\n\tbh=9rsWrav6rtuydkBv2qCmkPVfgm1GXbNO8glTVvw1gbI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f+ACo7GmgwUN7ImhfooUo26SsXbfXp9dgRpQDgqEFJVm/6It6e1lBIJ7SxWFGWm1H\n\t6n2spf+p/gMkcR5G07Jd/nz7Zx+CGBMaC+ZqzAAaCRFe52p1iuglV4DbslOYkci7be\n\tZjXJxwcfQicr16Q4yM38xGVI5dpmEKeLcqWo1sAfndK7EpyTjsAMKKda/xw+o10r/n\n\tpyC8f2APs0pjcfbMFokKkbe5NcVUSPbdHl1lWGgh3dXePMXHei8Oe+PCRp/rB23gtY\n\t7gMWkGKbO1njbOFVge54qUdmfOUO0GpB72UpwkNkNDlSOWO3awNIii7WoMtzfYlYl8\n\tT0hBupP794TjQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1656026256;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=0YlXD4fcFdRM+DNJZVuFS8P2kSH3mEU75NK7W/Lgyr4=;\n\tb=eRdXFKPysg9A6KJEXc5INeWmHFmc9ThaWKbhA6f43CUSDkW3hzHEQYxESO3r2b/Xx3JuAB\n\tim3f5kzI/08AIwjPG0syIFFVmFRSzp+5mpQ4sstylaKwf7F1mj74Pi8UTkGGRmIQSGKvYp\n\tDylttPY4XJrZJnonBNXNbOMIou4yju8="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"eRdXFKPy\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com"],"X-MC-Unique":"idA6JqezNy-CeqKFHFrHWw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n\t:content-language:to:cc:references:from:in-reply-to\n\t:content-transfer-encoding;\n\tbh=0YlXD4fcFdRM+DNJZVuFS8P2kSH3mEU75NK7W/Lgyr4=;\n\tb=mw487k0l6IgPgOAGR8PlxcYbJEjAvihxRA7MTc3cB4MzRvkLY6QNbeweitXTEyH/96\n\t1d4NoXuwJptf9d8vHqDs1+yyJrlPPLWNwLi6c6rb7+4QarT/KWB5zt0qU6eCJbXCeUvY\n\t+RkKmxQ7Pd3FMOzrZn1mQWbvKRrVaUUj1TmzIAcsT+C36JXXG7LWWycRkSvPhDYyWpci\n\tjEoHMJGPLm3LV1CppzLkVhx7GAE+edG9Vxmg928MHz2ehkI7jZPfanvp5MaPnsJ0KFWj\n\t+szd9PEAG1TAF3giYKXN7XPReTnscU6B8szZr391guYlkg6qcrpT/CBdJRo+6p6/d58a\n\tHqRA==","X-Gm-Message-State":"AJIora9uhCdmrQe5PC1szU0kW0MBtpgwlyAcDzPGtZDCNlU0jjk/nzno\n\tWbFEOeRRFCd7yqsh15bVKA5guOqvZ/Utpfys+KXKlRjv1ZJpKxaWAo/bS/Up0GwShfGafUs8+zD\n\tB2B62TRl+1VZEzDCfZ/SfxbJtznE/AQCMaQ==","X-Received":["by 2002:a05:600c:a182:b0:39e:f33a:a990 with SMTP id\n\tid2-20020a05600ca18200b0039ef33aa990mr349491wmb.59.1656026253774; \n\tThu, 23 Jun 2022 16:17:33 -0700 (PDT)","by 2002:a05:600c:a182:b0:39e:f33a:a990 with SMTP id\n\tid2-20020a05600ca18200b0039ef33aa990mr349473wmb.59.1656026253486; \n\tThu, 23 Jun 2022 16:17:33 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1s6ozpj5bHCtNvH/KgPvXv/su3pqdo5EHxLOU+D4yHOu3r/q1SJmJOXJvferZY4YTrxGpB7fQ==","Message-ID":"<00df6f94-7e6c-90d9-fab6-0c4075b1752f@redhat.com>","Date":"Fri, 24 Jun 2022 01:17:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.10.0","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20220623124140.610241-1-javierm@redhat.com>\n\t<165600155631.1149771.1838998945618700714@Monstersaurus>\n\t","In-Reply-To":"","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] py: Honour the pycamera meson option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Javier Martinez Canillas via libcamera-devel\n\t","Reply-To":"Javier Martinez Canillas ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]