[{"id":23542,"web_url":"https://patchwork.libcamera.org/comment/23542/","msgid":"","date":"2022-06-23T12:14:03","subject":"Re: [libcamera-devel] [PATCH] meson: options: Disable pycamera by\n\tdefault","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Javier,\n\nThank you for the patch.\n\nOn Thu, Jun 23, 2022 at 02:10:38PM +0200, Javier Martinez Canillas wrote:\n> The libcamera Python bindings is still experimental and it relies on some\n> features in pybind11 that are not yet upstreamed, so a special branch has\n> to be downloaded as a subproject.\n> \n> This conflicts with the build process used by most Linux distributions,\n> since there is expected that all the dependencies will be fulfilled by\n> -devel packages present in the build root.\n> \n> To allow libcamera to be built by distros, let's disable the pycamera by\n> default. This can still be enabled with `meson build -Dpycamera=enabled`.\n> \n> Suggested-by: Tomi Valkeinen \n> Signed-off-by: Javier Martinez Canillas \n\nSounds sensible to me. Any volunteer to engage with upstream pybind11 to\nget the features we need in their master branch ? :-)\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> meson_options.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index ca00c78e8134..7a9aecfc60f5 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -61,5 +61,5 @@ option('v4l2',\n> \n> option('pycamera',\n> type : 'feature',\n> - value : 'auto',\n> + value : 'disabled',\n> description : 'Enable libcamera Python bindings (experimental)')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 853ACBE173\n\tfor ;\n\tThu, 23 Jun 2022 12:14:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B353F65635;\n\tThu, 23 Jun 2022 14:14:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBF066048F\n\tfor ;\n\tThu, 23 Jun 2022 14:14:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AB0ADD;\n\tThu, 23 Jun 2022 14:14:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655986460;\n\tbh=7eFxo3f4lfNzldCKhH7L2aAp9a3VzGbTPVQKYIazY1c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SCG48fi2g0poT9EczI5A0b2F2jSm/AKkkR1Ak4VGitMqNPzEsbPnwJJ3MDAnH8BsG\n\tAWbq54fhRzl2gbTi+C7eLSYqAZwqbo0nJGuc8DqrN1lTfsNPo3gai6XM/f3k5xnAMp\n\tbNPTn5jTg//Suuadr1EuB8EqPPCrBVNGrX9EOFDIiL24SAf0Hi9vchIcnC4UOER8Pf\n\tELKLsFkCNF5k4WUpuHAJomuhfJJ+f+FC4AvqhevV2jsSVGaBlfZl3Bn7aQvXKlvvPq\n\tLL3pBpHWnza3vRiwZ8vBoqIMSiaBn/RWc0ugiNiNHbyG3ErjomRD43QFZMyIhrDuwV\n\t0dn/z5JhmcN7g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655986459;\n\tbh=7eFxo3f4lfNzldCKhH7L2aAp9a3VzGbTPVQKYIazY1c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WpPxEsNDAYvuRqR+lSLUmIA4SLkcklEEiTxNiNa/memr7S5mbuinqBr2Ohk1PZQWP\n\t+KMaEyv5OP1FuB6e+LWLr7hlLQ8A0y/cPJPuYSu+VvRmvGWxtRkFBUPTvyRqHFmQSJ\n\tnEIwSoHGi7z/iVeEP93902BiAsXyvEC/fuW1gWm4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WpPxEsND\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 15:14:03 +0300","To":"Javier Martinez Canillas ","Message-ID":"","References":"<20220623121038.598008-1-javierm@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220623121038.598008-1-javierm@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH] meson: options: Disable pycamera by\n\tdefault","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23543,"web_url":"https://patchwork.libcamera.org/comment/23543/","msgid":"","date":"2022-06-23T12:22:43","subject":"Re: [libcamera-devel] [PATCH] meson: options: Disable pycamera by\n\tdefault","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 23/06/2022 15:14, Laurent Pinchart wrote:\n> Hi Javier,\n> \n> Thank you for the patch.\n> \n> On Thu, Jun 23, 2022 at 02:10:38PM +0200, Javier Martinez Canillas wrote:\n>> The libcamera Python bindings is still experimental and it relies on some\n>> features in pybind11 that are not yet upstreamed, so a special branch has\n>> to be downloaded as a subproject.\n>>\n>> This conflicts with the build process used by most Linux distributions,\n>> since there is expected that all the dependencies will be fulfilled by\n>> -devel packages present in the build root.\n>>\n>> To allow libcamera to be built by distros, let's disable the pycamera by\n>> default. This can still be enabled with `meson build -Dpycamera=enabled`.\n>>\n>> Suggested-by: Tomi Valkeinen \n>> Signed-off-by: Javier Martinez Canillas \n> \n> Sounds sensible to me. Any volunteer to engage with upstream pybind11 to\n> get the features we need in their master branch ? :-)\n\nI know you're talking to me there...\n\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Tomi Valkeinen \n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D598BD808\n\tfor ;\n\tThu, 23 Jun 2022 12:22:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2EF165632;\n\tThu, 23 Jun 2022 14:22:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F25F66048F\n\tfor ;\n\tThu, 23 Jun 2022 14:22:46 +0200 (CEST)","from [192.168.1.111] (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58789DD;\n\tThu, 23 Jun 2022 14:22:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655986969;\n\tbh=sOe8LVvCShsJB3Sd/qGWuIWkpdkjJi3wVWI4j5FVO18=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=K6+9gqW8RjuWJ6lv65jQmhyAqaz0OYZEe43+To3i10oEn128xbbU7MlMfHMQMk/Yk\n\tQeNrNTdGVM2G6BA9az5echeyGjYPR9u5+q9ZEg9XbQHiiq0qEDRKb5IsHYslxgS97n\n\tzF5pqHuLOi1vk6LfzsCjAwtpgfnjtg7s3cBSCYxEZn8PTM5C8h0ziMzQ+ywnWwjRUw\n\tSAP+rdFrgv/O6w5sp9rcCX7Iv/7e7oJ2GimEjewGRTXfyDgrLeMh5eVkT/1DiHwK2V\n\t0c6gi0V37W6YqlpHNqJAUIx1uq1SfzVS+XACDMeueFWkKkXCRiQnuzGX/X8fL5VMHC\n\tZTIzfo4vacRkg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655986966;\n\tbh=sOe8LVvCShsJB3Sd/qGWuIWkpdkjJi3wVWI4j5FVO18=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=AusUBucKk/w36r7sXG+e+g1a3W1srerAnJD2RQJwipf9TvyCm3Z0rUgwQBHZXHZ7J\n\tWfBlBVyUtbmf7XXcDi8MUspnKCyPaAb+aI/mGMpjX17NKJF0mNxf4UOp8RRnRyM5Zq\n\t7ig1NwkGa43vCV52LmL8aLvyBDrAyCFdKh6lkB6c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AusUBucK\"; dkim-atps=neutral","Message-ID":"","Date":"Thu, 23 Jun 2022 15:22:43 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.9.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tJavier Martinez Canillas ","References":"<20220623121038.598008-1-javierm@redhat.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson: options: Disable pycamera by\n\tdefault","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23544,"web_url":"https://patchwork.libcamera.org/comment/23544/","msgid":"<165598716543.18145.1328524213540436999@Monstersaurus>","date":"2022-06-23T12:26:05","subject":"Re: [libcamera-devel] [PATCH] meson: options: Disable pycamera by\n\tdefault","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Javier Martinez Canillas (2022-06-23 13:10:38)\n> The libcamera Python bindings is still experimental and it relies on some\n> features in pybind11 that are not yet upstreamed, so a special branch has\n> to be downloaded as a subproject.\n> \n> This conflicts with the build process used by most Linux distributions,\n> since there is expected that all the dependencies will be fulfilled by\n> -devel packages present in the build root.\n> \n> To allow libcamera to be built by distros, let's disable the pycamera by\n> default. This can still be enabled with `meson build -Dpycamera=enabled`.\n\nFine with me, but lets highlight this to RPi as the main users so far.\n\nDavid, Naush - can you bring this to the attention of who ever packages\nlibcamera, to note that they will have to manually enable pycamera\n\n -Dpycamera=enabled\n\n\nReviewed-by: Kieran Bingham \n \n\n\n> \n> Suggested-by: Tomi Valkeinen \n> Signed-off-by: Javier Martinez Canillas \n> ---\n> \n> meson_options.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index ca00c78e8134..7a9aecfc60f5 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -61,5 +61,5 @@ option('v4l2',\n> \n> option('pycamera',\n> type : 'feature',\n> - value : 'auto',\n> + value : 'disabled',\n> description : 'Enable libcamera Python bindings (experimental)')\n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E60EBD808\n\tfor ;\n\tThu, 23 Jun 2022 12:26:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B476F65635;\n\tThu, 23 Jun 2022 14:26:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6D206048F\n\tfor ;\n\tThu, 23 Jun 2022 14:26:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4098580A;\n\tThu, 23 Jun 2022 14:26:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655987169;\n\tbh=rRYVKPjI5uWtggwE4dJ9ortUxaJZwEiunYhm2tc3CU4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ayt2pCQ3QyOPrmXrYRgy+iqcYTiI1OVPM1B3I9yJXdGBh7lV4vHNgi29yWJt4Gnkc\n\tKb0Ba2cb7pcmZr9rDVL4c7oNIlpMyPyZ9a7XJbyBU8WO7xGltZyMVNiKqkwLH5Zq+J\n\tgmO37On+ZaSBNPUTL8H23qFh0yRZmCkNjN0BXt5IuIethwTMIxL+FtT3XXWI1bzbc3\n\tbaO5LBAKdc7v4RIeeVvS0qgUDcxCRKr7UXM5yl927k74gmYvLsj4wf1sg8aBv5ytO/\n\teRj/y51NeZDUXTgx2Mk6+j5YRfBWHGElM12fjUWj52UaOmFEmTn+9r4ZEnY56JqeF8\n\tlVO4J0NFtP8Eg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655987168;\n\tbh=rRYVKPjI5uWtggwE4dJ9ortUxaJZwEiunYhm2tc3CU4=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=Yrd2+lj02fYWyny+xQKWSsBaX749x562xBQtv8CTQMQ9LRx2dnTTyTT1z/uOo7rXg\n\tFPm+owQf3iEbjJUYkwUE/WZiIdlSjeGGHh8BqYcHFSOpZXiLbPwN9ggaGTHOCR1BjD\n\tARFE0S1qiV60xCEbeXtAA9Tl6X3mk+Jes47Iy3Jc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Yrd2+lj0\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220623121038.598008-1-javierm@redhat.com>","References":"<20220623121038.598008-1-javierm@redhat.com>","To":"Javier Martinez Canillas ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 23 Jun 2022 13:26:05 +0100","Message-ID":"<165598716543.18145.1328524213540436999@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: options: Disable pycamera by\n\tdefault","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]