[{"id":23849,"web_url":"https://patchwork.libcamera.org/comment/23849/","msgid":"","date":"2022-07-13T00:51:17","subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: rkisp1: Add support of\n\tDefect Pixel Cluster Correction control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Florian,\n\nThank you for the patch.\n\nThe comments to patch 3/5 apply here too.\n\nOn Wed, Jun 22, 2022 at 05:19:18PM +0200, Florian Sylvestre via libcamera-devel wrote:\n> The Defect Pixel Cluster Correction algorithm is responsible to minimize\n> the impact of defective pixels. The on-the-fly method is actually used,\n> based on coefficient provided by the tuning file.\n> \n> Signed-off-by: Florian Sylvestre \n> ---\n> src/ipa/rkisp1/algorithms/dpcc.cpp | 273 ++++++++++++++++++++++++++\n> src/ipa/rkisp1/algorithms/dpcc.h | 35 ++++\n> src/ipa/rkisp1/algorithms/meson.build | 1 +\n> src/ipa/rkisp1/data/ov5640.yaml | 60 ++++++\n> src/ipa/rkisp1/rkisp1.cpp | 1 +\n> 5 files changed, 370 insertions(+)\n> create mode 100644 src/ipa/rkisp1/algorithms/dpcc.cpp\n> create mode 100644 src/ipa/rkisp1/algorithms/dpcc.h\n> \n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> new file mode 100644\n> index 00000000..0c78ba9d\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> @@ -0,0 +1,273 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021-2022, Ideas On Board\n> + *\n> + * lsc.cpp - RkISP1 Defect Pixel Cluster Correction control\n> + */\n> +\n> +#include \"dpcc.h\"\n> +\n> +#include \n> +\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +#include \"linux/rkisp1-config.h\"\n> +\n> +/**\n> + * \\file dpcc.h\n> + */\n> +\n> +namespace libcamera {\n> +\n> +namespace ipa::rkisp1::algorithms {\n> +\n> +/**\n> + * \\class DefectPixelClusterCorrection\n> + * \\brief RkISP1 Defect Pixel Cluster Correction control\n> + *\n> + * Depending of the sensor quality, some pixels can be defective and then\n> + * appear significantly brighter or darker than the other pixels.\n> + *\n> + * The Defect Pixel Cluster Correction algorithms is responsible to minimize\n> + * the impact of the pixels.\n> + * This can be done with algorithms applied at run time (on-the-fly method) or\n> + * with a table of defective pixels. Only first method is supported for the\n> + * moment.\n> + */\n> +\n> +LOG_DEFINE_CATEGORY(RkISP1Dpcc)\n> +\n> +DefectPixelClusterCorrection::DefectPixelClusterCorrection()\n> +\t: tuningParameters_(false)\n> +{\n> +}\n> +\n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::init\n> + */\n> +int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context,\n> +\t\t\t\t const YamlObject &tuningData)\n> +{\n> +\tbool fixedSet = tuningData[\"fixed-set\"].get(true);\n\nI'd default this to false, considering an element that is not present in\nthe file as true would be confusing.\n\n> +\ttuning_.set_use =\n> +\t\tfixedSet ? RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_FIX_SET : 0;\n\n\ttuning_.set_use = tuningData[\"fixed-set\"].get(true)\n\t\t\t? RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_FIX_SET : 0;\n\n> +\n> +\t/* Get all defined sets to apply (up to 3). */\n> +\tconst YamlObject &setsObject = tuningData[\"sets\"];\n> +\tif (!setsObject.isList()) {\n> +\t\tLOG(RkISP1Dpcc, Error)\n> +\t\t\t<< \"'sets' list parameternot found in tuning file\";\n\ns/list parameternot/parameter not/\n\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\tif (setsObject.size() > RKISP1_CIF_ISP_DPCC_METHODS_MAX) {\n> +\t\tLOG(RkISP1Dpcc, Error)\n> +\t\t\t<< \"'sets' size in tuning file (\" << setsObject.size()\n> +\t\t\t<< \") exceed HW maximum capacity(3)\";\n\n\t\t\t<< \") exceeds the maximum hardware capacity (3)\";\n\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\ttuning_.ro_limits = 0;\n> +\ttuning_.rnd_offs = 0;\n\nHow about zeroing tuning_ in the constructor\n\n\t: tuningParameters_(false), tuning_({})\n\nand avoiding all the initializations to 0 in this function ?\n\n> +\n> +\tfor (std::size_t i = 0; i < setsObject.size(); ++i) {\n\n\t\tstruct rkisp1_cif_isp_dpcc_methods_config &method = tuning_.methods[i];\n\t\tconst YamlObject &set = setsObject[i];\n\nand use them everywhere below.\n\n> +\t\tuint16_t value;\n> +\n> +\t\t/* Enable set if described in Yaml tuning file. */\n> +\t\ttuning_.set_use |= 0x1 << i;\n\ns/0x1/1/\n\n> +\n> +\t\t/* Disable all methods by default. */\n> +\t\ttuning_.methods[i].method = 0;\n> +\n> +\t\t/* PG Method */\n> +\t\tconst YamlObject &pgObject = setsObject[i][\"pg-factor\"];\n> +\t\ttuning_.methods[i].pg_fac = 0;\n> +\n> +\t\tif (pgObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_PG_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = pgObject[\"green\"].get(0);\n> +\t\t\ttuning_.methods[i].pg_fac |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_PG_FAC_G(value);\n> +\t\t}\n> +\n> +\t\tif (pgObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_PG_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = pgObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.methods[i].pg_fac |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_PG_FAC_RB(value);\n> +\t\t}\n> +\n> +\t\t/* RO Method */\n> +\t\tconst YamlObject &roObject = setsObject[i][\"ro-limits\"];\n> +\n> +\t\tif (roObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RO_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = roObject[\"green\"].get(0);\n> +\t\t\ttuning_.ro_limits |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RO_LIMITS_n_G(i, value);\n> +\t\t}\n> +\n> +\t\tif (roObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RO_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = roObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.ro_limits |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RO_LIMITS_n_RB(i, value);\n> +\t\t}\n> +\n> +\t\t/* RG Method */\n> +\t\tconst YamlObject &rgObject = setsObject[i][\"rg-factor\"];\n> +\t\ttuning_.methods[i].rg_fac = 0;\n> +\n> +\t\tif (rgObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RG_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = rgObject[\"green\"].get(0);\n> +\t\t\ttuning_.methods[i].rg_fac |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RG_FAC_G(value);\n> +\t\t}\n> +\n> +\t\tif (rgObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RG_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = rgObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.methods[i].rg_fac |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RG_FAC_RB(value);\n> +\t\t}\n> +\n> +\t\t/* RND Method */\n> +\t\tconst YamlObject &rndOffsetsObject = setsObject[i][\"rnd-offsets\"];\n> +\n> +\t\tif (rndOffsetsObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = rndOffsetsObject[\"green\"].get(0);\n> +\t\t\ttuning_.rnd_offs |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_OFFS_n_G(i, value);\n> +\t\t}\n> +\n> +\t\tif (rndOffsetsObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = rndOffsetsObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.rnd_offs |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_OFFS_n_RB(i, value);\n> +\t\t}\n> +\n> +\t\tconst YamlObject &rndThresholdObject = setsObject[i][\"rnd-threshold\"];\n> +\t\ttuning_.methods[i].rnd_thresh = 0;\n> +\n> +\t\tif (rndThresholdObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = rndThresholdObject[\"green\"].get(0);\n> +\t\t\ttuning_.methods[i].rnd_thresh |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_THRESH_G(value);\n> +\t\t}\n> +\n> +\t\tif (rndThresholdObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = rndThresholdObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.methods[i].rnd_thresh |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_THRESH_RB(value);\n> +\t\t}\n> +\n> +\t\t/* LC Method */\n> +\t\tconst YamlObject &lcThresholdObject = setsObject[i][\"line-threshold\"];\n> +\t\ttuning_.methods[i].line_thresh = 0;\n> +\n> +\t\tif (lcThresholdObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = lcThresholdObject[\"green\"].get(0);\n> +\t\t\ttuning_.methods[i].line_thresh |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_THRESH_G(value);\n> +\t\t}\n> +\n> +\t\tif (lcThresholdObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = lcThresholdObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.methods[i].line_thresh |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_THRESH_RB(value);\n> +\t\t}\n> +\n> +\t\tconst YamlObject &lcTMadFactorObject = setsObject[i][\"line-mad-factor\"];\n> +\t\ttuning_.methods[i].line_mad_fac = 0;\n> +\n> +\t\tif (lcTMadFactorObject.contains(\"green\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_GREEN_ENABLE;\n> +\n> +\t\t\tvalue = lcTMadFactorObject[\"green\"].get(0);\n> +\t\t\ttuning_.methods[i].line_mad_fac |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_G(value);\n> +\t\t}\n> +\n> +\t\tif (lcTMadFactorObject.contains(\"red-blue\")) {\n> +\t\t\ttuning_.methods[i].method |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_RED_BLUE_ENABLE;\n> +\n> +\t\t\tvalue = lcTMadFactorObject[\"red-blue\"].get(0);\n> +\t\t\ttuning_.methods[i].line_mad_fac |=\n> +\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_RB(value);\n> +\t\t}\n\nThat's lots of manually-written code, I wonder if we could do better.\nI'll sleep over it.\n\n> +\t}\n> +\n> +\ttuningParameters_ = true;\n> +\n> +\treturn 0;\n> +}\n> +\n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::prepare\n> + */\n> +void DefectPixelClusterCorrection::prepare(IPAContext &context,\n> +\t\t\t\t\t rkisp1_params_cfg *params)\n> +{\n> +\tif (context.frameContext.frameCount > 0)\n> +\t\treturn;\n> +\n> +\tif (!tuningParameters_)\n> +\t\treturn;\n> +\n> +\tparams->others.dpcc_config.mode =\n> +\t\tRKISP1_CIF_ISP_DPCC_MODE_STAGE1_ENABLE;\n> +\tparams->others.dpcc_config.output_mode =\n> +\t\tRKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_G_CENTER |\n> +\t\tRKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_RB_CENTER;\n\nI would set all of these in tuning_ in init(), and replace the code\nbelow\n\n> +\tparams->others.dpcc_config.rnd_offs = tuning_.rnd_offs;\n> +\tparams->others.dpcc_config.ro_limits = tuning_.ro_limits;\n> +\tparams->others.dpcc_config.set_use = tuning_.set_use;\n> +\n> +\tfor (std::size_t i = 0; i < RKISP1_CIF_ISP_DPCC_METHODS_MAX; ++i) {\n> +\t\tmemcpy(¶ms->others.dpcc_config.methods[i],\n> +\t\t &tuning_.methods[i],\n> +\t\t sizeof(rkisp1_cif_isp_dpcc_methods_config));\n> +\t}\n\nwith\n\n\tparams->others.dpcc_config = tuning_;\n\n> +\n> +\tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_DPCC;\n> +\tparams->module_ens |= RKISP1_CIF_ISP_MODULE_DPCC;\n> +\tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_DPCC;\n> +}\n> +\n> +REGISTER_IPA_ALGORITHM(DefectPixelClusterCorrection)\n> +\n> +} /* namespace ipa::rkisp1::algorithms */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.h b/src/ipa/rkisp1/algorithms/dpcc.h\n> new file mode 100644\n> index 00000000..6c6c6aaa\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.h\n> @@ -0,0 +1,35 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021-2022, Ideas On Board\n> + *\n> + * dpcc.h - RkISP1 Defect Pixel Cluster Correction control\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \"algorithm.h\"\n> +\n> +namespace libcamera {\n> +\n> +struct IPACameraSensorInfo;\n> +\n> +namespace ipa::rkisp1::algorithms {\n> +\n> +class DefectPixelClusterCorrection : public Algorithm\n> +{\n> +public:\n> +\tDefectPixelClusterCorrection();\n> +\t~DefectPixelClusterCorrection() = default;\n> +\n> +\tint init(IPAContext &context, const YamlObject &tuningData) override;\n> +\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n> +\n> +private:\n> +\tbool tuningParameters_;\n> +\trkisp1_cif_isp_dpcc_config tuning_;\n\nI'd name the variable config_ insteead of tuning_, as it stores the\nconfiguration data, not the tuning data.\n\n> +};\n> +\n> +} /* namespace ipa::rkisp1::algorithms */\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\n> index 64e11dce..87007493 100644\n> --- a/src/ipa/rkisp1/algorithms/meson.build\n> +++ b/src/ipa/rkisp1/algorithms/meson.build\n> @@ -4,6 +4,7 @@ rkisp1_ipa_algorithms = files([\n> 'agc.cpp',\n> 'awb.cpp',\n> 'blc.cpp',\n> + 'dpcc.cpp',\n> 'gsl.cpp',\n> 'lsc.cpp',\n> ])\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> index 154ed3b5..51228218 100644\n> --- a/src/ipa/rkisp1/data/ov5640.yaml\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -97,4 +97,64 @@ algorithms:\n> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n> ]\n> + - DefectPixelClusterCorrection:\n> + fixed-set: false\n> + sets:\n> + # PG, LC, RO, RND, RG\n> + - line-threshold:\n> + green: 8\n> + red-blue: 8\n> + line-mad-factor:\n> + green: 4\n> + red-blue: 4\n> + pg-factor:\n> + green: 8\n> + red-blue: 8\n> + rnd-threshold:\n> + green: 10\n> + red-blue: 10\n> + rg-factor:\n> + green: 32\n> + red-blue: 32\n> + ro-limits:\n> + green: 1\n> + red-blue: 1\n> + rnd-offsets:\n> + green: 2\n> + red-blue: 2\n> + # PG, LC, RO\n> + - line-threshold:\n> + green: 24\n> + red-blue: 32\n> + line-mad-factor:\n> + green: 16\n> + red-blue: 24\n> + pg-factor:\n> + green: 6\n> + red-blue: 8\n> + ro-limits:\n> + green: 2\n> + red-blue: 2\n> + # PG, LC, RO, RND, RG\n> + - line-threshold:\n> + green: 32\n> + red-blue: 32\n> + line-mad-factor:\n> + green: 4\n> + red-blue: 4\n> + pg-factor:\n> + green: 10\n> + red-blue: 10\n> + rnd-threshold:\n> + green: 6\n> + red-blue: 8\n> + rg-factor:\n> + green: 4\n> + red-blue: 4\n> + ro-limits:\n> + green: 1\n> + red-blue: 2\n> + rnd-offsets:\n> + green: 2\n> + red-blue: 2\n> ...\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 996edc0a..a32bb9d1 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -31,6 +31,7 @@\n> #include \"algorithms/algorithm.h\"\n> #include \"algorithms/awb.h\"\n> #include \"algorithms/blc.h\"\n> +#include \"algorithms/dpcc.h\"\n> #include \"algorithms/gsl.h\"\n> #include \"algorithms/lsc.h\"\n> #include \"libipa/camera_sensor_helper.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 643FFBD1F1\n\tfor ;\n\tWed, 13 Jul 2022 00:51:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC0E66330B;\n\tWed, 13 Jul 2022 02:51:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5922C6048B\n\tfor ;\n\tWed, 13 Jul 2022 02:51:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8ABE305;\n\tWed, 13 Jul 2022 02:51:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657673508;\n\tbh=dh9Wri+VrEMTIzpEcirFrAbhnAtMGMBlIs0PzQPw+Nk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0Py1E75VUhbhaCUJgqrxT3dm98qqKxJ92kJ2WDRSil7zrcr7i0SjGesxuCMvrtzjR\n\tslwBP9xe3B7sMAWqecZ5Vbvi1HwRLO/+yW4Do58OyJORLkkEsP4fPWB8uvPXJ/LYnh\n\tiza++bEE1MVTNl52hL5cjQ7Q6IGMgsSw3Od8p2rGXYAqzFQWJgrE76pqKVZS89li2G\n\tdEliccA+q7oWmJJUjHPb4gng3tKZvV0dt+N17AX9K5J24Oqx22CgUVcLkdgZOdr5Zu\n\t8qo5TlneqBC1bQ9NFH3tChciU6zxIXiN9J9dLd4ZRrYTzkIiGSOH78XKCJovRY0ERh\n\t0if/N/MhTGSKQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657673506;\n\tbh=dh9Wri+VrEMTIzpEcirFrAbhnAtMGMBlIs0PzQPw+Nk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ygbr3eHxU0FVot5E5P+ogxgjlAY1QQfS4sbQyoyYAGVQ6D6cFMjYDaE6x/m2w/Inx\n\tBCgTftg69R03Fx0a0RHtmRQvAvH1a4JFye4zCZofriOtAqynurkJ+jtrpXL9cc3EnN\n\tHSPDr6VrY9S+6Roi46hXOIM53XahSH0MG0Akyq/E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ygbr3eHx\"; dkim-atps=neutral","Date":"Wed, 13 Jul 2022 03:51:17 +0300","To":"Florian Sylvestre ","Message-ID":"","References":"<20220622151918.451635-1-fsylvestre@baylibre.com>\n\t<20220622151918.451635-6-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220622151918.451635-6-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: rkisp1: Add support of\n\tDefect Pixel Cluster Correction control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]