[{"id":23911,"web_url":"https://patchwork.libcamera.org/comment/23911/","msgid":"<20220715073147.GC3411283@pyrite.rasen.tech>","date":"2022-07-15T07:31:47","subject":"Re: [libcamera-devel] [PATCH 3/4] utils: rkisp1: Fix pixel format\n\tfor raw capture","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Tue, Jun 21, 2022 at 12:06:57AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The regexp to convert the raw pixel media bus code to a pixel format is\n> incorrect. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/rkisp1/rkisp1-capture.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\n> index eee6b8027261..2549779d0f78 100755\n> --- a/utils/rkisp1/rkisp1-capture.sh\n> +++ b/utils/rkisp1/rkisp1-capture.sh\n> @@ -171,7 +171,7 @@ mediactl=\"media-ctl -d $mdev\"\n> \n> get_sensor_format \"$sensor\"\n> if [[ $raw == true ]] ; then\n> -\tcapture_format=$(echo $sensor_mbus_code | sed 's/_[0-9X]$//')\n> +\tcapture_format=$(echo $sensor_mbus_code | sed 's/_[0-9X]*$//')\n> \tcapture_mbus_code=$sensor_mbus_code\n> else\n> \tcapture_format=YUYV","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AB66BE173\n\tfor ;\n\tFri, 15 Jul 2022 07:31:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0442763312;\n\tFri, 15 Jul 2022 09:31:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D939E6330B\n\tfor ;\n\tFri, 15 Jul 2022 09:31:54 +0200 (CEST)","from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B81C993;\n\tFri, 15 Jul 2022 09:31:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657870316;\n\tbh=11pdJ2g4ui1/6fcurTW49c14pLKUUnCLeA1z0ydcABM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oRJgRkcK66WNItOx+uUFYUc1lEIT87ksCwVO41C1UkaKkoeJH1B8pbzvp5PT2cUit\n\tdsoXLbFuuvwaFg5JW+Y3njpdMIYa0+IPIG8cwhgRYwLhTvVEFAioxwzD0dhNBiQFHA\n\tlUEKSmXjCrDni/Wwe+9i+aIfr156PGhAX6Ga4h6b9nc0RTl9WT/l0yhk/CgErjNNZa\n\taCOHIJSkW/l5YtVYs13Hxeo/+EEE9wSB/JRRCQvhPEfMSIggbJg9mWx5xNjz+iuVDc\n\t3gte1qr2zUnHBFttEYS6+WC3RSgj6T5JyqYDNpcTWzK+H660i8KgYVj5JU3agUnvn9\n\tckPlB30ZUbn8w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657870314;\n\tbh=11pdJ2g4ui1/6fcurTW49c14pLKUUnCLeA1z0ydcABM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ua54rTtVyj64Q3/SiEpZ5y30bXlXHqlQINCsYs9JM86vTJssYbKdGIvApzhC/XPdj\n\tdL1hMVx79NWm9QR4dEAVfBjia4Qpyo8/6jiLjulNGrNNu23VNk/RzG7+zqV2ybqb1O\n\tJwir6t3dVaJo9k/MjRmuBdHht1pK6H0XyTHGgBIA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ua54rTtV\"; dkim-atps=neutral","Date":"Fri, 15 Jul 2022 16:31:47 +0900","To":"Laurent Pinchart ","Message-ID":"<20220715073147.GC3411283@pyrite.rasen.tech>","References":"<20220620210658.20288-1-laurent.pinchart@ideasonboard.com>\n\t<20220620210658.20288-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220620210658.20288-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] utils: rkisp1: Fix pixel format\n\tfor raw capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]