[{"id":24808,"web_url":"https://patchwork.libcamera.org/comment/24808/","msgid":"","date":"2022-08-28T18:33:48","subject":"Re: [libcamera-devel] [PATCH v2 4/5] v4l2: v4l2_camera_proxy: Apply\n\tclang thread safety annotation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang and Hiro,\n\nThank you for the patch.\n\nOn Mon, Jun 20, 2022 at 10:20:26PM +0530, Umang Jain via libcamera-devel wrote:\n> From: Hirokazu Honda \n> \n> This annotates member functions of V4L2CameraProxy by clang\n> thread safety annotations.\n> \n> Signed-off-by: Hirokazu Honda \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera_proxy.h | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> index 76ca2d8a..8a0195e1 100644\n> --- a/src/v4l2/v4l2_camera_proxy.h\n> +++ b/src/v4l2/v4l2_camera_proxy.h\n> @@ -27,13 +27,15 @@ class V4L2CameraProxy\n> public:\n> \tV4L2CameraProxy(unsigned int index, std::shared_ptr camera);\n> \n> -\tint open(V4L2CameraFile *file);\n> -\tvoid close(V4L2CameraFile *file);\n> +\tint open(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n> +\tvoid close(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n> \tvoid *mmap(V4L2CameraFile *file, void *addr, size_t length, int prot,\n> -\t\t int flags, off64_t offset);\n> -\tint munmap(V4L2CameraFile *file, void *addr, size_t length);\n> +\t\t int flags, off64_t offset) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n> +\tint munmap(V4L2CameraFile *file, void *addr, size_t length)\n> +\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n> \n> -\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg);\n> +\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg)\n> +\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n> \n> private:\n> \tbool validateBufferType(uint32_t type);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1F24C3272\n\tfor ;\n\tSun, 28 Aug 2022 18:33:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E0EC61FC0;\n\tSun, 28 Aug 2022 20:33:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D343F61FBD\n\tfor ;\n\tSun, 28 Aug 2022 20:33:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5562AE5;\n\tSun, 28 Aug 2022 20:33:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661711638;\n\tbh=kQlNob6KRi2LAD0Iet65xVVq/fT9HdpjlSys8xkIG7E=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dmQpxY5bxRrinEKRVftkQ95Q3y9srDuFXecpBhO/lzDMeoCda3BEMnCPHlFEiYxma\n\t8FKCKOtYIZNqvQ3OIDdKghFVEPogQDz4KRrj0N/+b3x7KEKV99pwhdF3kc8rXehBIk\n\tnT9MI+YNH+0zf7Kzuerlk9motintl2kRnWrt/9GikDfwDG0uIilJleaRMiFdFxJA4y\n\t2W2+atCVnc0EwWVQsBxni0oRkM/H4nbKVbhdYcw1waHONS61XjGC9ngtCRClbVftEC\n\t4luhHGcwxwZjKL5iecghecGM7eYotX8aoWZRJDwKzlOKRFXhxi3xtHN+clXuInduXo\n\tmOaRH3vujYRdQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661711636;\n\tbh=kQlNob6KRi2LAD0Iet65xVVq/fT9HdpjlSys8xkIG7E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SVfHP1ASkR+82dCCiY6b/iJrGQnLZbztH8N+OK6b0f44HIKVquz41xpzj3kaOxrIv\n\t5ZBGbRRTU16yeEG+Rl8jk5yzmMz3nxHHb3YjI7T5ibdHvGhtKiPEBVX+sWVifQ89K5\n\tthZfnASBCAmlWPchDYaLqfTaH1Wu37aVqpi3ueD8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SVfHP1AS\"; dkim-atps=neutral","Date":"Sun, 28 Aug 2022 21:33:48 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220620165027.549085-1-umang.jain@ideasonboard.com>\n\t<20220620165027.549085-5-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220620165027.549085-5-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] v4l2: v4l2_camera_proxy: Apply\n\tclang thread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]