[{"id":23476,"web_url":"https://patchwork.libcamera.org/comment/23476/","msgid":"","date":"2022-06-20T08:27:56","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Protect\n\tcameras_ by mutex in cleanup()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Mon, Jun 20, 2022 at 11:28:09AM +0530, Umang Jain via libcamera-devel wrote:\n> From: Hirokazu Honda \n> \n> CameraManager::Private::cleanup() accesses cameras_ without acquiring\n> mutex_. Fix it.\n\nCould you explain here why the lock is needed ?\n\n> Signed-off-by: Hirokazu Honda \n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/camera_manager.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 70d73822..4492edc3 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -178,7 +178,10 @@ void CameraManager::Private::cleanup()\n> \t * process deletion requests from the thread's message queue as the event\n> \t * loop is not in action here.\n> \t */\n> +\tmutex_.lock();\n> \tcameras_.clear();\n> +\tmutex_.unlock();\n> +\n> \tdispatchMessages(Message::Type::DeferredDelete);\n> \n> \tenumerator_.reset(nullptr);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10F2BBE173\n\tfor ;\n\tMon, 20 Jun 2022 08:28:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C089265638;\n\tMon, 20 Jun 2022 10:28:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EA8B60473\n\tfor ;\n\tMon, 20 Jun 2022 10:28:11 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0C3A892;\n\tMon, 20 Jun 2022 10:28:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655713691;\n\tbh=z3NB5IBfSBGKKVtXzmq7Ua3DvazLqZjIdlK6TNfS3v8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=P0S+8J556D9JzvWXJilPK9XmfDh93MeNCHlvRXIXPs6kYIXdM4F8xK/RmvcHntOHX\n\tdc4kSD0TdwQEss+hzlMvLrDeaNWyovgipvvddEd4xa33mbD9iUcLGX7azOzUXZjypj\n\t6r56e8u7mhIVyyspdjfaIQx+QQTtnW3T1XNvrFObEXIhNfTx4W9wwftEEXXpC2+oI5\n\tAifEbW8FjPtUBiysFIBlYUjJTAkOgm5fPJYKQnypWogXF0gc2VwU8Bc30iqZh8liNx\n\tCqMRQ3AJjHXwr6xCBout2OBg/SMewExxt0aHPerZVwZr0h/QqpUoCfEinBWLJfx99e\n\tSqHmB2PIaxE7w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655713690;\n\tbh=z3NB5IBfSBGKKVtXzmq7Ua3DvazLqZjIdlK6TNfS3v8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=daK55NCpX/7L7IH1FgStk9VoSecr0IFBQ5mrGl4Zb8jC1itCw8O4AL3LDUy2MtoGB\n\t++KDJmzTb16QUtbR7ebq+ZALG69GCk5SHcVyuWbMG3lG3koZ6IVi+f3AuDVZwBuTlE\n\tMHA2qk8JeSr/qtGVERHh5iO8r7gY8xl8eiDkdvNs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"daK55NCp\"; dkim-atps=neutral","Date":"Mon, 20 Jun 2022 11:27:56 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220620055809.392808-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220620055809.392808-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Protect\n\tcameras_ by mutex in cleanup()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]