[{"id":23537,"web_url":"https://patchwork.libcamera.org/comment/23537/","msgid":"<20220623084832.GF3309559@pyrite.rasen.tech>","date":"2022-06-23T08:48:32","subject":"Re: [libcamera-devel] [PATCH v4 10/12] ipa: rkisp1: Add IMX219\n\ttuning file","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Mon, Jun 20, 2022 at 04:43:03AM +0300, Laurent Pinchart wrote:\n> Add a skeleton for the IMX219 tuning file, with data for the BLC\n> algorithm.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 13 +++++++++++++\n> src/ipa/rkisp1/data/meson.build | 1 +\n> 2 files changed, 14 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/imx219.yaml\n> \n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> new file mode 100644\n> index 000000000000..232d8ae8d58b\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -0,0 +1,13 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.2\n> +---\n> +version: 1\n> +algorithms:\n> + - Agc:\n> + - Awb:\n> + - BlackLevelCorrection:\n> + R: 256\n> + Gr: 256\n> + Gb: 256\n> + B: 256\n> +...\n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> index e5b945966625..53ef7fe28e1d 100644\n> --- a/src/ipa/rkisp1/data/meson.build\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> conf_files = files([\n> + 'imx219.yaml',\n> 'uncalibrated.yaml',\n> ])\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EA15BE173\n\tfor ;\n\tThu, 23 Jun 2022 08:48:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C98A665635;\n\tThu, 23 Jun 2022 10:48:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 642EF60412\n\tfor ;\n\tThu, 23 Jun 2022 10:48:40 +0200 (CEST)","from pyrite.rasen.tech (softbank114048060123.bbtec.net\n\t[114.48.60.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AB258F;\n\tThu, 23 Jun 2022 10:48:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655974121;\n\tbh=foASl3Vj0AhR27/pjk0NCywovCtbkSx0uqkJI0qsdBU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=AEztL1WfGSXPY+gZip5FD/XpXISHkhxbQ5nMUnV5YwOLqIiZV5Zq0lOaL7capaLoE\n\tRllbk4dZnS2IDOWmsKZFzGP8gJmvqIer09mR77od1B+jMsDsKPN4wbyqUyMPIZZuvp\n\twSrJGRdod7Itm5JPPZBdMWe++FLFUNXe9+/MNw2MdL147gG04hDXsWfgjfFYzxksqJ\n\tn683wVuLgEhG19BMdmxqbUuPA8yDk2ESwEXVN4xmCipo50VinVkQ2ecoa5tGrPGP9e\n\t7axwtKTK4Zs42iuZN1cpYUYn0lEKUj1OYoSP83J219c8nO7IqRkCs7CQLhDb0MMMUH\n\t3p4n2r0pvNmAw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655974120;\n\tbh=foASl3Vj0AhR27/pjk0NCywovCtbkSx0uqkJI0qsdBU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tnK852ZpRx/eNLrSvHmPeRrzTmZsdoK9ecgN+w/UKnmmvpUAxbTaLglG/A2gWMJJO\n\tWH/BtcAEgKoSOWutbYJaK+w1kPaoQqCJh2dbiy/hW/azHFFe9+YxtfENqzboS/EzeQ\n\t2MY3KanpRHo1AFOv3IodF+MQ3HJFwmFpjG/eKKTY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tnK852Zp\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 17:48:32 +0900","To":"Laurent Pinchart ","Message-ID":"<20220623084832.GF3309559@pyrite.rasen.tech>","References":"<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>\n\t<20220620014305.26778-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220620014305.26778-11-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 10/12] ipa: rkisp1: Add IMX219\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]