[{"id":23536,"web_url":"https://patchwork.libcamera.org/comment/23536/","msgid":"<20220623084710.GE3309559@pyrite.rasen.tech>","date":"2022-06-23T08:47:10","subject":"Re: [libcamera-devel] [PATCH v4 08/12] ipa: rkisp1: Register\n\talgorithms","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Mon, Jun 20, 2022 at 04:43:01AM +0300, Laurent Pinchart wrote:\n> To prepare for dynamic instantiation of algorithms from the tuning file,\n> register the algorithms with the Module class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n> src/ipa/rkisp1/algorithms/blc.cpp | 2 ++\n> 3 files changed, 6 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 9a12e93ae4c7..6bfe4375b396 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -355,6 +355,8 @@ void Agc::prepare(IPAContext &context, rkisp1_params_cfg *params)\n> \tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_HST;\n> }\n> \n> +REGISTER_IPA_ALGORITHM(Agc)\n> +\n> } /* namespace ipa::rkisp1::algorithms */\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 884413828d1d..852d8559aa8a 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -175,6 +175,8 @@ void Awb::process([[maybe_unused]] IPAContext &context,\n> \t\t\t << \" and for blue: \" << context.frameContext.awb.gains.blue;\n> }\n> \n> +REGISTER_IPA_ALGORITHM(Awb)\n> +\n> } /* namespace ipa::rkisp1::algorithms */\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/algorithms/blc.cpp b/src/ipa/rkisp1/algorithms/blc.cpp\n> index 0c5948ff2c02..ea9611bd712e 100644\n> --- a/src/ipa/rkisp1/algorithms/blc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/blc.cpp\n> @@ -52,6 +52,8 @@ void BlackLevelCorrection::prepare(IPAContext &context,\n> \tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_BLS;\n> }\n> \n> +REGISTER_IPA_ALGORITHM(BlackLevelCorrection)\n> +\n> } /* namespace ipa::rkisp1::algorithms */\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4F62BE173\n\tfor ;\n\tThu, 23 Jun 2022 08:47:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3773960412;\n\tThu, 23 Jun 2022 10:47:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6343860412\n\tfor ;\n\tThu, 23 Jun 2022 10:47:18 +0200 (CEST)","from pyrite.rasen.tech (softbank114048060123.bbtec.net\n\t[114.48.60.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61533DD;\n\tThu, 23 Jun 2022 10:47:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655974040;\n\tbh=B1Kkmnwd52mDAYL30aitgGxss3ujhVKbFcuOTCYLdAs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gk/lFZoThNGg6R3eU9ahzE77rHmgB0mhkiGJg6rY0IqwrgFtIcXGsibTgLbVUStdz\n\tjRA5heji3UHf6XuDMKT/GbXZWhSg51UeK6r9Pp6m+5sJr2gIA3Ta44njraK7irkEV7\n\taz0bdn21OHCanrnmw/xmN58CljVGtjkR3prMW2Dr3UDuf+kBHKmMjI+bA52YLywH0q\n\tvpWrKETf/gWSf31V9lM6TB9RnZBCBOdlekzDy6weRI5fO5DgtnqdFv0qj/iZPrwTZe\n\t1OPH1+O27vLIzkVCltKFzpVmofVYuiufrF5I4dGbW+EI3vn5rf6CBHzPHlIMfBBtMA\n\t1BIt9XKecQXlA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655974037;\n\tbh=B1Kkmnwd52mDAYL30aitgGxss3ujhVKbFcuOTCYLdAs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RY5DN7QJhc6PRQvRKUN/VKfBtLuvcuzT8b3zSFmlKIs6qd3zcKajHMh4IIx85/mwP\n\tChHo8JAgu/xSl+qJjOcR7OJ7uB5+5P/bU7nNxTtVzPWoBQ4w5m6u+rPGRYpXqK9c9+\n\tBDTA25fXCbjrg8CW+Pas8MEV675LTt3enODiTvb0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RY5DN7QJ\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 17:47:10 +0900","To":"Laurent Pinchart ","Message-ID":"<20220623084710.GE3309559@pyrite.rasen.tech>","References":"<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>\n\t<20220620014305.26778-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220620014305.26778-9-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 08/12] ipa: rkisp1: Register\n\talgorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]