[{"id":23534,"web_url":"https://patchwork.libcamera.org/comment/23534/","msgid":"<20220623075104.GD3309559@pyrite.rasen.tech>","date":"2022-06-23T07:51:04","subject":"Re: [libcamera-devel] [PATCH v4 06/12] ipa: libipa: module: Make\n\tthe Module class Loggable","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Mon, Jun 20, 2022 at 04:42:59AM +0300, Laurent Pinchart wrote:\n> To help attribute messages logged by the Module class to a particular\n> IPA module, make the class loggable and add a name argument to its\n> constructor to specify the log prefix.\n\nWhere's the logPrefix? And the name argument to the constructor?\n\nPaul\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/module.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h\n> index 00d5785e1aa0..cd67912f1b0c 100644\n> --- a/src/ipa/libipa/module.h\n> +++ b/src/ipa/libipa/module.h\n> @@ -27,7 +27,7 @@ namespace ipa {\n> \n> template \t typename _Params, typename _Stats>\n> -class Module\n> +class Module : public Loggable\n> {\n> public:\n> \tusing Context = _Context;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 696EFBE173\n\tfor ;\n\tThu, 23 Jun 2022 07:51:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 952C765635;\n\tThu, 23 Jun 2022 09:51:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD8EE60412\n\tfor ;\n\tThu, 23 Jun 2022 09:51:12 +0200 (CEST)","from pyrite.rasen.tech (softbank114048060123.bbtec.net\n\t[114.48.60.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 184DE8F;\n\tThu, 23 Jun 2022 09:51:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655970673;\n\tbh=mQCgmfWxuNODQpeH6xuxj9oFbvhw/AzSkapqvB85qWo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0b5CurE6D1GsFQJSIZfzZPq006zNgh/iVOVCvjpDy55grjTsMDsudjoGF3gOZaSFx\n\tCjrJCHijk4j2OAIEBzpqDz/jFJG/q51vqnLBdYEktsdmrDW4oVT9RXCJ1VNoCvDoRL\n\tOkPT9yB1txVnZK42H0dWrW74Wgy2SJQf1QB1AGRq7JKf80tvjqZTvyQAcc3jwzuC/Z\n\tpNSGMe+9GOCDVErrRun3ZlQuZWwpxJEg/18hOxK+26JhhFyKrVB3CPR+vlkD8dzMSO\n\t+GLOaU3JGxSxRr4pNcMyTgsBC+KkSC4spI0w05UhxpwCqrC2G5uFBUWN0Q86BZcIeG\n\tq/ST55CmZ8e6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655970672;\n\tbh=mQCgmfWxuNODQpeH6xuxj9oFbvhw/AzSkapqvB85qWo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ccrs1MfGuOXtjdHdMstX2cefmXp+w8gsZItfNRmAML6SrTt48UlHJlPXPh4Q5uZ79\n\tLyip3oj0a8x/GKwUJz0zUfUOlh6CQT3vl0MfrFt5ca0NzYmXQg1mBZVZOUujLc/+iQ\n\tAfK6W6UhjqbdHNK1cbsit6u5H9aXTF4V+9TeDMFQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ccrs1MfG\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 16:51:04 +0900","To":"Laurent Pinchart ","Message-ID":"<20220623075104.GD3309559@pyrite.rasen.tech>","References":"<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>\n\t<20220620014305.26778-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220620014305.26778-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 06/12] ipa: libipa: module: Make\n\tthe Module class Loggable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23535,"web_url":"https://patchwork.libcamera.org/comment/23535/","msgid":"","date":"2022-06-23T08:11:33","subject":"Re: [libcamera-devel] [PATCH v4 06/12] ipa: libipa: module: Make\n\tthe Module class Loggable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Thu, Jun 23, 2022 at 04:51:04PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Laurent,\n> \n> On Mon, Jun 20, 2022 at 04:42:59AM +0300, Laurent Pinchart wrote:\n> > To help attribute messages logged by the Module class to a particular\n> > IPA module, make the class loggable and add a name argument to its\n> > constructor to specify the log prefix.\n> \n> Where's the logPrefix? And the name argument to the constructor?\n\nI forgot to update the commit message after changing the implementation,\noops.\n\nThe logPrefix() function is now implemented by the Module subclasses.\nI'll fix this in v5.\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/libipa/module.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h\n> > index 00d5785e1aa0..cd67912f1b0c 100644\n> > --- a/src/ipa/libipa/module.h\n> > +++ b/src/ipa/libipa/module.h\n> > @@ -27,7 +27,7 @@ namespace ipa {\n> > \n> > template > \t typename _Params, typename _Stats>\n> > -class Module\n> > +class Module : public Loggable\n> > {\n> > public:\n> > \tusing Context = _Context;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48FE2BD808\n\tfor ;\n\tThu, 23 Jun 2022 08:11:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A382D65637;\n\tThu, 23 Jun 2022 10:11:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4356C60412\n\tfor ;\n\tThu, 23 Jun 2022 10:11:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84F808F;\n\tThu, 23 Jun 2022 10:11:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655971910;\n\tbh=f46ZfEFbZIPL+MwRBPfYEr4VxMayg0W14C7WAXhZ2zI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YKHrfiZ/DzLT6OFkdBYu2pr0IKhVYDuKYtHafGeQTyJy+kzux4uBYnKHua0xyA+kM\n\tjyCpMLl5YBWiI6/nPMrd7edLm3yIgYIDJzjxXF/GmKOIQR0wtXOKZWoM82O9t5qx0o\n\tPWdC4Qx343eGDFQAndKmjbD6IXkPj0FtKAhz7KaJ0o5lR0x13+BA2T9Iz0b7MvMTuU\n\tNwNYsGWVG4s3q3RHNAg3eeAygaq7fqiFtkvofPgw3+OK3tlHvXKab3O9zeFE+GPAzw\n\trm64s12JF50xWSxdMP2pCoS6EbTtc+wS0QDf5f5kkef52sgPSCIZd2wke8OWDBhq9r\n\tyZsEQxN2L19yw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655971908;\n\tbh=f46ZfEFbZIPL+MwRBPfYEr4VxMayg0W14C7WAXhZ2zI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=msZHdpUO3+fLIAzbWLNVKpfqyZ6x8Ra3M2clm1buDMX5PwkKR1uZIXWbTRnlwhdoh\n\tIcXXha0808qiR9yNRhdFs0w3UTIa7uOK7yOPteTK6jN0tQ/ALQTOuL820zvuZFTcL6\n\t360m4n+AYu2rU1HxEU4K6XbmY+unkOgShje5NqQg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"msZHdpUO\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 11:11:33 +0300","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>\n\t<20220620014305.26778-7-laurent.pinchart@ideasonboard.com>\n\t<20220623075104.GD3309559@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220623075104.GD3309559@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v4 06/12] ipa: libipa: module: Make\n\tthe Module class Loggable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]