[{"id":23532,"web_url":"https://patchwork.libcamera.org/comment/23532/","msgid":"<20220623065041.GB3309559@pyrite.rasen.tech>","date":"2022-06-23T06:50:41","subject":"Re: [libcamera-devel] [PATCH v4 02/12] ipa: libipa: Move ipa\n\tnamespace documentation to module.cpp","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Mon, Jun 20, 2022 at 04:42:55AM +0300, Laurent Pinchart wrote:\n> The libipa.cpp file exists for the sole purpose of documentating the ipa\n> namespace. As we now have a top-level module.cpp file in libipa, move\n> the documentation there, and drop libipa.cpp.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/libipa.cpp | 22 ----------------------\n> src/ipa/libipa/meson.build | 1 -\n> src/ipa/libipa/module.cpp | 7 +++++++\n> 3 files changed, 7 insertions(+), 23 deletions(-)\n> delete mode 100644 src/ipa/libipa/libipa.cpp\n> \n> diff --git a/src/ipa/libipa/libipa.cpp b/src/ipa/libipa/libipa.cpp\n> deleted file mode 100644\n> index 08bc3541f4eb..000000000000\n> --- a/src/ipa/libipa/libipa.cpp\n> +++ /dev/null\n> @@ -1,22 +0,0 @@\n> -/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> -/*\n> - * Copyright (C) 2021, Ideas On Board\n> - *\n> - * libipa.cpp - libipa interface\n> - */\n> -\n> -namespace libcamera {\n> -\n> -/**\n> - * \\brief The IPA namespace\n> - *\n> - * The IPA namespace groups all types specific to IPA modules. It serves as the\n> - * top-level namespace for the IPA library libipa, and also contains\n> - * module-specific namespaces for IPA modules.\n> - */\n> -namespace ipa {\n> -\n> -} /* namespace ipa */\n> -\n> -} /* namespace libcamera */\n> -\n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 465cf7d6c4a7..fb894bc614af 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -11,7 +11,6 @@ libipa_sources = files([\n> 'algorithm.cpp',\n> 'camera_sensor_helper.cpp',\n> 'histogram.cpp',\n> - 'libipa.cpp',\n> 'module.cpp',\n> ])\n> \n> diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\n> index 5a6f49a80e6d..d03cc8ef03ed 100644\n> --- a/src/ipa/libipa/module.cpp\n> +++ b/src/ipa/libipa/module.cpp\n> @@ -14,6 +14,13 @@\n> \n> namespace libcamera {\n> \n> +/**\n> + * \\brief The IPA namespace\n> + *\n> + * The IPA namespace groups all types specific to IPA modules. It serves as the\n> + * top-level namespace for the IPA library libipa, and also contains\n> + * module-specific namespaces for IPA modules.\n> + */\n> namespace ipa {\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15EDABE173\n\tfor ;\n\tThu, 23 Jun 2022 06:50:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0CFD65635;\n\tThu, 23 Jun 2022 08:50:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCEBA6059B\n\tfor ;\n\tThu, 23 Jun 2022 08:50:50 +0200 (CEST)","from pyrite.rasen.tech (softbank114048060123.bbtec.net\n\t[114.48.60.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA0CD8F;\n\tThu, 23 Jun 2022 08:50:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655967053;\n\tbh=xEDgF51ELu9cRoLyJkJyFANitg6Nh6Kkx2mfVZDx94s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JlCvdVcjTBnLkPeJa3N3+6jPLXv8AWnphTWvgl6ylEIFwIfA+Ck5j4xdsHApouMDO\n\tcCRlR21XXmSabHd5PTxXWOhjQkG7EQcSRRn3Bhry11nKd245zbwtx3CeWLHoG6CQuv\n\tQkObRhT7Ttv9dD2xKbG3U6NLVyaMK2qN3U2nrd64QX3sMyix6S6WUevZAPGvT6Jvgf\n\tyre2eRf3pho1MYoGOeHVdpSshZkAlVotdV06qty3njxFWFre+77lU1Loc0BGUNUd3h\n\tBRG7hH8fXky600wXSr2QvkRs8ZYbEnP3xOQlibgLeP736Z82aQ9q9AYODIn2LcswV/\n\trC05r2jDItm5A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655967050;\n\tbh=xEDgF51ELu9cRoLyJkJyFANitg6Nh6Kkx2mfVZDx94s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EZR+aV2UQBM+4qQ00LbRd2pqEJDs7M6EHDzJBkiAiYUd9LkgWih8fxPVCcQebOpbv\n\tfxsDzlVImoyDYkOy1dxaLsr8VNHHL80oWHOB2yHU/stg6VUe4oe1VJspJY6uOLooI8\n\tCN7W8v+6iIIQXe/rf+Z5Ed7IzRa7ra9L1XJogjms="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EZR+aV2U\"; dkim-atps=neutral","Date":"Thu, 23 Jun 2022 15:50:41 +0900","To":"Laurent Pinchart ","Message-ID":"<20220623065041.GB3309559@pyrite.rasen.tech>","References":"<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>\n\t<20220620014305.26778-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220620014305.26778-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 02/12] ipa: libipa: Move ipa\n\tnamespace documentation to module.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]