[{"id":23459,"web_url":"https://patchwork.libcamera.org/comment/23459/","msgid":"","date":"2022-06-17T14:51:12","subject":"Re: [libcamera-devel] [PATCH v2 1/3] Documentation: Add the missing\n\tconst to the example code","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Daniel,\n\nThank you for the patch.\n\nOn Fri, Jun 17, 2022 at 04:35:47PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> Request::BufferMap key type is now const\n> \n> Signed-off-by: Daniel Semkowicz \n> ---\n> Documentation/guides/application-developer.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 8d12a208..6ab8b7e5 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -410,7 +410,7 @@ images.\n> \n> .. code:: cpp\n> \n> - const std::map &buffers = request->buffers();\n> + const std::map &buffers = request->buffers();\n> \n> Iterating through the map allows applications to inspect each completed buffer\n> in this request, and access the metadata associated to each frame.\n> @@ -518,7 +518,7 @@ and queue all the previously created requests.\n> \n> camera->start();\n> for (std::unique_ptr &request : requests)\n> - camera->queueRequest(request.get());\n> + camera->queueRequest(request.get());\n\nThis change is unrelated. If that's the only issue in the series, no\nneed to resubmit, I can fix it when applying the patch.\n\nWith this fixed,\n\nReviewed-by: Laurent Pinchart \n\n> \n> Start an event loop\n> ~~~~~~~~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 352B1BD808\n\tfor ;\n\tFri, 17 Jun 2022 14:51:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8827165635;\n\tFri, 17 Jun 2022 16:51:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 556E165632\n\tfor ;\n\tFri, 17 Jun 2022 16:51:25 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4BA7741;\n\tFri, 17 Jun 2022 16:51:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655477486;\n\tbh=OIQkWpqiSzlVo8K/lPnuSg0hLIaUDdUDVEj1brD0+/U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rXtgSa7sFCoy5ncV8Yi68NoRaDsDF9Qte5DON5an0uiHgAhUdumz3WQTZ3dhEEm4n\n\t8AIl+QextmisRHo4LPfQY1SFTqszvp7qv41q66V8bqWOUYnjUTfQB1a16ebANrCper\n\tn5LKN2KWdmytlKc88lYyh3Kcx/TUXu5QA2JYquHYaWpwheEkB4CC5V4dF2FjOxttQ6\n\tOCGCZ2ycGA8PFCg/u2E620cuCWnAV9lIzh7LTctgqHQ8R8Kkeky0Mrk1SwhJ1abYgh\n\ty+LkIvE+i0s4HL/Uv4918HT52I+2fRWv2/Fz0sVOYtncFplvlKI2+ficYbiSftXubL\n\tg95W0f7q0/AnA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655477485;\n\tbh=OIQkWpqiSzlVo8K/lPnuSg0hLIaUDdUDVEj1brD0+/U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KisnPsCL2tukDpN1RcMJU4tXSR2hvpZZfrZbQPWT5JCpzwZGyWzj2N7CbdchXGV6G\n\tOg4zsDC9LNaiM88YYNR9rLrHWctsggGaGEViiIcwLaMLHrulxN3Ng1qEQbG5cw25Ij\n\t5KkrnyTqPGz4+fp0bXg2OqZ82QNUtywbR2P+FI5k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KisnPsCL\"; dkim-atps=neutral","Date":"Fri, 17 Jun 2022 17:51:12 +0300","To":"Daniel Semkowicz ","Message-ID":"","References":"<20220617143549.35442-1-dse@thaumatec.com>\n\t<20220617143549.35442-2-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220617143549.35442-2-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] Documentation: Add the missing\n\tconst to the example code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]