[{"id":23466,"web_url":"https://patchwork.libcamera.org/comment/23466/","msgid":"","date":"2022-06-17T17:27:21","subject":"Re: [libcamera-devel] [PATCH v3 4/5] ipa: rkisp1: Add ov5640 tuning\n\tfile","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Florian,\n\nThank you for the patch.\n\nOn Fri, Jun 17, 2022 at 11:23:14AM +0200, Florian Sylvestre wrote:\n> Add the ov5640 tuning file containing default values for 'black level\n> correction' algorithm.\n> \n> Signed-off-by: Florian Sylvestre \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Paul Elder \n> ---\n> src/ipa/rkisp1/data/meson.build | 8 ++++++++\n> src/ipa/rkisp1/data/ov5640.yaml | 10 ++++++++++\n> src/ipa/rkisp1/meson.build | 1 +\n> 3 files changed, 19 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/meson.build\n> create mode 100644 src/ipa/rkisp1/data/ov5640.yaml\n> \n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> new file mode 100644\n> index 00000000..2656bb2e\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +conf_files = files([\n> + 'ov5640.yaml',\n> +])\n> +\n> +install_data(conf_files,\n> + install_dir : ipa_data_dir / 'rkisp1')\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> new file mode 100644\n> index 00000000..c4eda49b\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -0,0 +1,10 @@\n> +# SPDX-License-Identifier: CC0-1.0\n\n%YAML 1.2\n\n> +---\n> +version: 1\n> +algorithms:\n> + - BlackLevelCorrection:\n> + R: 256\n\nYou need one more indentation level here:\n\nalgorithms:\n - BlackLevelCorrection:\n R: 256\n\nOtherwise the data would translate (in JSON form) to\n\n{\n \"version\": 1,\n \"algorithms\": [\n {\n\t \"BlackLevelCorrection\": \"\",\n\t \"R\": 256,\n\t \"Gr\": 256,\n\t \"Gb\": 256,\n\t \"B\": 256,\n\t}\n ]\n}\n\nwhile the correct structure is\n\n{\n \"version\": 1,\n \"algorithms\": [\n {\n\t \"BlackLevelCorrection\": {\n\t \"R\": 256,\n\t \"Gr\": 256,\n\t \"Gb\": 256,\n\t \"B\": 256,\n\t }\n\t}\n ]\n}\n\n> + Gr: 256\n> + Gb: 256\n> + B: 256\n> +...\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index 8c822fbb..ccb84b27 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> subdir('algorithms')\n> +subdir('data')\n> \n> ipa_name = 'ipa_rkisp1'\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0673BD161\n\tfor ;\n\tFri, 17 Jun 2022 17:27:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECA5365635;\n\tFri, 17 Jun 2022 19:27:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E61565632\n\tfor ;\n\tFri, 17 Jun 2022 19:27:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F1BC982;\n\tFri, 17 Jun 2022 19:27:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655486855;\n\tbh=62HaOw0Qgsdocf/kIGo9E88E2p25Cd4uRBth7oVJLw0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LFEin2jupxPE1drPEyreHf1Sa3hfYB/1udFw788UxeSXDO0ABQKujTGx0pRi/rBkf\n\t+rBKlv9CG5GoTZP2gZOzmfC+sZTK30n3aEAcJ77FPQhv84gBGWMdPGBM5KAZdnNUCE\n\tFd85m4+lP2oLp6aUytsCVOArxLdtt2CmXKUEZlJg2/HUTYhcw6oAj6pjWoGqTRjXGA\n\t10rPkkU8MEeo5OM6JI3I5jXRuJfKtBInvzyDjmG7gabYjLfsxV8prnCGLQYjEhR6FG\n\tFothNO8Zf4Xfrgg4OJKkHUmWeIsnA3FZBBKaaNITJ/qbLUW1fkdr1wthWmrJmiGugN\n\t2JrKMBejvQyfQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655486853;\n\tbh=62HaOw0Qgsdocf/kIGo9E88E2p25Cd4uRBth7oVJLw0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C4jqb/KU1MNUizuR3NPVhqYQE+4svyto7nv1naQ992u83BV1sF2ZN2RUwpelS9MAd\n\tVLrb5n5H6fEKNFVWIGKWk2kCgXlOqX13B4BfApgYDH34DfstE5f5TzfUFCvJ/9SsEj\n\tMGU45bdlQtb1eC8iz0A3D2sF/aGzBaHs98ftYihQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"C4jqb/KU\"; dkim-atps=neutral","Date":"Fri, 17 Jun 2022 20:27:21 +0300","To":"Florian Sylvestre ","Message-ID":"","References":"<20220617092315.120781-1-fsylvestre@baylibre.com>\n\t<20220617092315.120781-5-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220617092315.120781-5-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] ipa: rkisp1: Add ov5640 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]