[{"id":23465,"web_url":"https://patchwork.libcamera.org/comment/23465/","msgid":"","date":"2022-06-17T17:19:47","subject":"Re: [libcamera-devel] [PATCH v3 1/5] pipeline: rkisp1: Support IPA\n\ttuning file","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Florian,\n\nThank you for the patch.\n\nOn Fri, Jun 17, 2022 at 11:23:11AM +0200, Florian Sylvestre wrote:\n> Allow the usage of a YAML IPA tuning file that is either defined by\n> the sensor name (sensor_name.yaml) or defined by\n> LIBCAMERA_RKISP1_TUNING_FILE environment variable.\n> \n> Signed-off-by: Florian Sylvestre \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Paul Elder \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++++++-\n> 1 file changed, 12 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 4b3d2cf7..59ded513 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -322,7 +322,18 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n> \tipa_->paramsBufferReady.connect(this, &RkISP1CameraData::paramFilled);\n> \tipa_->metadataReady.connect(this, &RkISP1CameraData::metadataReady);\n> \n> -\tint ret = ipa_->init(IPASettings{ \"\", sensor_->model() }, hwRevision);\n> +\t/*\n> +\t * The API tuning file is made from the sensor name unless\n> +\t * the environment variable overrides it.\n> +\t */\n> +\tstd::string ipaTunigFile;\n\ns/ipaTunigFile/ipaTuningFile/\n\n> +\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n> +\tif (!configFromEnv || *configFromEnv == '\\0')\n> +\t\tipaTunigFile = ipa_->configurationFile(sensor_->model() + \".yaml\");\n> +\telse\n> +\t\tipaTunigFile = std::string(configFromEnv);\n> +\n> +\tint ret = ipa_->init({ ipaTunigFile, sensor_->model() }, hwRevision);\n> \tif (ret < 0) {\n> \t\tLOG(RkISP1, Error) << \"IPA initialization failure\";\n> \t\treturn ret;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 199D8BD808\n\tfor ;\n\tFri, 17 Jun 2022 17:20:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01B5565633;\n\tFri, 17 Jun 2022 19:20:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BE0B65632\n\tfor ;\n\tFri, 17 Jun 2022 19:19:59 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E708A982;\n\tFri, 17 Jun 2022 19:19:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655486401;\n\tbh=SazO7N+tdtWVUnw+F+8igoVT7w1VmkxkLXH4qvF3n9c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wwo5upxQRn/o0ynLJCOsTu6efASY7/4zXqbpsM/GoqSwX74JCwl3iNMlnS96V6GyS\n\tyUIhaqN3lEeH+VOYXXAssMm/KC4UFh3hiqU6nKwnBzAT9HQBZv3WdMYpmhQ+JwyuVy\n\tTfLegsBcxMD41UKi5qUsdq52eDE+tPRdv3rFhOfnzTjTRL9MCy5XC235xwDRsy65Ye\n\tI6rYoENcNmE8Wre3XURK40IjblVHIJDmoqym3/qbylbjDdLwlpHBRed60LTNa6zqZN\n\tDRr1l5xFku6w6oGEGvuxGzxQtf9qUhvkRoXX1Vh+HIWbJ6Yrpj9rEEfjdJCEuW44JI\n\tZiSLcA+EwVsYQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655486399;\n\tbh=SazO7N+tdtWVUnw+F+8igoVT7w1VmkxkLXH4qvF3n9c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B3aSxPA2YgrLj0kDgKxxf13+szR5RMvDuSWjiQHvZtBca+SgKzluzmEBFFkTbyK/M\n\tDt02fT9PjUyjf8/U7Oh3xLx6JzGrEjKkBX8VYRfRz6k1C7i1AuyelRp1eYDQ3M5xcQ\n\tuD5AFECAgXzHf8hso3BpnXV+s74/t/8BGv6RFfZs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"B3aSxPA2\"; dkim-atps=neutral","Date":"Fri, 17 Jun 2022 20:19:47 +0300","To":"Florian Sylvestre ","Message-ID":"","References":"<20220617092315.120781-1-fsylvestre@baylibre.com>\n\t<20220617092315.120781-2-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220617092315.120781-2-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/5] pipeline: rkisp1: Support IPA\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]