[{"id":2181,"web_url":"https://patchwork.libcamera.org/comment/2181/","msgid":"<20190706114744.GN17685@bigcity.dyn.berto.se>","date":"2019-07-06T11:47:44","subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: Rename\n\tPipelineHandler::allocateBuffers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-07-05 00:53:29 +0200, Jacopo Mondi wrote:\n> Now that the pipeline handlers can inspect the Stream's memory type flag\n> the allocateBuffers() operation name does not match the actual operation\n> purpose, which is to setup buffers to export memory to application or\n> either prepare to use externally allocated buffers.\n> \n> Todo: rename the camera operation as well?\n\nI think you should, and it could be squashed in this commit (I'm as \nsurprised as you, I'm not pushing for renames to be in two separate \ncommits :-)\n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/camera.cpp | 2 +-\n> src/libcamera/include/pipeline_handler.h | 4 ++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++----\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++---\n> src/libcamera/pipeline/uvcvideo.cpp | 8 ++++----\n> src/libcamera/pipeline/vimc.cpp | 8 ++++----\n> src/libcamera/pipeline_handler.cpp | 6 ++++--\n> 7 files changed, 22 insertions(+), 20 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 5f756d41744a..f3f01d040ecf 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -716,7 +716,7 @@ int Camera::allocateBuffers()\n> \t\treturn -EINVAL;\n> \t}\n> \n> -\tint ret = pipe_->allocateBuffers(this, activeStreams_);\n> +\tint ret = pipe_->setupBuffers(this, activeStreams_);\n> \tif (ret) {\n> \t\tLOG(Camera, Error) << \"Failed to allocate buffers\";\n> \t\treturn ret;\n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index f836d5d1a600..c40d108eb13c 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -68,8 +68,8 @@ public:\n> \t\tconst StreamRoles &roles) = 0;\n> \tvirtual int configure(Camera *camera, CameraConfiguration *config) = 0;\n> \n> -\tvirtual int allocateBuffers(Camera *camera,\n> -\t\t\t\t const std::set &streams) = 0;\n> +\tvirtual int setupBuffers(Camera *camera,\n> +\t\t\t\t const std::set &streams) = 0;\n> \tvirtual int freeBuffers(Camera *camera,\n> \t\t\t\tconst std::set &streams) = 0;\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 6f14da1f8c70..28dcefe3d19f 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -208,8 +208,8 @@ public:\n> \t\tconst StreamRoles &roles) override;\n> \tint configure(Camera *camera, CameraConfiguration *config) override;\n> \n> -\tint allocateBuffers(Camera *camera,\n> -\t\t\t const std::set &streams) override;\n> +\tint setupBuffers(Camera *camera,\n> +\t\t\t const std::set &streams) override;\n> \tint freeBuffers(Camera *camera,\n> \t\t\tconst std::set &streams) override;\n> \n> @@ -589,8 +589,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> * In order to be able to start the 'viewfinder' and 'stat' nodes, we need\n> * memory to be reserved.\n> */\n> -int PipelineHandlerIPU3::allocateBuffers(Camera *camera,\n> -\t\t\t\t\t const std::set &streams)\n> +int PipelineHandlerIPU3::setupBuffers(Camera *camera,\n> +\t\t\t\t const std::set &streams)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> \tIPU3Stream *outStream = &data->outStream_;\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index dbb61a21354d..836de1f61630 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -80,7 +80,7 @@ public:\n> \t\tconst StreamRoles &roles) override;\n> \tint configure(Camera *camera, CameraConfiguration *config) override;\n> \n> -\tint allocateBuffers(Camera *camera,\n> +\tint setupBuffers(Camera *camera,\n> \t\tconst std::set &streams) override;\n> \tint freeBuffers(Camera *camera,\n> \t\tconst std::set &streams) override;\n> @@ -315,8 +315,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \treturn 0;\n> }\n> \n> -int PipelineHandlerRkISP1::allocateBuffers(Camera *camera,\n> -\t\t\t\t\t const std::set &streams)\n> +int PipelineHandlerRkISP1::setupBuffers(Camera *camera,\n> +\t\t\t\t\tconst std::set &streams)\n> {\n> \tStream *stream = *streams.begin();\n> \tint ret;\n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index 5b3c79dda6dd..bba4e7f8d2a0 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -63,8 +63,8 @@ public:\n> \t\tconst StreamRoles &roles) override;\n> \tint configure(Camera *camera, CameraConfiguration *config) override;\n> \n> -\tint allocateBuffers(Camera *camera,\n> -\t\t\t const std::set &streams) override;\n> +\tint setupBuffers(Camera *camera,\n> +\t\t\t const std::set &streams) override;\n> \tint freeBuffers(Camera *camera,\n> \t\t\tconst std::set &streams) override;\n> \n> @@ -191,8 +191,8 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n> \treturn 0;\n> }\n> \n> -int PipelineHandlerUVC::allocateBuffers(Camera *camera,\n> -\t\t\t\t\tconst std::set &streams)\n> +int PipelineHandlerUVC::setupBuffers(Camera *camera,\n> +\t\t\t\t const std::set &streams)\n> {\n> \tUVCCameraData *data = cameraData(camera);\n> \tStream *stream = *streams.begin();\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index c67bdb0ecbff..3e08768b670f 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -70,8 +70,8 @@ public:\n> \t\tconst StreamRoles &roles) override;\n> \tint configure(Camera *camera, CameraConfiguration *config) override;\n> \n> -\tint allocateBuffers(Camera *camera,\n> -\t\t\t const std::set &streams) override;\n> +\tint setupBuffers(Camera *camera,\n> +\t\t\t const std::set &streams) override;\n> \tint freeBuffers(Camera *camera,\n> \t\t\tconst std::set &streams) override;\n> \n> @@ -193,8 +193,8 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \treturn 0;\n> }\n> \n> -int PipelineHandlerVimc::allocateBuffers(Camera *camera,\n> -\t\t\t\t\t const std::set &streams)\n> +int PipelineHandlerVimc::setupBuffers(Camera *camera,\n> +\t\t\t\t const std::set &streams)\n> {\n> \tVimcCameraData *data = cameraData(camera);\n> \tStream *stream = *streams.begin();\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 0283e4e5ad51..67b215483847 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -280,11 +280,13 @@ const ControlInfoMap &PipelineHandler::controls(Camera *camera)\n> */\n> \n> /**\n> - * \\fn PipelineHandler::allocateBuffers()\n> - * \\brief Allocate buffers for a stream\n> + * \\fn PipelineHandler::setupBuffers()\n> + * \\brief Setup buffer for a stream\n> * \\param[in] camera The camera the \\a stream belongs to\n> * \\param[in] streams The set of streams to allocate buffers for\n> *\n> + * \\todo Change this to describe both allocation and importing\n> + *\n> * This method allocates buffers internally in the pipeline handler for each\n> * stream in the \\a streams buffer set, and associates them with the stream's\n> * buffer pool.\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E7EF61568\n\tfor ;\n\tSat, 6 Jul 2019 13:47:45 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id k18so11557345ljc.11\n\tfor ;\n\tSat, 06 Jul 2019 04:47:45 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\tq2sm1800673lfj.25.2019.07.06.04.47.44\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tSat, 06 Jul 2019 04:47:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=G/5hp7gqcT2KItWOmtZ4cf5Xk9/+LRr5GDzWxokIAbU=;\n\tb=ZuMshOpPyx1QFkAkV6w1tV47BLT8rPIrpNeszhtxG2wx24XS+YDufNK//PbvVL058a\n\t0PxqMwUquiN4Undtfso0b1Pdf01uZJXTs1/nr9ARI27Dw1SeEUgOFhVIlC0xKcpJmMCD\n\tGWVAEN0e0r68qRaiPSNseOjT1B4+TjbC2przAmKg10NCtXpsiSLsrjLPe4WHn9uXaKfl\n\t+ltygk8tXCNKIt4wf5aqGrEeG3/+e1KSatQTlRg+n/MIS2BoNEEHu0mfbMJuppa7zidG\n\t2Mo6VBeziML7bKAh8VFMaPwn+FVVfGGBFw8CXIxPjmBuhVIqckpZNM43dDWa1ljxMz3Y\n\thzug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=G/5hp7gqcT2KItWOmtZ4cf5Xk9/+LRr5GDzWxokIAbU=;\n\tb=JMU8mkCBm2O2A+b33MNRHqyaY5lYzx5x3fszgEvI8a50s0Cne3fJ53rCHzpB5dCpKS\n\tBXIhW9NwaOz5UIgX/rN6bDtoaoDa1hf2equm+f8bKDTiG42zYddgPE3DeFmB08jfPb8V\n\tmQMxXyrtDHnx359dieOejJb6Takg8ASYvtOlubh1VrU46oDJQNz07Oc2FQm1c+fmhR/T\n\t8eRfWYjTql05nlevne9FxlHT7O44uk8EpBQpw+k/j7P+0TPuRMyhXdyXtKYtf5Rkyso0\n\tH9jpV4a7Ym5I2N3Gyci98KtU0QYBBvJhSzEwoo3R7UTl9c9RHn02gZtDW8twDEkre5Cu\n\ttgiA==","X-Gm-Message-State":"APjAAAXjuAMqE57xyjAMqoOI0juMflLfMRrLZWeoYIAk50ToeoI1/STP\n\tXWB0mG/Xk1NNyMiP31toTyhB0Pow92Y=","X-Google-Smtp-Source":"APXvYqw4RxToTJUrvqVnyU0kSGCP0a4wfyWSc3nMyPX+Z+1cl7NX8xdnTQPOnFYy6qHM8720+3yywQ==","X-Received":"by 2002:a05:651c:95:: with SMTP id\n\t21mr4912476ljq.128.1562413664883; \n\tSat, 06 Jul 2019 04:47:44 -0700 (PDT)","Date":"Sat, 6 Jul 2019 13:47:44 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190706114744.GN17685@bigcity.dyn.berto.se>","References":"<20190704225334.26170-1-jacopo@jmondi.org>\n\t<20190704225334.26170-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190704225334.26170-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: Rename\n\tPipelineHandler::allocateBuffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 06 Jul 2019 11:47:45 -0000"}},{"id":2189,"web_url":"https://patchwork.libcamera.org/comment/2189/","msgid":"","date":"2019-07-08T10:22:35","subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: Rename\n\tPipelineHandler::allocateBuffers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 06/07/2019 12:47, Niklas Söderlund wrote:\n> Hi Jacopo,\n> \n> Thanks for your work.\n> \n> On 2019-07-05 00:53:29 +0200, Jacopo Mondi wrote:\n>> Now that the pipeline handlers can inspect the Stream's memory type flag\n>> the allocateBuffers() operation name does not match the actual operation\n>> purpose, which is to setup buffers to export memory to application or\n>> either prepare to use externally allocated buffers.\n>>\n>> Todo: rename the camera operation as well?\n> \n> I think you should, and it could be squashed in this commit (I'm as \n> surprised as you, I'm not pushing for renames to be in two separate \n> commits :-)\n\n\nIf there is actions to take when using external buffers, then yes, this\nshould be renamed.\n\nThinking about it - yes of course there will be other/internal buffer\npools to allocate and manage - so it should still be in the call graph\nfor external buffers.\n\nAt which point, I think setupBuffers() might well be appropriate naming yes.\n\nAnd I agree the camera::allocateBuffers() could be renamed too.\n\n\n\n>>\n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/libcamera/camera.cpp | 2 +-\n>> src/libcamera/include/pipeline_handler.h | 4 ++--\n>> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++----\n>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++---\n>> src/libcamera/pipeline/uvcvideo.cpp | 8 ++++----\n>> src/libcamera/pipeline/vimc.cpp | 8 ++++----\n>> src/libcamera/pipeline_handler.cpp | 6 ++++--\n>> 7 files changed, 22 insertions(+), 20 deletions(-)\n>>\n>> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n>> index 5f756d41744a..f3f01d040ecf 100644\n>> --- a/src/libcamera/camera.cpp\n>> +++ b/src/libcamera/camera.cpp\n>> @@ -716,7 +716,7 @@ int Camera::allocateBuffers()\n>> \t\treturn -EINVAL;\n>> \t}\n>> \n>> -\tint ret = pipe_->allocateBuffers(this, activeStreams_);\n>> +\tint ret = pipe_->setupBuffers(this, activeStreams_);\n>> \tif (ret) {\n>> \t\tLOG(Camera, Error) << \"Failed to allocate buffers\";\n>> \t\treturn ret;\n>> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n>> index f836d5d1a600..c40d108eb13c 100644\n>> --- a/src/libcamera/include/pipeline_handler.h\n>> +++ b/src/libcamera/include/pipeline_handler.h\n>> @@ -68,8 +68,8 @@ public:\n>> \t\tconst StreamRoles &roles) = 0;\n>> \tvirtual int configure(Camera *camera, CameraConfiguration *config) = 0;\n>> \n>> -\tvirtual int allocateBuffers(Camera *camera,\n>> -\t\t\t\t const std::set &streams) = 0;\n>> +\tvirtual int setupBuffers(Camera *camera,\n>> +\t\t\t\t const std::set &streams) = 0;\n>> \tvirtual int freeBuffers(Camera *camera,\n>> \t\t\t\tconst std::set &streams) = 0;\n>> \n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index 6f14da1f8c70..28dcefe3d19f 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -208,8 +208,8 @@ public:\n>> \t\tconst StreamRoles &roles) override;\n>> \tint configure(Camera *camera, CameraConfiguration *config) override;\n>> \n>> -\tint allocateBuffers(Camera *camera,\n>> -\t\t\t const std::set &streams) override;\n>> +\tint setupBuffers(Camera *camera,\n>> +\t\t\t const std::set &streams) override;\n>> \tint freeBuffers(Camera *camera,\n>> \t\t\tconst std::set &streams) override;\n>> \n>> @@ -589,8 +589,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>> * In order to be able to start the 'viewfinder' and 'stat' nodes, we need\n>> * memory to be reserved.\n>> */\n>> -int PipelineHandlerIPU3::allocateBuffers(Camera *camera,\n>> -\t\t\t\t\t const std::set &streams)\n>> +int PipelineHandlerIPU3::setupBuffers(Camera *camera,\n>> +\t\t\t\t const std::set &streams)\n>> {\n>> \tIPU3CameraData *data = cameraData(camera);\n>> \tIPU3Stream *outStream = &data->outStream_;\n>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> index dbb61a21354d..836de1f61630 100644\n>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> @@ -80,7 +80,7 @@ public:\n>> \t\tconst StreamRoles &roles) override;\n>> \tint configure(Camera *camera, CameraConfiguration *config) override;\n>> \n>> -\tint allocateBuffers(Camera *camera,\n>> +\tint setupBuffers(Camera *camera,\n>> \t\tconst std::set &streams) override;\n>> \tint freeBuffers(Camera *camera,\n>> \t\tconst std::set &streams) override;\n>> @@ -315,8 +315,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>> \treturn 0;\n>> }\n>> \n>> -int PipelineHandlerRkISP1::allocateBuffers(Camera *camera,\n>> -\t\t\t\t\t const std::set &streams)\n>> +int PipelineHandlerRkISP1::setupBuffers(Camera *camera,\n>> +\t\t\t\t\tconst std::set &streams)\n>> {\n>> \tStream *stream = *streams.begin();\n>> \tint ret;\n>> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n>> index 5b3c79dda6dd..bba4e7f8d2a0 100644\n>> --- a/src/libcamera/pipeline/uvcvideo.cpp\n>> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n>> @@ -63,8 +63,8 @@ public:\n>> \t\tconst StreamRoles &roles) override;\n>> \tint configure(Camera *camera, CameraConfiguration *config) override;\n>> \n>> -\tint allocateBuffers(Camera *camera,\n>> -\t\t\t const std::set &streams) override;\n>> +\tint setupBuffers(Camera *camera,\n>> +\t\t\t const std::set &streams) override;\n>> \tint freeBuffers(Camera *camera,\n>> \t\t\tconst std::set &streams) override;\n>> \n>> @@ -191,8 +191,8 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n>> \treturn 0;\n>> }\n>> \n>> -int PipelineHandlerUVC::allocateBuffers(Camera *camera,\n>> -\t\t\t\t\tconst std::set &streams)\n>> +int PipelineHandlerUVC::setupBuffers(Camera *camera,\n>> +\t\t\t\t const std::set &streams)\n>> {\n>> \tUVCCameraData *data = cameraData(camera);\n>> \tStream *stream = *streams.begin();\n>> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n>> index c67bdb0ecbff..3e08768b670f 100644\n>> --- a/src/libcamera/pipeline/vimc.cpp\n>> +++ b/src/libcamera/pipeline/vimc.cpp\n>> @@ -70,8 +70,8 @@ public:\n>> \t\tconst StreamRoles &roles) override;\n>> \tint configure(Camera *camera, CameraConfiguration *config) override;\n>> \n>> -\tint allocateBuffers(Camera *camera,\n>> -\t\t\t const std::set &streams) override;\n>> +\tint setupBuffers(Camera *camera,\n>> +\t\t\t const std::set &streams) override;\n>> \tint freeBuffers(Camera *camera,\n>> \t\t\tconst std::set &streams) override;\n>> \n>> @@ -193,8 +193,8 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n>> \treturn 0;\n>> }\n>> \n>> -int PipelineHandlerVimc::allocateBuffers(Camera *camera,\n>> -\t\t\t\t\t const std::set &streams)\n>> +int PipelineHandlerVimc::setupBuffers(Camera *camera,\n>> +\t\t\t\t const std::set &streams)\n>> {\n>> \tVimcCameraData *data = cameraData(camera);\n>> \tStream *stream = *streams.begin();\n>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n>> index 0283e4e5ad51..67b215483847 100644\n>> --- a/src/libcamera/pipeline_handler.cpp\n>> +++ b/src/libcamera/pipeline_handler.cpp\n>> @@ -280,11 +280,13 @@ const ControlInfoMap &PipelineHandler::controls(Camera *camera)\n>> */\n>> \n>> /**\n>> - * \\fn PipelineHandler::allocateBuffers()\n>> - * \\brief Allocate buffers for a stream\n>> + * \\fn PipelineHandler::setupBuffers()\n>> + * \\brief Setup buffer for a stream\n>> * \\param[in] camera The camera the \\a stream belongs to\n>> * \\param[in] streams The set of streams to allocate buffers for\n>> *\n>> + * \\todo Change this to describe both allocation and importing\n>> + *\n\n\nI agree, and that would block an RB tag I think here.\n\nBut the rename is appropriate, I think.\n\nThe documentation update will depend on what action is actually\nnecessary for importing buffers at this point in the API sequence...\n\n\n>> * This method allocates buffers internally in the pipeline handler for each\n>> * stream in the \\a streams buffer set, and associates them with the stream's\n>> * buffer pool.\n>> -- \n>> 2.21.0\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 958BF60C1C\n\tfor ;\n\tMon, 8 Jul 2019 12:22:38 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1B0656A;\n\tMon, 8 Jul 2019 12:22:37 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562581358;\n\tbh=t9VphLE60ZTYSpoLbSu0qtmJjiSNFOpWUR+KHLHCeb8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=hRFxQjgtHQyses0RDRgopY1nve9I/lsqfY1OokOIiKTR68kiTpRkc1x0+VA37RhFb\n\tmObiGqSloh9OucGokqOr73+sD43vZENJx6hf+bFC+UvZ5LI7YQvLHN++i42SCmAiEl\n\tJOpiv0H0nJfpfUBmpace2FzrVAewlixthuyloMho=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tJacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20190704225334.26170-1-jacopo@jmondi.org>\n\t<20190704225334.26170-5-jacopo@jmondi.org>\n\t<20190706114744.GN17685@bigcity.dyn.berto.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 8 Jul 2019 11:22:35 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.1","MIME-Version":"1.0","In-Reply-To":"<20190706114744.GN17685@bigcity.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: Rename\n\tPipelineHandler::allocateBuffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 08 Jul 2019 10:22:38 -0000"}}]