[{"id":23449,"web_url":"https://patchwork.libcamera.org/comment/23449/","msgid":"<20220617134834.vmzvt2qsns3iwgq2@uno.localdomain>","date":"2022-06-17T13:48:34","subject":"Re: [libcamera-devel] [PATCH 4/7] android: Use the YamlObject\n\titerator API","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Jun 16, 2022 at 05:24:00PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Replace usage of YamlObject::memberNames() with the more efficient\n> iterator API.\n>\n> Signed-off-by: Laurent Pinchart \n\nNicer indeed. partially answers my \"are both dict and list\" necessary\nquestion.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_hal_config.cpp | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index ac484b8df1bd..bacfe4b9c505 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -82,10 +82,8 @@ int CameraHalConfig::Private::parseConfigFile(File &file,\n> \tif (!yamlObjectCameras.isDictionary())\n> \t\treturn -EINVAL;\n>\n> -\tstd::vector cameraIds = yamlObjectCameras.memberNames();\n> -\tfor (const std::string &cameraId : cameraIds) {\n> -\t\tif (parseCameraConfigData(cameraId,\n> -\t\t\t\t\t yamlObjectCameras[cameraId]))\n> +\tfor (const auto &[cameraId, configData] : yamlObjectCameras.asDict()) {\n> +\t\tif (parseCameraConfigData(cameraId, configData))\n> \t\t\treturn -EINVAL;\n> \t}\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6878ABD161\n\tfor ;\n\tFri, 17 Jun 2022 13:48:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1369965635;\n\tFri, 17 Jun 2022 15:48:37 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07C8165632\n\tfor ;\n\tFri, 17 Jun 2022 15:48:36 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 99942240007;\n\tFri, 17 Jun 2022 13:48:35 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655473717;\n\tbh=r3IkCOO+GMVYP/fB6aOYKD065GkjX3QY0+anjma9wBA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MA8BqXOgQldhWx/Pgjgv1mx5XjSfE3/9KATRBfjJRf4brSXpMMRwE0TFk1hkxF8PT\n\t0ESLkLRDLb4fmbDRCOoxltNldAnLBlUDqtSR3zlg0enNDGyCJF4FnHCWG/LUsBvZMC\n\tevKkHsZtt7YpR1QstmWTt7Sil+GR/E6eB5s13B0TyJc7FNm7KOxVsVqzwk61y/7720\n\t8HV+kDUExw3hwujToZZOK6co2CD6NIGbBwoB037VZ++KI6fMr6k2r+DUP2faRzyMFf\n\tKAtNvhw4HB51N2K8acNrk2VMq3314bsMg59bPnOQCOMsacRJOOi8bBtZz3bkNr0A4W\n\tqYhUnBniLX7jA==","Date":"Fri, 17 Jun 2022 15:48:34 +0200","To":"Laurent Pinchart ","Message-ID":"<20220617134834.vmzvt2qsns3iwgq2@uno.localdomain>","References":"<20220616142403.20723-1-laurent.pinchart@ideasonboard.com>\n\t<20220616142403.20723-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220616142403.20723-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: Use the YamlObject\n\titerator API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23488,"web_url":"https://patchwork.libcamera.org/comment/23488/","msgid":"","date":"2022-06-20T12:08:24","subject":"Re: [libcamera-devel] [PATCH 4/7] android: Use the YamlObject\n\titerator API","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"content":"Hi Laurent,\n\nReviewed-by: Han-Lin Chen \nThanks.\n\nOn Fri, Jun 17, 2022 at 9:48 PM Jacopo Mondi via libcamera-devel\n wrote:\n>\n> Hi Laurent,\n>\n> On Thu, Jun 16, 2022 at 05:24:00PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > Replace usage of YamlObject::memberNames() with the more efficient\n> > iterator API.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> Nicer indeed. partially answers my \"are both dict and list\" necessary\n> question.\n>\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> > ---\n> > src/android/camera_hal_config.cpp | 6 ++----\n> > 1 file changed, 2 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> > index ac484b8df1bd..bacfe4b9c505 100644\n> > --- a/src/android/camera_hal_config.cpp\n> > +++ b/src/android/camera_hal_config.cpp\n> > @@ -82,10 +82,8 @@ int CameraHalConfig::Private::parseConfigFile(File &file,\n> > if (!yamlObjectCameras.isDictionary())\n> > return -EINVAL;\n> >\n> > - std::vector cameraIds = yamlObjectCameras.memberNames();\n> > - for (const std::string &cameraId : cameraIds) {\n> > - if (parseCameraConfigData(cameraId,\n> > - yamlObjectCameras[cameraId]))\n> > + for (const auto &[cameraId, configData] : yamlObjectCameras.asDict()) {\n> > + if (parseCameraConfigData(cameraId, configData))\n> > return -EINVAL;\n> > }\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13FF8BE173\n\tfor ;\n\tMon, 20 Jun 2022 12:08:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD0EB6563A;\n\tMon, 20 Jun 2022 14:08:37 +0200 (CEST)","from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com\n\t[IPv6:2001:4860:4864:20::2b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FFA465634\n\tfor ;\n\tMon, 20 Jun 2022 14:08:36 +0200 (CEST)","by mail-oa1-x2b.google.com with SMTP id\n\t586e51a60fabf-fe023ab520so13944634fac.10\n\tfor ;\n\tMon, 20 Jun 2022 05:08:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655726917;\n\tbh=15p9xZ0xBMwZhPirLjN/pX80R97p24gTFqO9s2eB7Ck=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DgG/HJh4+VnMZWTM85bJoqQfTXQzRFizNTtt2sUkCH96teJ/S5JwTWxOPlPHyRDao\n\t0Y85VZJywzFpQObI5Nia2ilF/0jrmkNRE0IOWt5Ay1nn2yLfuZwEqnCNTk/vdKK8I3\n\tZ3BocavBrSroew/f9551kKUGouYn3S2eJWXKZbeVnsNWjLSJ3F446XlKGatfXhwJez\n\tCp8PwYLkoulqlKb4XJypupK0mrLZzMOZADn8JxIPQ2/XuENE73V+S9JfRRRFBncljY\n\t7k2xmiH9bHqhcavFcpzcg+tTqAG82Lx2ogV7g0dcoAZSNbTkWuXnswk6JtXXX/qnM3\n\t6ggXx119wvWdg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=uqKu5Jb3c9HnR5HpBMgHEG16XaUiIuWNcNSc4EKUxtw=;\n\tb=K7N7zbEVXwybFj0kIpdOEMDhQPs8I2aXerSIJXUG8r0NTj7ykslt5OwzJi/M/jtE+f\n\thF6LCXYXVz8Z56RS+UKBWTujJhh82PwTq19/zSOr8HKyRL+npCkZUF0N39EvXUPV24+9\n\tb3dJ+O2rwGioQctZYrF5xV0iFs0hnRdvDmdrU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"K7N7zbEV\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=uqKu5Jb3c9HnR5HpBMgHEG16XaUiIuWNcNSc4EKUxtw=;\n\tb=zp6PJReVHyJMoquiOfetIdmf4hSEuRC0pCj5Frye73wxLgA4ccxMyWo427JeApRDEt\n\tbwY7cadVZ0DhDDr21MzxMHMoejlC3jXbb4yVUFplv0H6WJA7Vz4NyYil+yvRI8PzvneI\n\t0tyZz16SPnbCzoK3i24MMtxt+2wvu/bss7NFsy3W/6ytr8UTUaaO6p/UzYCKYJiCghna\n\tNOJud+H2bVYOQq4QVWoeJ4sMsloZMVSEWCQLZ7oHNSkkF8/qJpMq3IXIVSADAs88JEFs\n\tzt3ldIWvl0SWcrRG2U2muUlC0pBXGPz9Fa9j7SxLiFnJYi2HXlTaEnKgin7vMf9/nuOd\n\tkuiw==","X-Gm-Message-State":"AJIora+8Q+MoxgHAAzGi/EPn3LqK1oR7J4PYiKT8XknAxpOExtc+H0Iz\n\toFrKdDZ42RyrQyC5iiKbbwcim/ZqOXXhXiVTnJciq5S0QEOMng==","X-Google-Smtp-Source":"AGRyM1vSVDbeAeFWGVl7HVzUXfvlIK2IeCvxT8PAA0pz4YJKXglojNabxbi8lGRU2xBtz5PozzKri30jD3flULmhj+0=","X-Received":"by 2002:a05:6870:ea8e:b0:fe:251a:3c3d with SMTP id\n\ts14-20020a056870ea8e00b000fe251a3c3dmr18304783oap.62.1655726915494;\n\tMon, 20 Jun 2022 05:08:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20220616142403.20723-1-laurent.pinchart@ideasonboard.com>\n\t<20220616142403.20723-5-laurent.pinchart@ideasonboard.com>\n\t<20220617134834.vmzvt2qsns3iwgq2@uno.localdomain>","In-Reply-To":"<20220617134834.vmzvt2qsns3iwgq2@uno.localdomain>","Date":"Mon, 20 Jun 2022 20:08:24 +0800","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: Use the YamlObject\n\titerator API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Hanlin Chen via libcamera-devel ","Reply-To":"Hanlin Chen ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]