{"id":16240,"url":"https://patchwork.libcamera.org/api/patches/16240/?format=json","web_url":"https://patchwork.libcamera.org/patch/16240/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220616142403.20723-5-laurent.pinchart@ideasonboard.com>","date":"2022-06-16T14:24:00","name":"[libcamera-devel,4/7] android: Use the YamlObject iterator API","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"58bb05a9959a9a2cb366acb133b71e06cd8fea75","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16240/mbox/","series":[{"id":3181,"url":"https://patchwork.libcamera.org/api/series/3181/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3181","date":"2022-06-16T14:23:56","name":"libcamera: yaml_parser: Add iterator API","version":1,"mbox":"https://patchwork.libcamera.org/series/3181/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16240/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16240/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47906BD808\n\tfor ;\n\tThu, 16 Jun 2022 14:24:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2D1065641;\n\tThu, 16 Jun 2022 16:24:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE99865635\n\tfor ;\n\tThu, 16 Jun 2022 16:24:20 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 444F1898;\n\tThu, 16 Jun 2022 16:24:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655389464;\n\tbh=Ic3F3Afbq5cwq4A8ifAQhqKg4w3eXeU4Dm+xJoUklrM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=D9wZzsfYXFKeAspcyFkpcgiBEobEXVG6AaDF8TkXXSeluC+gj1w7gwkYXahs6QQjU\n\tC1Q8kWsdkR5rb7HwAMHFQNKeDrSzQd6mBSUJmGQGt4N8UdE9XfhDBZOj3sXGpnc558\n\tMU94zNs/2sENAqgJmFyN94Ixz0HA7cvMcwDSZzOB9BTMDW2H2TBh+uy43jDLHhX3+D\n\tfozhEVPhGduiErpYqVVNp/Fw0l1vCwJhg3Cs4bqPjPjq+8WZZhfug/XjZXoh4NCGg0\n\tv6c71aabR56b5iCKzzoEaukhkB3uSrGKiwEJ0YNmNOxJ8CfLPNu4tu99MPlMMTv2sR\n\tW8CpS4cn3jgAA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655389460;\n\tbh=Ic3F3Afbq5cwq4A8ifAQhqKg4w3eXeU4Dm+xJoUklrM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DVUuGjnVffbpor9ACXyCXzhaOKSMWRvIRRaaVs66tUPUX+e4oWLcesfltn9VoRsly\n\tqTDJl+8K966EM+IV664CbN+obPK9MhA7nazHVxO3EAEtzOpL+qV3kETPjFXKwmesci\n\t69j1+OoeVu6flVE9zIfvpG2UcOvjz8V8s2FHuXz8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DVUuGjnV\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Jun 2022 17:24:00 +0300","Message-Id":"<20220616142403.20723-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220616142403.20723-1-laurent.pinchart@ideasonboard.com>","References":"<20220616142403.20723-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/7] android: Use the YamlObject iterator\n\tAPI","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace usage of YamlObject::memberNames() with the more efficient\niterator API.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_hal_config.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex ac484b8df1bd..bacfe4b9c505 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -82,10 +82,8 @@ int CameraHalConfig::Private::parseConfigFile(File &file,\n \tif (!yamlObjectCameras.isDictionary())\n \t\treturn -EINVAL;\n \n-\tstd::vector cameraIds = yamlObjectCameras.memberNames();\n-\tfor (const std::string &cameraId : cameraIds) {\n-\t\tif (parseCameraConfigData(cameraId,\n-\t\t\t\t\t yamlObjectCameras[cameraId]))\n+\tfor (const auto &[cameraId, configData] : yamlObjectCameras.asDict()) {\n+\t\tif (parseCameraConfigData(cameraId, configData))\n \t\t\treturn -EINVAL;\n \t}\n \n","prefixes":["libcamera-devel","4/7"]}