[{"id":23448,"web_url":"https://patchwork.libcamera.org/comment/23448/","msgid":"<20220617134746.3pzmvqrbrkpv7abm@uno.localdomain>","date":"2022-06-17T13:47:46","subject":"Re: [libcamera-devel] [PATCH 1/7] libcamera: yaml_parser: Use\n\tstd::is_same_v<>","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Thu, Jun 16, 2022 at 05:23:57PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> As the YamlObject class is internal to libcamera, it can use the full\n> C++17 API. Replace std::is_same<>::value with std::is_same_v<>.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> include/libcamera/internal/yaml_parser.h | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\n> index be5f0914703f..29b7b218f0d9 100644\n> --- a/include/libcamera/internal/yaml_parser.h\n> +++ b/include/libcamera/internal/yaml_parser.h\n> @@ -44,12 +44,12 @@ public:\n> #ifndef __DOXYGEN__\n> \ttemplate \t\t typename std::enable_if_t<\n> -\t\t\t std::is_same::value ||\n> -\t\t\t std::is_same::value ||\n> -\t\t\t std::is_same::value ||\n> -\t\t\t std::is_same::value ||\n> -\t\t\t std::is_same::value ||\n> -\t\t\t std::is_same::value> * = nullptr>\n> +\t\t\t std::is_same_v ||\n> +\t\t\t std::is_same_v ||\n> +\t\t\t std::is_same_v ||\n> +\t\t\t std::is_same_v ||\n> +\t\t\t std::is_same_v ||\n> +\t\t\t std::is_same_v> * = nullptr>\n> #else\n> \ttemplate\n> #endif\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A3D2BD161\n\tfor ;\n\tFri, 17 Jun 2022 13:47:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C9DA65635;\n\tFri, 17 Jun 2022 15:47:49 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A8B065632\n\tfor ;\n\tFri, 17 Jun 2022 15:47:48 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 0BAFD240008;\n\tFri, 17 Jun 2022 13:47:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655473669;\n\tbh=HdenhUTuFXAB6ulaGL+sStsyGA2AAodPwii/rtSuCuU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=v5YM4kOLzk51t15btgNmintY8Zk1cY1D8uX3e9QsOEXNfecyqmu8JkOHVyeo6ONgO\n\t0oesBpjhUxBuwVSt5bH+KLBQ7KKiCWT3rmeogLsVXKY+VDH6rVVmvDblagRnGegiU2\n\t4PM18EvqRtrcDe5z4yJMHeCVDO8dM/iVtX0x8lk9BGMeSJx3NM85n4z04osZOQ3z42\n\tZm7JuhwlmFQV/re5KOPXDo5FTKV7QKcI6upjtorjchn6/d04AB7zh5xlfa78+rTzlM\n\tZ7anNLhQcFkUrW63RCdkTx2HaqcZ1Tvdb8HumlZwOkeuXnr8/IXSeLAn19BdjFG1/A\n\tL5q21RxQAZOMw==","Date":"Fri, 17 Jun 2022 15:47:46 +0200","To":"Laurent Pinchart ","Message-ID":"<20220617134746.3pzmvqrbrkpv7abm@uno.localdomain>","References":"<20220616142403.20723-1-laurent.pinchart@ideasonboard.com>\n\t<20220616142403.20723-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220616142403.20723-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/7] libcamera: yaml_parser: Use\n\tstd::is_same_v<>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23489,"web_url":"https://patchwork.libcamera.org/comment/23489/","msgid":"","date":"2022-06-20T12:08:32","subject":"Re: [libcamera-devel] [PATCH 1/7] libcamera: yaml_parser: Use\n\tstd::is_same_v<>","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"content":"Hi Laurent,\n\nReviewed-by: Han-Lin Chen \nThanks.\n\nOn Thu, Jun 16, 2022 at 10:24 PM Laurent Pinchart via libcamera-devel\n wrote:\n>\n> As the YamlObject class is internal to libcamera, it can use the full\n> C++17 API. Replace std::is_same<>::value with std::is_same_v<>.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/yaml_parser.h | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\n> index be5f0914703f..29b7b218f0d9 100644\n> --- a/include/libcamera/internal/yaml_parser.h\n> +++ b/include/libcamera/internal/yaml_parser.h\n> @@ -44,12 +44,12 @@ public:\n> #ifndef __DOXYGEN__\n> template typename std::enable_if_t<\n> - std::is_same::value ||\n> - std::is_same::value ||\n> - std::is_same::value ||\n> - std::is_same::value ||\n> - std::is_same::value ||\n> - std::is_same::value> * = nullptr>\n> + std::is_same_v ||\n> + std::is_same_v ||\n> + std::is_same_v ||\n> + std::is_same_v ||\n> + std::is_same_v ||\n> + std::is_same_v> * = nullptr>\n> #else\n> template\n> #endif\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0566CBE173\n\tfor ;\n\tMon, 20 Jun 2022 12:08:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7E866563D;\n\tMon, 20 Jun 2022 14:08:46 +0200 (CEST)","from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com\n\t[IPv6:2607:f8b0:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D68E65634\n\tfor ;\n\tMon, 20 Jun 2022 14:08:44 +0200 (CEST)","by mail-oi1-x22e.google.com with SMTP id w16so13379884oie.5\n\tfor ;\n\tMon, 20 Jun 2022 05:08:44 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655726926;\n\tbh=4x+ykU9Rn85gPLuky4lDPTyNsloYEeEUM4DhBgeuVCE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JCEDUb487j88uZeX/TcJdXjgmBevuCK4vUKospDpv91RlsP+Ve/fr5UFjyxPi+kvr\n\tyJBr1PCfdqOpq3iGopOT48y7onkHUTvr3bu6dkjH8xbvy2r8XPHoqfQCFA9wCoQHK5\n\tQD+yv2zlfc851DnCKQlxj1HwQQ9nuMVZe4XmvLeOOEUYAXd07YQWAmYkO5XPoS1MHv\n\tR6ycwp5xcXddhlWBMyJO9pYfofc2eWZfvbk2Hw/D1jGrarsKgzc3H7XZq5ni62C6ft\n\tcb35sWC1wo4uCmhP3EE6UPZlQh8AG8N6T9ZhOuGtbsl9Mws9TatZBBHZQnJWEfdsMy\n\tGd+P2Y8Ni4F1Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=zVOvnoeIgnQAG414xhOERA6M0tpzHZe0QJHL6fLklto=;\n\tb=Th2KxBVHjqgzOBqKAiYZRFnKItDl2XhNGMGnfB4OYyWjRhxUd3PQr8RTPLHR2PjnqS\n\tdMcjP6PDHLW8cx3KfJQa9n1KQ4de2/q4t02eFmA5y+ULy6PinGnCo/PWKKKDy3ZJAhEE\n\tTfEdm0I5hvmgySH9aJY+eNnYL0sjj/GJLLB9I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"Th2KxBVH\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=zVOvnoeIgnQAG414xhOERA6M0tpzHZe0QJHL6fLklto=;\n\tb=YV6FHf4c4WeLBZS2sVY9E2ZG/psPlpv0xX8dCNyb2kGO8GX6xBTQQQ6BplLOLC+GkC\n\tpwaSPjd6LFjX+3cQk8O0ZXgeDMMRw84n+nM2aVAGrkGrY0aFXUKVaWiY/PPoZwXSwfSp\n\tdytQGA55GqmzBqyGrAw6N2vkgtBn0fXt1JdvLovJRg/517/Z7HgmvliaFPi+T0eWtf5U\n\t4ZJOvvZ6qvqd2hMHZ/bsXwtviYQ16nDWx3M80vRy7wdZklXSzFSTS7SPjNeLvbw+SN+y\n\tn/VWlSvzNFIzbzYr+yFYkL42KuG5B7piwAltdC+ZwkJvIRTBkAHjgCBrRy2zC2y9G8ZV\n\tF0rQ==","X-Gm-Message-State":"AJIora8jcmDLpxuwqlRJasjoeUdFcgG/3queANYNuCvIbzfzaX/YQlDV\n\tgdXNUSBzPV+KgI6RlS3d5HCI7R6g4RgUcqNhikjiVrF53hMPtg==","X-Google-Smtp-Source":"AGRyM1vGyu5sx7MzXvA9YMEiLmZ1pwoU/kzhQ2SargvwrJqJYyniCK9ZnqcbaurB/6Jc8NvPqnhLVetaFK4b94tn2SA=","X-Received":"by 2002:a05:6808:2384:b0:331:39ca:a507 with SMTP id\n\tbp4-20020a056808238400b0033139caa507mr11239074oib.65.1655726923089;\n\tMon, 20 Jun 2022 05:08:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20220616142403.20723-1-laurent.pinchart@ideasonboard.com>\n\t<20220616142403.20723-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220616142403.20723-2-laurent.pinchart@ideasonboard.com>","Date":"Mon, 20 Jun 2022 20:08:32 +0800","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/7] libcamera: yaml_parser: Use\n\tstd::is_same_v<>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Hanlin Chen via libcamera-devel ","Reply-To":"Hanlin Chen ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]