{"id":16232,"url":"https://patchwork.libcamera.org/api/patches/16232/?format=json","web_url":"https://patchwork.libcamera.org/patch/16232/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220616084642.59823-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-06-16T08:46:42","name":"[libcamera-devel] qcam: dng: Make TIFFTAG_CFAPATTERN variable count","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9a75b6470c1178d552869a6dfe360cbc1bef126e","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16232/mbox/","series":[{"id":3178,"url":"https://patchwork.libcamera.org/api/series/3178/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3178","date":"2022-06-16T08:46:42","name":"[libcamera-devel] qcam: dng: Make TIFFTAG_CFAPATTERN variable count","version":1,"mbox":"https://patchwork.libcamera.org/series/3178/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16232/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16232/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94435BD808\n\tfor ;\n\tThu, 16 Jun 2022 08:46:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C80F865635;\n\tThu, 16 Jun 2022 10:46:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7233E601F1\n\tfor ;\n\tThu, 16 Jun 2022 10:46:47 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:64d1:a349:8ac7:1dd0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8C94415;\n\tThu, 16 Jun 2022 10:46:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655369208;\n\tbh=n119NyFdT6mH6bLbpjVMmJNDkvpmaxV89km5oAAJ6/w=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=2UYF9v1K5AxL9wAdFXmCZyz8b/TIop22gOSw+1+McQV+EGK5t+xf4UdTi1P/a3fRs\n\tvtrFOzm9g+n6pkpzELeP5ugDaQz4uW8t1GrKZuinn5SSluPTjU08aT8jjFtnjgvAAQ\n\tuCeE//hDRc3+Yw7/kWhM8Vt9MXdrxGIU8umO4J5mEKuGFxjXqKOVOdMLU9mFXxRo8k\n\tklEXr1ucrQTkEvkBQlnxKrJEkLKpIpj1pNL/Glj/DGyltNuXqiCbz3OCO9gDm1H06b\n\tHT5Gi6V7RN9tLMt3NSFix7DQEtm0hQZjW4rthtk//UXm9AWKL2s0l97DV/0CqzivFw\n\t79Hv0N+1c7rzA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655369207;\n\tbh=n119NyFdT6mH6bLbpjVMmJNDkvpmaxV89km5oAAJ6/w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ElROXy0CaRxIT1y02SHmBQL6vLus8GaNQXsDpULLGz5sIml38vD5yaT+qu1Ra5uHl\n\tsq9/1N3+ki3aRSSJqjm5QnvHqrJq+ey699yVcc2bEEC6cgm2KbEOOzO7e+jA898m2I\n\tPT2ED4Q6e8Vsbn78ism3mVmLPpp/JOGW0HAuiMtk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ElROXy0C\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Jun 2022 10:46:42 +0200","Message-Id":"<20220616084642.59823-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] qcam: dng: Make TIFFTAG_CFAPATTERN\n\tvariable count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since libtiff version 20201219, the CFAPATTERN tag is using a variable\ncount and not the fixed 4 values size.\nFor reference, the commit introducing this is:\n\n\tcommit 2eb5a954cb7b7ad61559da00743c4b0e2fce34d0\n\tAuthor: Sam Hasinoff \n\tDate: Sun Mar 8 21:23:16 2020 +0100\n\tMake TIFFTAG_CFAPATTERN variable count\n\nAdd a version check in the DNGWriter::write function when this tag is\nwritten as this breaks the raw capture in qcam.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/qcam/dng_writer.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\nindex 34c8df5a..bfb867c6 100644\n--- a/src/qcam/dng_writer.cpp\n+++ b/src/qcam/dng_writer.cpp\n@@ -506,7 +506,10 @@ int DNGWriter::write(const char *filename, const Camera *camera,\n \tTIFFSetField(tif, TIFFTAG_PLANARCONFIG, PLANARCONFIG_CONTIG);\n \tTIFFSetField(tif, TIFFTAG_SAMPLEFORMAT, SAMPLEFORMAT_UINT);\n \tTIFFSetField(tif, TIFFTAG_CFAREPEATPATTERNDIM, cfaRepeatPatternDim);\n-\tTIFFSetField(tif, TIFFTAG_CFAPATTERN, info->pattern);\n+\tif (TIFFLIB_VERSION < 20201219))\n+\t\tTIFFSetField(tif, TIFFTAG_CFAPATTERN, info->pattern);\n+\telse\n+\t\tTIFFSetField(tif, TIFFTAG_CFAPATTERN, 4, info->pattern);\n \tTIFFSetField(tif, TIFFTAG_CFAPLANECOLOR, 3, cfaPlaneColor);\n \tTIFFSetField(tif, TIFFTAG_CFALAYOUT, 1);\n \n","prefixes":["libcamera-devel"]}