[{"id":23424,"web_url":"https://patchwork.libcamera.org/comment/23424/","msgid":"","date":"2022-06-16T09:33:53","subject":"Re: [libcamera-devel] [PATCH v2 4/5] ipa: rkisp1: Add ov5640 tuning\n\tfile","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Florian,\n\nThank you for the patch.\n\nOn Thu, Jun 16, 2022 at 10:07:43AM +0200, Florian Sylvestre via libcamera-devel wrote:\n> Add the ov5640 tuning file containing default values for 'black level\n> correction' algorithm.\n> \n> Signed-off-by: Florian Sylvestre \n> ---\n> src/ipa/rkisp1/data/meson.build | 8 ++++++++\n> src/ipa/rkisp1/data/ov5640.yaml | 8 ++++++++\n> src/ipa/rkisp1/meson.build | 1 +\n> 3 files changed, 17 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/meson.build\n> create mode 100644 src/ipa/rkisp1/data/ov5640.yaml\n> \n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> new file mode 100644\n> index 00000000..2656bb2e\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +conf_files = files([\n> + 'ov5640.yaml',\n> +])\n> +\n> +install_data(conf_files,\n> + install_dir : ipa_data_dir / 'rkisp1')\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> new file mode 100644\n> index 00000000..d8e56463\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n\n%YAML 1.2\n\n> +---\n> +BlackLevelCorrection:\n> + R: 256\n> + Gr: 256\n> + Gb: 256\n> + B: 256\n> +...\n\nFollowing a discussion with Naush and David about the Raspberry Pi\ntuning files, it became clear versioning them would be useful. I'd thus\npropose the following:\n\nversion: 1\nalgorithms:\n - BlackLevelCorrection:\n R: 256\n Gr: 256\n Gb: 256\n B: 256\n\nThe algorithms should be put in a list to support instantiating them in\nuser-configurable order if needed, as YAML mappings are not ordered.\n\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index 8c822fbb..ccb84b27 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> subdir('algorithms')\n> +subdir('data')\n> \n> ipa_name = 'ipa_rkisp1'\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9042FBD161\n\tfor ;\n\tThu, 16 Jun 2022 09:40:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43C1565637;\n\tThu, 16 Jun 2022 11:40:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C4DD601F1\n\tfor ;\n\tThu, 16 Jun 2022 11:40:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05B5D415;\n\tThu, 16 Jun 2022 11:34:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655372423;\n\tbh=bGFYqXvkqrtrqyuxmogiXjYMk+wmNr7/ofGuLLiYQU8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qLsMp/nbdD+cykI+qCO8rWphEcYXFtX8L04WzqMJVl/wdFnxj9dDGFrCkMImE7TDI\n\t4nvIrvxMxq91p5OUddXaAi30aeS3wE4uQnfEgawC1k2zwKs5T2+nMOt78/sy/HqwDM\n\tezG7qRvMfdRR0Lcm10SaVQhmeLB8oW7ZPYlI/rONiJaTzAsTqEXqRGYYwjfhqrXYnb\n\tbk9HCm4VAHDRgsmesLIpGQFKqekw68M6hL5AXZANTIA+VrjQOskV1JWuFPMUySgTEq\n\tz+wwX4hZwSlvSeJJHbqf9eDGJP+kQB3P967NqH6SPrlYczdeucwJ+NlEcnekjFY3Br\n\t4nrn61hYoTBRw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655372044;\n\tbh=bGFYqXvkqrtrqyuxmogiXjYMk+wmNr7/ofGuLLiYQU8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tLRQAMwFqoP9bfDkn4ToxyoopwNtuk5If9b08gqvFo78CGuNh9VKwG6csDcXgzRIJ\n\t0lwyikJmCgAbONd5Y0ryFP9x0vJO/Mx2x1Ij8oQ+LQPLi48FTg+VuLS0I5At8+GeJD\n\t0k10UrswNOfM20aFolyslXRWVU5j4xydmfF2pcmQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tLRQAMwF\"; dkim-atps=neutral","Date":"Thu, 16 Jun 2022 12:33:53 +0300","To":"Florian Sylvestre ","Message-ID":"","References":"<20220616080744.548995-1-fsylvestre@baylibre.com>\n\t<20220616080744.548995-5-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220616080744.548995-5-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] ipa: rkisp1: Add ov5640 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]