{"id":16224,"url":"https://patchwork.libcamera.org/api/patches/16224/?format=json","web_url":"https://patchwork.libcamera.org/patch/16224/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220615162601.48619-3-dse@thaumatec.com>","date":"2022-06-15T16:26:00","name":"[libcamera-devel,2/3] Documentation: Update code examples to use the Request::reuse() method","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b9d757fea22b6d1664dd05e54e3f071856558a3c","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/?format=json","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16224/mbox/","series":[{"id":3176,"url":"https://patchwork.libcamera.org/api/series/3176/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3176","date":"2022-06-15T16:25:58","name":"Documentation: Update code examples in Application Writer's Guide","version":1,"mbox":"https://patchwork.libcamera.org/series/3176/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16224/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16224/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D167C3274\n\tfor ;\n\tWed, 15 Jun 2022 16:26:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E18BC65637;\n\tWed, 15 Jun 2022 18:26:47 +0200 (CEST)","from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54E9465631\n\tfor ;\n\tWed, 15 Jun 2022 18:26:46 +0200 (CEST)","by mail-wr1-x430.google.com with SMTP id o16so16097916wra.4\n\tfor ;\n\tWed, 15 Jun 2022 09:26:46 -0700 (PDT)","from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tr17-20020a05600c35d100b0039c8d181ac6sm3135772wmq.26.2022.06.15.09.26.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 15 Jun 2022 09:26:45 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655310407;\n\tbh=Rth15gJjGXY9HttBrm5pmAqhlqdqMAWx6LM4ZHUDCF8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=yDDlp+k8L4hO7XxqEWix10aaTaSB5unlkBvR6R33+URguSNjstGSYRzZKj8cioomm\n\tVona1p2DhDviXANxQzA7aK8uk/JM3rSzW+1Hbwu/B+EjU0c8dbMq+wsa2K4OPbSf5P\n\truMdR4+Ne8vi3HgZWboi7Ia/Qh7yNUP1jgOs/0thh4v5TaphI+p+sON7bb/HJiqryF\n\tezT1o8myGxgGD+TzjJ+YJhmv+0TEwBKnz49QS1qoRcPddwBEL7BF1VQZ6sNPmgL6JH\n\tmKo86pPuek7mzFXwcvFvY+Owt6VouxuPREWIsLaiY4n+B4k4drbfQWx81NQ7uQWbpd\n\thooERAk5gO6oQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=x5pmzjoZiXuT0DHzxI2DxQ95Z5ycnNU6zzqPLmhAnlU=;\n\tb=s+GQyrTniuUhtO44nv0Hkh40UPf1ldcek95NPpnJhsUo71emL+H4TMUYrySuACXGd2\n\tGnp7chQTFa4F4+A+orKvALHZseD0OO3bLhyUtMs8S3M6qtw5nyb/WWA0UyJvSsE6/emf\n\t+deAn3wfoEZ7Y4W067yGO12cvXQAvGHp8nffFCvFzJyxsFKaYLOSEwQlHdsBw1CX/ida\n\t3m7dntTVqt3T/5NiRuIuqb748c+mWyZ/9ClVRqA2R9Ar70A68xbHD8K2iCvmmioApei4\n\tB3BRVLpWKz33QinE0cSCCwS0LXD15XtVRz73yCaYoFuin5NtBuLZWKpxK61mv8lVJFKO\n\tI/8A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"s+GQyrTn\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=x5pmzjoZiXuT0DHzxI2DxQ95Z5ycnNU6zzqPLmhAnlU=;\n\tb=LcRGkf7cxNltiWeylSuXhMDl3dzgWL3pKrXkiGVRdB1krOP3To+Do2f0GpB3VWpk9V\n\tGXO+F1/E0LF+uhAXyBcgZPuHajVYVBHPDNrOjs7yqKwH3omY/Tkzg4DjaiWc9vml9OTz\n\tJkgTWH8UO7xdZjpBBthBr87bBcpmZEwdU7yIvbXnkD1rhjKMtEmLh0yORi612RgBeVCI\n\tD6h7m+v3hsNUf/7LwlM4D05FnB9EEwIUuJTe2PQEtXPSiJYE+blPWvMUJDD58HtCi901\n\tni7ilSCR9oHyEh+jrkzyfaVbYs16YfRUrIh+eu6UgIvGLYKSJbixF0IJsNeXzHRQFB41\n\tfTvg==","X-Gm-Message-State":"AJIora8x8W7DBKZXRGjBa7VnEyFx08l/jwoCXuMeLDGBwF6k6hm4cBAq\n\t5M5Tpskbr1dTHVFAyjNHlVH4AMdPnkviQy1E","X-Google-Smtp-Source":"AGRyM1vZ/3IsA//wkv31dpOCNXq5uSHNfDa5RapeJAYCPEFo8Td8KHMEzwJ70BYPO4Kgj5+kSu2c2A==","X-Received":"by 2002:adf:f601:0:b0:219:f4e9:cc40 with SMTP id\n\tt1-20020adff601000000b00219f4e9cc40mr634217wrp.362.1655310406065; \n\tWed, 15 Jun 2022 09:26:46 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jun 2022 18:26:00 +0200","Message-Id":"<20220615162601.48619-3-dse@thaumatec.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220615162601.48619-1-dse@thaumatec.com>","References":"<20220615162601.48619-1-dse@thaumatec.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/3] Documentation: Update code examples\n\tto use the Request::reuse() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"After introduction of reuse(), there is no need of manual request\nreconfiguration. Furthermore, current example code does not work\nanymore.\n---\n Documentation/guides/application-developer.rst | 16 +---------------\n 1 file changed, 1 insertion(+), 15 deletions(-)","diff":"diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\nindex 6ab8b7e5..00bafb10 100644\n--- a/Documentation/guides/application-developer.rst\n+++ b/Documentation/guides/application-developer.rst\n@@ -485,21 +485,7 @@ streams, and finally, queue the new capture request to the camera device:\n \n .. code:: cpp\n \n- request = camera->createRequest();\n- if (!request)\n- {\n- std::cerr << \"Can't create request\" << std::endl;\n- return;\n- }\n-\n- for (auto it = buffers.begin(); it != buffers.end(); ++it)\n- {\n- Stream *stream = it->first;\n- FrameBuffer *buffer = it->second;\n-\n- request->addBuffer(stream, buffer);\n- }\n-\n+ request->reuse(Request::ReuseBuffers);\n camera->queueRequest(request);\n \n Request queueing\n","prefixes":["libcamera-devel","2/3"]}