[{"id":23428,"web_url":"https://patchwork.libcamera.org/comment/23428/","msgid":"<20220616104645.3yfgt3dutsbtiks2@uno.localdomain>","date":"2022-06-16T10:46:45","subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation: Update code\n\texamples to match Request related changes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Daniel,\n\nOn Wed, Jun 15, 2022 at 06:25:59PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> - Camera::createRequest() now returns unique_ptr instead of raw pointer\n> - Request::BufferMap key type is now const\n\nAs a general comment: all your patches are missing your Signed-off-by.\nJust 'git commit -s' to add it automatically.\n\nOn this patch, we have received a very similar one\nhttps://patchwork.libcamera.org/patch/16207/\n\n> ---\n> Documentation/guides/application-developer.rst | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 16bea9c4..6ab8b7e5 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -308,7 +308,7 @@ the camera.\n>\n> Stream *stream = streamConfig.stream();\n> const std::vector> &buffers = allocator->buffers(stream);\n> - std::vector requests;\n> + std::vector> requests;\n>\n> Proceed to fill the request vector by creating ``Request`` instances from the\n> camera device, and associate a buffer for each of them for the ``Stream``.\n> @@ -316,7 +316,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> .. code:: cpp\n>\n> for (unsigned int i = 0; i < buffers.size(); ++i) {\n> - Request *request = camera->createRequest();\n> + std::unique_ptr request = camera->createRequest();\n> if (!request)\n> {\n> std::cerr << \"Can't create request\" << std::endl;\n> @@ -332,7 +332,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> return ret;\n> }\n>\n> - requests.push_back(request);\n> + requests.push_back(std::move(request));\n> }\n>\n> .. TODO: Controls\n> @@ -410,7 +410,7 @@ images.\n>\n> .. code:: cpp\n>\n> - const std::map &buffers = request->buffers();\n> + const std::map &buffers = request->buffers();\n>\n\nWhich does not include this hunk\n\nI think we can merge Tommaso's one as it has been sent before and you can\nrebase on that one ?\n\nThanks\n j\n\n> Iterating through the map allows applications to inspect each completed buffer\n> in this request, and access the metadata associated to each frame.\n> @@ -517,8 +517,8 @@ and queue all the previously created requests.\n> .. code:: cpp\n>\n> camera->start();\n> - for (Request *request : requests)\n> - camera->queueRequest(request);\n> + for (std::unique_ptr &request : requests)\n> + camera->queueRequest(request.get());\n>\n> Start an event loop\n> ~~~~~~~~~~~~~~~~~~~\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 301C8BD161\n\tfor ;\n\tThu, 16 Jun 2022 10:46:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3B6A65635;\n\tThu, 16 Jun 2022 12:46:48 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52750600F0\n\tfor ;\n\tThu, 16 Jun 2022 12:46:47 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id D7BE3240002;\n\tThu, 16 Jun 2022 10:46:46 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655376408;\n\tbh=0Buz9uK9s99crHw3JGldUmmC7g/qCiIrot0mcEAzyQA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yi5LYNg12xPKzfhwkCmVpbtJnmo9ZeiTTh9VMA0n0jK/W5xqpzGCSpiq3z9h6Ii0X\n\tgOj9E+hELdi/EO2y5wGI85wJPC1bJYTx3BsU8Rs1sDFfZ4PxPAzPqreAjpTbtyyls0\n\tVDJrwFGjY/7A0StANHjVoZOzKQ9h2E57YU0uzux1szy/OZCt+MiU1bpZR1/NYilBZq\n\tykOxzL9ZGQs5QTdWvPpCFZAAl0gmSNtuctMBBt7MvAYRGRh3PSXM7OQ7ovUv/MmpV7\n\t7BnW0662upKIccb3Oiw4PYKdyACYgN7tGYpaeN/fv34THrte5N5GiSM+CnM831NXQ8\n\tsOE05ndrV6IQQ==","Date":"Thu, 16 Jun 2022 12:46:45 +0200","To":"Daniel Semkowicz ","Message-ID":"<20220616104645.3yfgt3dutsbtiks2@uno.localdomain>","References":"<20220615162601.48619-1-dse@thaumatec.com>\n\t<20220615162601.48619-2-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220615162601.48619-2-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation: Update code\n\texamples to match Request related changes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23431,"web_url":"https://patchwork.libcamera.org/comment/23431/","msgid":"","date":"2022-06-17T07:02:23","subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation: Update code\n\texamples to match Request related changes","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"content":"Hi Jacopo,\n\nOn Thu, Jun 16, 2022 at 12:46 PM Jacopo Mondi wrote:\n>\n> Hi Daniel,\n>\n> On Wed, Jun 15, 2022 at 06:25:59PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> > - Camera::createRequest() now returns unique_ptr instead of raw pointer\n> > - Request::BufferMap key type is now const\n>\n> As a general comment: all your patches are missing your Signed-off-by.\n> Just 'git commit -s' to add it automatically.\n>\n\nOh, sorry I missed that. I will add it in the updated version.\n\n> On this patch, we have received a very similar one\n> https://patchwork.libcamera.org/patch/16207/\n>\n> > ---\n> > Documentation/guides/application-developer.rst | 12 ++++++------\n> > 1 file changed, 6 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > index 16bea9c4..6ab8b7e5 100644\n> > --- a/Documentation/guides/application-developer.rst\n> > +++ b/Documentation/guides/application-developer.rst\n> > @@ -308,7 +308,7 @@ the camera.\n> >\n> > Stream *stream = streamConfig.stream();\n> > const std::vector> &buffers = allocator->buffers(stream);\n> > - std::vector requests;\n> > + std::vector> requests;\n> >\n> > Proceed to fill the request vector by creating ``Request`` instances from the\n> > camera device, and associate a buffer for each of them for the ``Stream``.\n> > @@ -316,7 +316,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > .. code:: cpp\n> >\n> > for (unsigned int i = 0; i < buffers.size(); ++i) {\n> > - Request *request = camera->createRequest();\n> > + std::unique_ptr request = camera->createRequest();\n> > if (!request)\n> > {\n> > std::cerr << \"Can't create request\" << std::endl;\n> > @@ -332,7 +332,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > return ret;\n> > }\n> >\n> > - requests.push_back(request);\n> > + requests.push_back(std::move(request));\n> > }\n> >\n> > .. TODO: Controls\n> > @@ -410,7 +410,7 @@ images.\n> >\n> > .. code:: cpp\n> >\n> > - const std::map &buffers = request->buffers();\n> > + const std::map &buffers = request->buffers();\n> >\n>\n> Which does not include this hunk\n>\n> I think we can merge Tommaso's one as it has been sent before and you can\n> rebase on that one ?\n>\n\nYes, sure. We can do it this way.\n\nBest regards\nDaniel Semkowicz\n\n> Thanks\n> j\n>\n> > Iterating through the map allows applications to inspect each completed buffer\n> > in this request, and access the metadata associated to each frame.\n> > @@ -517,8 +517,8 @@ and queue all the previously created requests.\n> > .. code:: cpp\n> >\n> > camera->start();\n> > - for (Request *request : requests)\n> > - camera->queueRequest(request);\n> > + for (std::unique_ptr &request : requests)\n> > + camera->queueRequest(request.get());\n> >\n> > Start an event loop\n> > ~~~~~~~~~~~~~~~~~~~\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07B75BD161\n\tfor ;\n\tFri, 17 Jun 2022 07:02:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68FD665634;\n\tFri, 17 Jun 2022 09:02:36 +0200 (CEST)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB810633A7\n\tfor ;\n\tFri, 17 Jun 2022 09:02:34 +0200 (CEST)","by mail-lj1-x22e.google.com with SMTP id y29so3791186ljd.7\n\tfor ;\n\tFri, 17 Jun 2022 00:02:34 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655449356;\n\tbh=n9YBehwn3sf6LAA72vtSaTLDAEFnehGH/3MPx2aGAa8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mFZK5gH8xLu2tLoOItIbkmXmvVZkhh86vJdGAT1zAKp5Kg6DkrTAhCtcUxsoS20Ow\n\tJlT05+1rzJlcEvcPkNKbALVY+Rde/OPeIC0KWQyTEwC5CAecLDhU3084PzVCe3VfPI\n\tVcRVHZfDwOTOsJIv6B5Ty4e8hHHja4hCuhhp/0/lKjOuNTvYmQxKbzrdjR1/Z11ptf\n\tIxTYuvBKCLAixiFqCVeHAHT/xIb+DiGPiezmlR7BE48shi4KwqISOH17zfOXwRKzeK\n\t4/93fi+SkigTBfwxG2Z8HOgKqnBt8tEJLvzfJAS6Dp79BfjafDBb0hz82cxKRyHV7c\n\tOqgTXiWyqBsRQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=J3xSKWC/INKThLf9WH7uDZ8jzAsOQnblzF3KYs/xasw=;\n\tb=aS/MZPRHiDUofRZ+NI+QyZYeyy7lpwuznE6V1Bw2K2429E9QoT+jlOYI2rSvF5n9q+\n\trYuXqOQCJYfy1TObAb/dxxu6Y4DS20mwVtQaMlUzzvwHdjR+Y347NAKAgqiwBpSE/Yh1\n\t6/WblxG3woXMBhvozi9N0i5KnXFgVH1a3op2KPv2Sjp8o05eApMXnEo0t3B8SYRvV5BR\n\tdAeEtdDib+F5Bj5aK/On9qeKCxaEE02fsZRySwSnuH/eIP0pKVtDxA6Hten71R+rReug\n\tYLry+DF6Gt+dtm0ax/2aUFmVqfv+4ZVUI2vaEIrbeJKiqlXyKqtis9It3em2ArPkk0BE\n\tDIJw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"aS/MZPRH\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=J3xSKWC/INKThLf9WH7uDZ8jzAsOQnblzF3KYs/xasw=;\n\tb=MT5Di4m+Iv4+dYkyZgJqKQkNUqxspolKhZQfQ6eT2KiyuCDzehGcaMiYB0q7K9STPt\n\tb/LOrxAMfYQVlk/vxOEqnEQOzmxugYbhBcLT+gxFmEkE9Kp/8MlY23YdIRFJgiV0BNBA\n\tX1bpT0PrIXzZnwUywi1k6lx+AQdwwCmdfuIqFFF+jc5ICsyUuslyxU/dlka5BO4Ygp2j\n\tiQttIbjYwl6qkqVjI2/hm2dWvHAHVQkLB0gnm+UeM72zrKu0L0LUl+Zjp58JUPTw7AOX\n\tLfpaGyoNgnnP04tW8oRZiVmJZpql9QXts5InV89wKwRwE7Xub/zZ/KDXUmJtpVnbuqkm\n\tzGhw==","X-Gm-Message-State":"AJIora9HJs4V9rLtqWG1HUQ4K2Sxr+6AbDDr6GZ2kfa3FRJd8H2ci+5Z\n\tndGUmGTQV1ApBW0GKg91jdSpwlxpHmVkY3APdtxRWLXgQNTnm6se","X-Google-Smtp-Source":"AGRyM1s11h8nwB3YqKHlaPPm69fysSiU5N7luhrdeEkzXFsyY1Vi2ZOyAlc+uYmcHsmYdnn274kBoHKhJdZZtNVxlq0=","X-Received":"by 2002:a05:651c:178b:b0:258:ed21:efbd with SMTP id\n\tbn11-20020a05651c178b00b00258ed21efbdmr4280856ljb.464.1655449354093;\n\tFri, 17 Jun 2022 00:02:34 -0700 (PDT)","MIME-Version":"1.0","References":"<20220615162601.48619-1-dse@thaumatec.com>\n\t<20220615162601.48619-2-dse@thaumatec.com>\n\t<20220616104645.3yfgt3dutsbtiks2@uno.localdomain>","In-Reply-To":"<20220616104645.3yfgt3dutsbtiks2@uno.localdomain>","Date":"Fri, 17 Jun 2022 09:02:23 +0200","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation: Update code\n\texamples to match Request related changes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23443,"web_url":"https://patchwork.libcamera.org/comment/23443/","msgid":"","date":"2022-06-17T11:09:48","subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation: Update code\n\texamples to match Request related changes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello Daniel,\n\nOn Fri, Jun 17, 2022 at 09:02:23AM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> On Thu, Jun 16, 2022 at 12:46 PM Jacopo Mondi wrote:\n> > On Wed, Jun 15, 2022 at 06:25:59PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> > > - Camera::createRequest() now returns unique_ptr instead of raw pointer\n> > > - Request::BufferMap key type is now const\n> >\n> > As a general comment: all your patches are missing your Signed-off-by.\n> > Just 'git commit -s' to add it automatically.\n> \n> Oh, sorry I missed that. I will add it in the updated version.\n\nFor context, please see\nhttps://libcamera.org/contributing.html#submitting-patches.\nhttps://libcamera.org/coding-style.html#coding-style-guidelines is also\nworth a read if you haven't yet, especially the part about the\ncheckstyle.py script (although that's mostly for code, not\ndocumentation).\n\n> > On this patch, we have received a very similar one\n> > https://patchwork.libcamera.org/patch/16207/\n> >\n> > > ---\n> > > Documentation/guides/application-developer.rst | 12 ++++++------\n> > > 1 file changed, 6 insertions(+), 6 deletions(-)\n> > >\n> > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > > index 16bea9c4..6ab8b7e5 100644\n> > > --- a/Documentation/guides/application-developer.rst\n> > > +++ b/Documentation/guides/application-developer.rst\n> > > @@ -308,7 +308,7 @@ the camera.\n> > >\n> > > Stream *stream = streamConfig.stream();\n> > > const std::vector> &buffers = allocator->buffers(stream);\n> > > - std::vector requests;\n> > > + std::vector> requests;\n> > >\n> > > Proceed to fill the request vector by creating ``Request`` instances from the\n> > > camera device, and associate a buffer for each of them for the ``Stream``.\n> > > @@ -316,7 +316,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > > .. code:: cpp\n> > >\n> > > for (unsigned int i = 0; i < buffers.size(); ++i) {\n> > > - Request *request = camera->createRequest();\n> > > + std::unique_ptr request = camera->createRequest();\n> > > if (!request)\n> > > {\n> > > std::cerr << \"Can't create request\" << std::endl;\n> > > @@ -332,7 +332,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > > return ret;\n> > > }\n> > >\n> > > - requests.push_back(request);\n> > > + requests.push_back(std::move(request));\n> > > }\n> > >\n> > > .. TODO: Controls\n> > > @@ -410,7 +410,7 @@ images.\n> > >\n> > > .. code:: cpp\n> > >\n> > > - const std::map &buffers = request->buffers();\n> > > + const std::map &buffers = request->buffers();\n> > >\n> >\n> > Which does not include this hunk\n> >\n> > I think we can merge Tommaso's one as it has been sent before and you can\n> > rebase on that one ?\n> \n> Yes, sure. We can do it this way.\n\nI've merged Tommaso's patch in the libcamera git tree, so you can now\nrebase easily.\n\n> > > Iterating through the map allows applications to inspect each completed buffer\n> > > in this request, and access the metadata associated to each frame.\n> > > @@ -517,8 +517,8 @@ and queue all the previously created requests.\n> > > .. code:: cpp\n> > >\n> > > camera->start();\n> > > - for (Request *request : requests)\n> > > - camera->queueRequest(request);\n> > > + for (std::unique_ptr &request : requests)\n> > > + camera->queueRequest(request.get());\n> > >\n> > > Start an event loop\n> > > ~~~~~~~~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86B68BD808\n\tfor ;\n\tFri, 17 Jun 2022 11:10:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF7AC65635;\n\tFri, 17 Jun 2022 13:10:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6330F65632\n\tfor ;\n\tFri, 17 Jun 2022 13:10:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3490268;\n\tFri, 17 Jun 2022 13:09:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655464201;\n\tbh=dGHFXrIqJUlSQc+hwz+OWZ+jg9tr3aApP0CfjNOZTL4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QPEJgQlmogZm9UPNklKwkvdWN+2CZ4da5Cb1Xy94YL7qr+thMBMm78yH/+4UtYao7\n\tVC5O181zkFyfkn4diM6uTCY0dak8thTPHVW+DIN9n3OYZ9fZsfrybrknaGysT6KGFC\n\tiQkOJhQWZJANYYmfRd6y/uelmfjJ75Uod77DQEwWqVA1I9/zCdK9kZy9UvpqSGNybL\n\tGBtlE2mcahcudSAo2K4HbjEl7kWjnvs+2rAsAjv/k6IZkRBUDq2J80IfbupvG39smC\n\tPKfqdRvN6Dv7PpAVO6r7poz+TgZZO8da2oytjyc1h1luHxJxBZ55Jrn9Re0ePvyh9i\n\troUyuI2/vAarg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655464200;\n\tbh=dGHFXrIqJUlSQc+hwz+OWZ+jg9tr3aApP0CfjNOZTL4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aoMQY4D0sqqC7MY60V6XbqqYjBx8ma0zlJ+5DPu5lmAbM2BpXABvFuXPGdDbH2jyH\n\t+SNn97Vp2EPcFnEC3gGxdCVdh2angBRzeXV7rKgsv4Be4rhWlpTcRmIoySkvxu7wFu\n\tLKqDYTx7NTbnOrI+SmaNpPvO7lESdXUrJsI5bRBQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aoMQY4D0\"; dkim-atps=neutral","Date":"Fri, 17 Jun 2022 14:09:48 +0300","To":"Daniel Semkowicz ","Message-ID":"","References":"<20220615162601.48619-1-dse@thaumatec.com>\n\t<20220615162601.48619-2-dse@thaumatec.com>\n\t<20220616104645.3yfgt3dutsbtiks2@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] Documentation: Update code\n\texamples to match Request related changes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]