[{"id":23396,"web_url":"https://patchwork.libcamera.org/comment/23396/","msgid":"","date":"2022-06-13T09:07:27","subject":"Re: [libcamera-devel] [PATCH] Documentation: fix createRequest\n\tunique_ptr","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tommaso,\n\nThank you for the patch.\n\nOn Mon, Jun 13, 2022 at 10:27:25AM +0200, Tommaso Merciai via libcamera-devel wrote:\n> camera->createRequest() function return std::unique_ptr, then\n> manipulate Request as std::unique_ptr.\n> This solve the following error, during compilation:\n> \n> error: cannot convert ‘std::unique_ptr’ to ‘libcamera::Request*’ in initialization\n> \n> References:\n> - https://github.com/kbingham/simple-cam/blob/bb97f3bbd96a9d347e1b7f6cb68d94efaf8db574/simple-cam.cpp#L369\n\nThe change in simple-cam was made in\n\ncommit 94b055c70c09729cab51cc2c74c1a0e3c1a9ae50\nAuthor: Paul Elder \nDate: Fri Oct 16 14:51:19 2020 +0900\n\n simple-cam: Reuse Requests\n\n Update simple-cam to reuse Request objects, and use the new API with\n unique pointers.\n\n Signed-off-by: Paul Elder \n Reviewed-by: Kieran Bingham \n Signed-off-by: Kieran Bingham \n\nwhich follows the introduction of the Request::reuse() API in libcamera.\nThe application guide should thus be extended accordingly.\n\nKieran, I notice that there are quite a few changes in simple-cam on top\nof commit 94b055c70c09. Have most of them been taken into account in the\napplication guide, or do we need a larger update ?\n\n> Signed-off-by: Tommaso Merciai \n> ---\n> Documentation/guides/application-developer.rst | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 16bea9c4..8d12a208 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -308,7 +308,7 @@ the camera.\n> \n> Stream *stream = streamConfig.stream();\n> const std::vector> &buffers = allocator->buffers(stream);\n> - std::vector requests;\n> + std::vector> requests;\n> \n> Proceed to fill the request vector by creating ``Request`` instances from the\n> camera device, and associate a buffer for each of them for the ``Stream``.\n> @@ -316,7 +316,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> .. code:: cpp\n> \n> for (unsigned int i = 0; i < buffers.size(); ++i) {\n> - Request *request = camera->createRequest();\n> + std::unique_ptr request = camera->createRequest();\n> if (!request)\n> {\n> std::cerr << \"Can't create request\" << std::endl;\n> @@ -332,7 +332,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> return ret;\n> }\n> \n> - requests.push_back(request);\n> + requests.push_back(std::move(request));\n> }\n> \n> .. TODO: Controls\n> @@ -517,8 +517,8 @@ and queue all the previously created requests.\n> .. code:: cpp\n> \n> camera->start();\n> - for (Request *request : requests)\n> - camera->queueRequest(request);\n> + for (std::unique_ptr &request : requests)\n> + camera->queueRequest(request.get());\n> \n> Start an event loop\n> ~~~~~~~~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B90BBD161\n\tfor ;\n\tMon, 13 Jun 2022 09:07:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72E5865635;\n\tMon, 13 Jun 2022 11:07:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E05D601F0\n\tfor ;\n\tMon, 13 Jun 2022 11:07:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99E7C305;\n\tMon, 13 Jun 2022 11:07:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655111258;\n\tbh=zQPEYa6NkmWxU7P0z1pAhIP5vZyesOpi+ItpU3m14J8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=upU3xt/DBIf9ukx9DP9RHxT0FSZ6Ba9WobKdzRU1kpetnftI+hG5tlZbDwBBZ4wNi\n\t9J/jAJ/O1xW537DZR3BlyDKWwzWGfO9q65tUtigMeJPof2+UTjvIiPmUNsa+6QcvIX\n\tLFLOgxaEg/ddpTQj0cG/hyBHJvEv3sR3Y2zqMhKRNvYibt3uHtMwxB7mtzGVLCjXEl\n\tR2umqPb5G8pOHcyBfvOc1P1uu6zkKHUOS5eHZp1gbQ8ihtc0UoUXY1ZLD3oA71t0Q7\n\t8k7ingGkQ+FYBdycJgC5A+kCXvk/VW4oy4I3APrBDjY5nEIhCLKfdop4lHxqK/JNdH\n\tgTCVqaBwm/5wQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655111255;\n\tbh=zQPEYa6NkmWxU7P0z1pAhIP5vZyesOpi+ItpU3m14J8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RnJYF/W0bvzMosS8sir+eyw01xBo9QqnzMe+Ne/OExSSM3CCBoF2sBAGa506uBAn9\n\tLdSxp7MDbpnI/heMFbfjbbqxK0QFP1bpV2/tNmWai1WPXG3VZOGmqUqfTbhrEOTrkZ\n\t9XwnFzN/sKjAup8Su1qdWzxxiMtp7qGMLjsTq3g0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RnJYF/W0\"; dkim-atps=neutral","Date":"Mon, 13 Jun 2022 12:07:27 +0300","To":"Tommaso Merciai ","Message-ID":"","References":"<20220613082725.16315-1-tommaso.merciai@amarulasolutions.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20220613082725.16315-1-tommaso.merciai@amarulasolutions.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: fix createRequest\n\tunique_ptr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"linuxfancy@googlegroups.com, libcamera-devel@lists.libcamera.org,\n\tlinux-amarula@amarulasolutions.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23427,"web_url":"https://patchwork.libcamera.org/comment/23427/","msgid":"<20220616104528.fhg4upead64tsves@uno.localdomain>","date":"2022-06-16T10:45:28","subject":"Re: [libcamera-devel] [PATCH] Documentation: fix createRequest\n\tunique_ptr","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Tommaso, Laurent\n\nOn Mon, Jun 13, 2022 at 12:07:27PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Hi Tommaso,\n>\n> Thank you for the patch.\n>\n> On Mon, Jun 13, 2022 at 10:27:25AM +0200, Tommaso Merciai via libcamera-devel wrote:\n> > camera->createRequest() function return std::unique_ptr, then\n> > manipulate Request as std::unique_ptr.\n> > This solve the following error, during compilation:\n> >\n> > error: cannot convert ‘std::unique_ptr’ to ‘libcamera::Request*’ in initialization\n> >\n> > References:\n> > - https://github.com/kbingham/simple-cam/blob/bb97f3bbd96a9d347e1b7f6cb68d94efaf8db574/simple-cam.cpp#L369\n>\n> The change in simple-cam was made in\n>\n> commit 94b055c70c09729cab51cc2c74c1a0e3c1a9ae50\n> Author: Paul Elder \n> Date: Fri Oct 16 14:51:19 2020 +0900\n>\n> simple-cam: Reuse Requests\n>\n> Update simple-cam to reuse Request objects, and use the new API with\n> unique pointers.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Kieran Bingham \n>\n> which follows the introduction of the Request::reuse() API in libcamera.\n> The application guide should thus be extended accordingly.\n>\n> Kieran, I notice that there are quite a few changes in simple-cam on top\n> of commit 94b055c70c09. Have most of them been taken into account in the\n> application guide, or do we need a larger update ?\n>\n\nWe have more\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=3176\n\nBut this patch can be collected in the meantime ?\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > Signed-off-by: Tommaso Merciai \n> > ---\n> > Documentation/guides/application-developer.rst | 10 +++++-----\n> > 1 file changed, 5 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > index 16bea9c4..8d12a208 100644\n> > --- a/Documentation/guides/application-developer.rst\n> > +++ b/Documentation/guides/application-developer.rst\n> > @@ -308,7 +308,7 @@ the camera.\n> >\n> > Stream *stream = streamConfig.stream();\n> > const std::vector> &buffers = allocator->buffers(stream);\n> > - std::vector requests;\n> > + std::vector> requests;\n> >\n> > Proceed to fill the request vector by creating ``Request`` instances from the\n> > camera device, and associate a buffer for each of them for the ``Stream``.\n> > @@ -316,7 +316,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > .. code:: cpp\n> >\n> > for (unsigned int i = 0; i < buffers.size(); ++i) {\n> > - Request *request = camera->createRequest();\n> > + std::unique_ptr request = camera->createRequest();\n> > if (!request)\n> > {\n> > std::cerr << \"Can't create request\" << std::endl;\n> > @@ -332,7 +332,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > return ret;\n> > }\n> >\n> > - requests.push_back(request);\n> > + requests.push_back(std::move(request));\n> > }\n> >\n> > .. TODO: Controls\n> > @@ -517,8 +517,8 @@ and queue all the previously created requests.\n> > .. code:: cpp\n> >\n> > camera->start();\n> > - for (Request *request : requests)\n> > - camera->queueRequest(request);\n> > + for (std::unique_ptr &request : requests)\n> > + camera->queueRequest(request.get());\n> >\n> > Start an event loop\n> > ~~~~~~~~~~~~~~~~~~~\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FA6FBD161\n\tfor ;\n\tThu, 16 Jun 2022 10:45:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FC6965631;\n\tThu, 16 Jun 2022 12:45:32 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA142600F0\n\tfor ;\n\tThu, 16 Jun 2022 12:45:30 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 9F461E0006;\n\tThu, 16 Jun 2022 10:45:29 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655376332;\n\tbh=KXdvgrTUrPmP4KYrtIEMwVjus6qX9AvkCihHhFZ7JVI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BCBlTAQ+m0DgmAhL5fhR/860bPAPING0X2NUupYrigAXoPMtuUR5zct0QYD799JZR\n\tASb5lopdPr7CCJXy3MF9bLG8O/CYMIHDvAs5wdRRL+zLiSYM+vM0dud+C+o73iMIZI\n\tmEn6Apz5zNuDESms2xVoFsXS/gnRPHzC+9C2MTqB7L/Wv12B2zTP1F5OO5speHKqUu\n\tiSuXLiseP2lq0sbQId5tPVoo6hJJCDVBG3kjH71UaLimzTuP6mn8kjKuJziG5fUINz\n\t/IqDmrRiRz8ZCNIbhnHiZAPniaPB6m8ytfX7xfcrqgnIk1aquutozjIJ38DQ6VVcvx\n\tYrguIwoqchyYA==","Date":"Thu, 16 Jun 2022 12:45:28 +0200","To":"Laurent Pinchart ","Message-ID":"<20220616104528.fhg4upead64tsves@uno.localdomain>","References":"<20220613082725.16315-1-tommaso.merciai@amarulasolutions.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] Documentation: fix createRequest\n\tunique_ptr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"linux-amarula@amarulasolutions.com, libcamera-devel@lists.libcamera.org, \n\tlinuxfancy@googlegroups.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23442,"web_url":"https://patchwork.libcamera.org/comment/23442/","msgid":"","date":"2022-06-17T10:28:23","subject":"Re: [libcamera-devel] [PATCH] Documentation: fix createRequest\n\tunique_ptr","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Thu, Jun 16, 2022 at 12:45:28PM +0200, Jacopo Mondi wrote:\n> On Mon, Jun 13, 2022 at 12:07:27PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > On Mon, Jun 13, 2022 at 10:27:25AM +0200, Tommaso Merciai via libcamera-devel wrote:\n> > > camera->createRequest() function return std::unique_ptr, then\n> > > manipulate Request as std::unique_ptr.\n> > > This solve the following error, during compilation:\n> > >\n> > > error: cannot convert ‘std::unique_ptr’ to ‘libcamera::Request*’ in initialization\n> > >\n> > > References:\n> > > - https://github.com/kbingham/simple-cam/blob/bb97f3bbd96a9d347e1b7f6cb68d94efaf8db574/simple-cam.cpp#L369\n> >\n> > The change in simple-cam was made in\n> >\n> > commit 94b055c70c09729cab51cc2c74c1a0e3c1a9ae50\n> > Author: Paul Elder \n> > Date: Fri Oct 16 14:51:19 2020 +0900\n> >\n> > simple-cam: Reuse Requests\n> >\n> > Update simple-cam to reuse Request objects, and use the new API with\n> > unique pointers.\n> >\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Kieran Bingham \n> > Signed-off-by: Kieran Bingham \n> >\n> > which follows the introduction of the Request::reuse() API in libcamera.\n> > The application guide should thus be extended accordingly.\n> >\n> > Kieran, I notice that there are quite a few changes in simple-cam on top\n> > of commit 94b055c70c09. Have most of them been taken into account in the\n> > application guide, or do we need a larger update ?\n> >\n> \n> We have more\n> https://patchwork.libcamera.org/project/libcamera/list/?series=3176\n> \n> But this patch can be collected in the meantime ?\n\nSounds good.\n\nReviewed-by: Laurent Pinchart \n\n> Reviewed-by: Jacopo Mondi \n> \n> > > Signed-off-by: Tommaso Merciai \n> > > ---\n> > > Documentation/guides/application-developer.rst | 10 +++++-----\n> > > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > >\n> > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > > index 16bea9c4..8d12a208 100644\n> > > --- a/Documentation/guides/application-developer.rst\n> > > +++ b/Documentation/guides/application-developer.rst\n> > > @@ -308,7 +308,7 @@ the camera.\n> > >\n> > > Stream *stream = streamConfig.stream();\n> > > const std::vector> &buffers = allocator->buffers(stream);\n> > > - std::vector requests;\n> > > + std::vector> requests;\n> > >\n> > > Proceed to fill the request vector by creating ``Request`` instances from the\n> > > camera device, and associate a buffer for each of them for the ``Stream``.\n> > > @@ -316,7 +316,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > > .. code:: cpp\n> > >\n> > > for (unsigned int i = 0; i < buffers.size(); ++i) {\n> > > - Request *request = camera->createRequest();\n> > > + std::unique_ptr request = camera->createRequest();\n> > > if (!request)\n> > > {\n> > > std::cerr << \"Can't create request\" << std::endl;\n> > > @@ -332,7 +332,7 @@ camera device, and associate a buffer for each of them for the ``Stream``.\n> > > return ret;\n> > > }\n> > >\n> > > - requests.push_back(request);\n> > > + requests.push_back(std::move(request));\n> > > }\n> > >\n> > > .. TODO: Controls\n> > > @@ -517,8 +517,8 @@ and queue all the previously created requests.\n> > > .. code:: cpp\n> > >\n> > > camera->start();\n> > > - for (Request *request : requests)\n> > > - camera->queueRequest(request);\n> > > + for (std::unique_ptr &request : requests)\n> > > + camera->queueRequest(request.get());\n> > >\n> > > Start an event loop\n> > > ~~~~~~~~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD1EFBD161\n\tfor ;\n\tFri, 17 Jun 2022 10:28:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4F3265635;\n\tFri, 17 Jun 2022 12:28:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B941E65632\n\tfor ;\n\tFri, 17 Jun 2022 12:28:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 168262A5;\n\tFri, 17 Jun 2022 12:28:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655461717;\n\tbh=oXt5JS3PNO3Uw5VK8fCmMZKBiiSxX5L5YjfbgxLirto=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=e/2QNmHEwx77bw8ECjhEeRxDtxSb03sOQBsyJoSmNurXdwDxGY3hUc9Q59ZzwIGP+\n\tmTXJzlao9p2DR1R7XorqZxV8OWtP1waxx+FExHJQum1tLvhZTVKUro0G+xQXduK1TF\n\tZa5K02EFpJlNhCE6ooxkvn54fh0oArvru+4M//8JCVaTEY03L566jb+dBXWVzZWOZ9\n\tMXSMj76RqEylF5vdzg+J1bTCmIaFI9eWUbH6Voq/yFv2RF4dOpFTiYKXdPfnWI67AL\n\tMNxqE7bDcYU7Yjkc3zkDNvX0QTNCMsi9tycCaKCOIXDLgo1BoxwPhFiuKIMzJjXnMh\n\t4tqaBflnMa5/w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655461716;\n\tbh=oXt5JS3PNO3Uw5VK8fCmMZKBiiSxX5L5YjfbgxLirto=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HvNggXY4n5u8dhuhBwy/zibYpcy1Xr++pon0CPrZBnlyGSRRMe+fEmQTP3FMKywLn\n\tFtmrJQ/RRyRSnwYUrTZKFXHy0t04xZik9g8GAWMu9GmFd3BLmmwRLWefMtHmjGRpja\n\tpTuowkAbi8KhSlLU5ie0nb70FsqnWGMG6ZfS5oEM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HvNggXY4\"; dkim-atps=neutral","Date":"Fri, 17 Jun 2022 13:28:23 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220613082725.16315-1-tommaso.merciai@amarulasolutions.com>\n\t\n\t<20220616104528.fhg4upead64tsves@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20220616104528.fhg4upead64tsves@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: fix createRequest\n\tunique_ptr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"linux-amarula@amarulasolutions.com, libcamera-devel@lists.libcamera.org, \n\tlinuxfancy@googlegroups.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]