[{"id":23407,"web_url":"https://patchwork.libcamera.org/comment/23407/","msgid":"<165533387887.2586493.11027458934701374721@Monstersaurus>","date":"2022-06-15T22:57:58","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: pipeline: simple:\n\tImprove debug message on config failure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-06-12 16:23:07)\n> When pipeline configuration fails, print the format returned by the\n> kernel in addition to the one requested by libcamera, to ease debugging.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index de75465eb3b5..efb28ccd97e8 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -939,7 +939,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> captureFormat.size != pipeConfig->captureSize) {\n> LOG(SimplePipeline, Error)\n> << \"Unable to configure capture in \"\n> - << pipeConfig->captureSize << \"-\" << videoFormat;\n> + << pipeConfig->captureSize << \"-\" << videoFormat\n> + << \" (got \" << captureFormat << \")\";\n> return -EINVAL;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFE38BD161\n\tfor ;\n\tWed, 15 Jun 2022 22:58:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E34065635;\n\tThu, 16 Jun 2022 00:58:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C6DF601EF\n\tfor ;\n\tThu, 16 Jun 2022 00:58:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87739415;\n\tThu, 16 Jun 2022 00:58:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655333884;\n\tbh=W+GuJ9V0FlpLnTr2T4S3sDxv/z3MpXH2gCRcrJc/D7Y=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m90OwU/rWr3LQrFYQ1TxHsAI1KglXY0Rh+jxyfYJjye+RuGu5ifugbqTApCMDfYHa\n\tGE7vagbpm1DnqVFud4AEjGurzRE+AF5ujPq4S3ib3JofdfmrdHEUiSHSWZ6L8L08z9\n\tOW+zXUCZY7rfVhgJG32O2EiLBf3n2HfWexD9qR7eehENWrfq6ZOPa4jMxS80fKNCRJ\n\tP3Vx413pl4QheFpFTFS7PNVLiPLJhgh3hmwQeo8bq3bzf/3l2U+sj7skx7nHQi4SK8\n\tK7EqOSypTkYpE8nWkpbIWcDv4HgWNeyxoHCidaXeHX2J89barNYn7eTrHBqkriJ2lO\n\tXJ0ERfSvHOL3g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655333881;\n\tbh=W+GuJ9V0FlpLnTr2T4S3sDxv/z3MpXH2gCRcrJc/D7Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=kNr+2LlS0hSfJMsuY2kR5RB1UvvJGcypaQGdFZwvtCOcSHGtA6RwLBfTdTiMZ3V6j\n\t1l4b3um4SWMpgZIMGWOmqB9TcVRZ7FPlpIMDRjFjBKf4OgpphizU/P3UrwxOj78Q9x\n\t23tGuQ+UUDLrtXDm8E95f2nfRbxvjDONo3arNlsQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kNr+2LlS\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220612152311.8408-2-laurent.pinchart@ideasonboard.com>","References":"<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>\n\t<20220612152311.8408-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jun 2022 23:57:58 +0100","Message-ID":"<165533387887.2586493.11027458934701374721@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: pipeline: simple:\n\tImprove debug message on config failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Dorota Czaplejewicz ,\n\tBenjamin Schaaf ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]