{"id":16166,"url":"https://patchwork.libcamera.org/api/patches/16166/?format=json","web_url":"https://patchwork.libcamera.org/patch/16166/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220604185939.29163-12-laurent.pinchart@ideasonboard.com>","date":"2022-06-04T18:59:36","name":"[libcamera-devel,RFC,v2,11/14] libcamera: yaml_parser: Fix range checks for 32-bit integers","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"5b3f51e79c7f1ebbff7c40ae7fcac489ad1b28a8","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16166/mbox/","series":[{"id":3161,"url":"https://patchwork.libcamera.org/api/series/3161/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3161","date":"2022-06-04T18:59:25","name":"Replace boost JSON parser with libyaml in Raspberry Pi IPA","version":2,"mbox":"https://patchwork.libcamera.org/series/3161/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16166/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16166/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 529C1C327B\n\tfor ;\n\tSat, 4 Jun 2022 19:00:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95EFD65644;\n\tSat, 4 Jun 2022 21:00:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 391386564F\n\tfor ;\n\tSat, 4 Jun 2022 21:00:16 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-79-203-nat.elisa-mobile.fi\n\t[85.76.79.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F02B487A;\n\tSat, 4 Jun 2022 21:00:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654369218;\n\tbh=k57qIkmOr92weRC9ZN8KPGgryCWRstSN6CSSZQy7WIU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=fbD+bO3qjLrCT9ZtM1mvWaV1gL9BppALVEjUcuiOWqRJ76vrKCH5uxqSG1A6V/2Tq\n\tTSoQQSidN9AtBYZfrT1xU5pEVF3XquI/Ek0FncRsQlB/BNGPW57zSQn1zeQe8hCSKI\n\t2WNHHQw86mni9poymC4GYZPtRh+ZcHJ2Nr51u6ZPSe0TnqbLJqVhOaerhJGvHLWzU0\n\t/+i0Vtkm9nabV4M8FZqY1atAERSqH/hOR4AE8L75ExMhuRSCCmFmwDI6hIN5CkwS3F\n\tO0ixzvXKqlYlVBR1jpERPB54IUjS/5AmlEndtdelLJVbQgkePfPpKgta26WOffVMD2\n\t/SWDXH5sPD9NA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654369216;\n\tbh=k57qIkmOr92weRC9ZN8KPGgryCWRstSN6CSSZQy7WIU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=f3U9QGRaExL4oD8psOpleuvb5GQsODoJ6ocEFNKWz1NFy2OOCsvXHrHNx3W0HSljY\n\tfMi/LFNhxg7WY/wyXY5tOooFjxwFKYjzYTEmS6GtUhSX8mjWr9h0mMdkbykU24OHOi\n\tGQ1lJbBE0bDUMJm9EM7heoH7hED5vppgeV4ioF2U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f3U9QGRa\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jun 2022 21:59:36 +0300","Message-Id":"<20220604185939.29163-12-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>","References":"<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 11/14] libcamera: yaml_parser: Fix\n\trange checks for 32-bit integers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The strtol() and strtoul() functions return long integers, which may be\nlarger than 32-bit integers. Add manual range checks.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/yaml_parser.cpp | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex 97104ac118a8..3fb6fec695ee 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -10,6 +10,7 @@\n #include \n #include \n #include \n+#include \n \n #include \n #include \n@@ -150,9 +151,11 @@ int32_t YamlObject::get(const int32_t &defaultValue, bool *ok) const\n \tchar *end;\n \n \terrno = 0;\n-\tint32_t value = std::strtol(value_.c_str(), &end, 10);\n+\tlong value = std::strtol(value_.c_str(), &end, 10);\n \n-\tif ('\\0' != *end || errno == ERANGE)\n+\tif ('\\0' != *end || errno == ERANGE ||\n+\t value < std::numeric_limits::min() ||\n+\t value > std::numeric_limits::max())\n \t\treturn defaultValue;\n \n \tsetOk(ok, true);\n@@ -184,9 +187,11 @@ uint32_t YamlObject::get(const uint32_t &defaultValue, bool *ok) const\n \tchar *end;\n \n \terrno = 0;\n-\tuint32_t value = std::strtoul(value_.c_str(), &end, 10);\n+\tunsigned long value = std::strtoul(value_.c_str(), &end, 10);\n \n-\tif ('\\0' != *end || errno == ERANGE)\n+\tif ('\\0' != *end || errno == ERANGE ||\n+\t value < std::numeric_limits::min() ||\n+\t value > std::numeric_limits::max())\n \t\treturn defaultValue;\n \n \tsetOk(ok, true);\n","prefixes":["libcamera-devel","RFC","v2","11/14"]}