{"id":16154,"url":"https://patchwork.libcamera.org/api/patches/16154/?format=json","web_url":"https://patchwork.libcamera.org/patch/16154/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220604093025.77737-6-jacopo@jmondi.org>","date":"2022-06-04T09:30:25","name":"[libcamera-devel,v3,5/5] android: camera_device: Print the correct number of completed streams","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f372720061e2d761352348779023b364428dbae9","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16154/mbox/","series":[{"id":3160,"url":"https://patchwork.libcamera.org/api/series/3160/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3160","date":"2022-06-04T09:30:20","name":"Plumb the YUV processor in","version":3,"mbox":"https://patchwork.libcamera.org/series/3160/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16154/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16154/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90F51BD161\n\tfor ;\n\tSat, 4 Jun 2022 09:30:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A10865644;\n\tSat, 4 Jun 2022 11:30:41 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACC4E65644\n\tfor ;\n\tSat, 4 Jun 2022 11:30:38 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5C8C7E000A;\n\tSat, 4 Jun 2022 09:30:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654335041;\n\tbh=EiwsPOXrJuNiFDEXHo+ormYGtZs8Ma1ZJCfkXtU6hWA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ZZf1hmdS2DAqVKX5LMcp8YDQ9Pd5SCEbZtmVoduj4axup/OciVV+CvBK0h94hrc47\n\tMQg9UXeu7XQPJ/5c3qJVzU+JRmCrXlY/Owr7V+6W/IfUZgtIiRRkBR0ai3YcxDFOG6\n\twswVCzSNBqaDvJ/O1LTGZbV5PwWl3nyoYH766yxYPIRPD9JxaYAo97asaZi5obvQIn\n\tdSWYKTtOlESgzGELjXfHaWOPzGLvFr1TSWT33Qhh3ANXmPXKnRMLj5xOCK8D57wiK0\n\tG07VyX9dw4uAZv1txVB7BBDMxdlb3TK6ehlLhJTR388kAJDvMaC7sdh9Oimb4wmtAU\n\t6G3ukgeTTt6HQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jun 2022 11:30:25 +0200","Message-Id":"<20220604093025.77737-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220604093025.77737-1-jacopo@jmondi.org>","References":"<20220604093025.77737-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/5] android: camera_device: Print the\n\tcorrect number of completed streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a request completes, a debug message is generated to help\nidentify the request and the number of streams it contains.\n\nThe printed number of streams is however the number of output buffers\nrequested by the camera framework, not the number of streams generated\nby libcamera. In facts, some output buffers are generated by\npost-processing, and not directly from the camera.\n\nAs the debug message prints the libcamera identifier for the Request, it\nis more logical to print the number of streams generated by the camera\ninstead of the total number of streams.\n\nReviewed-by: Hirokazu Honda \nReviewed-by: Paul Elder \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Paul Elder \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 0be6114e3c2c..44e6a9fc6f9b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1184,7 +1184,7 @@ void CameraDevice::requestComplete(Request *request)\n \tnotifyShutter(descriptor->frameNumber_, sensorTimestamp);\n \n \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n-\t\t\t<< descriptor->buffers_.size() << \" streams\";\n+\t\t\t<< descriptor->request_->buffers().size() << \" streams\";\n \n \t/*\n \t * Generate the metadata associated with the captured buffers.\n","prefixes":["libcamera-devel","v3","5/5"]}