{"id":16147,"url":"https://patchwork.libcamera.org/api/patches/16147/?format=json","web_url":"https://patchwork.libcamera.org/patch/16147/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220603220712.73673-5-Rauch.Christian@gmx.de>","date":"2022-06-03T22:07:11","name":"[libcamera-devel,v6,4/5] libcamera: controls: Generate fixed- and variable-sized Span Controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"abbda95a9e49e6401aeb5995bb1b3e26a6a73a0c","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16147/mbox/","series":[{"id":3158,"url":"https://patchwork.libcamera.org/api/series/3158/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3158","date":"2022-06-03T22:07:07","name":"generate and use fixed-sized Span Control types","version":6,"mbox":"https://patchwork.libcamera.org/series/3158/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16147/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16147/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 798A4C3276\n\tfor ;\n\tFri, 3 Jun 2022 22:07:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55F296563E;\n\tSat, 4 Jun 2022 00:07:22 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AA7D633A5\n\tfor ;\n\tSat, 4 Jun 2022 00:07:19 +0200 (CEST)","from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1MbAcs-1nLiqC3CIK-00bdNU; Sat, 04 Jun 2022 00:07:16 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654294042;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vh6JvmA7Qe0hycEePJKpJTUibd2yR2EZCKJt8r23YbnZ2LmvqwhNHXkGSrm0Y22Fv\n\t09A0z2u2ijQoBI2Rru2Y0icOUnvbE4rY6jm4Va9GsfxW6y0GZq1SV/2zKDVAzvb0Z4\n\tUH5sVE9Vxyr8avRI4nzSNyCjJkOyza5So2lHNjWHEx2uOw1JDRhr6TvYxq+zrl0FLM\n\t7o343ZvfyXhzrLayHaRkngFyuMPcD9atpGGbX6OLP9mfhL7/51FKJcPCRfzD6mycis\n\tWJnDOPDtB8KzmKwwjFbMWA8DkSPdqqgBskBZ8YmcG9G9Ex9YrOeJx5BQ1G4mlPv+VY\n\t7W15I5V8hb1WA==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654294037;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=YMOvHPNfoCu3XNvFF4WX5fJu4UEWPc+iuGD/gu0o1yCLWav7oHvIrqvA+5WxJ1pnt\n\tQoyxb++lpI2+dscpRi9JcH1cDQOvPmJ85jOSyA/icNLbcfSNpUj6sWbPrVceWyeHDu\n\tz2AfLtOrDTJMdOiGx+MmmagLL9UuVDVvxjvaYXqg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"YMOvHPNf\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 3 Jun 2022 23:07:11 +0100","Message-Id":"<20220603220712.73673-5-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220603220712.73673-1-Rauch.Christian@gmx.de>","References":"<20220603220712.73673-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:f/P8ZIEhRddX2tpuEUII+BRZ5v1vELGQL1ZG2Z0wAI37jtTKeWN\n\t4BvV0TF62QLGtbjM+0AKTv5M2vuHazN1Bpz8dFe26d6LCkGTdNnojZ5vbl5gMsmfAE8q8Cx\n\tcl+pOJUPhDIWAAQTXfwCpllwdjZ1frhjtvGJ/36ijpkHN6vLpgbQA8Vr4CXeri2nxYkdFcQ\n\tVGdKdQlKfkJ9MXUcxW5uw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:m2ITV46j7vY=:9dRd2mtX7YEPPj++zfa7uH\n\th8TO/6vJpV/LREovq/uxxqk2PSsw6MzBqJ0i4ZGHU1POFKe2KJWyYlvYDjjHpxNg55IF3vT/R\n\tx6OmsvuFrpemr10mNtVH6swe5gahzIWvHisV8HeGRojkNPumWawIVnhx7ejmElz/cDve/unt5\n\tMK13lIX41JkMbTM7rjB9eUI1Mkb9QBANIToAcaLwM/yfuS5tyoLzlRMPTknAZhJwh1UebU7uL\n\tcqzfSsS11046jHXws5aJZOieIkvoAFV0J1MJV6wT48GymwR0ZpIbZA3hp4pqLdph34Bv1oXAz\n\tYsAWynVoCv1wqyo5WxF4L/Ge8vnX5TeepWB4USXOKlbCtDmtk/rPdbLoxrk8N8/gjJ5bUGY6P\n\trqmcxjLN9Xr2SgBgW2LdpLPqXLCtBpG6mXrbzuBx9BCRRk1XsLdfiBIhqcvqfBHPKyxWoQ9Nf\n\tysakZlH6XWMBXzzd0IXtLgrCmK52eoWIoHN0l/kLz9lTdIKqVqaSZmJGwuiDP3ZBAewiG5gSt\n\tpoQ9GE22zomgo135utlikaEPU6+rdinT6tG2XLnAL9OKV0pgSuNheL5EASZloY6jhhrYz7n1h\n\ty6ER5JJsJIXDiFgL8m0Eb11QJ+6ftXMXPum/kUuAqYRe1v4y1NmWXzIzfzBp36ykcWFNysB6Y\n\teNEHnnhSAAOjfh8dEJmZdHL0mr8gWiZ3c6vOeQBVrzwk96lLvkysdUA7zjAu8ollr4fIDrG3q\n\tIwM/0aZ43X+LUzl27djIzyTmc1gR+RXKlIcQT+E33b3d9FR/XUa/MR5MXMtB0HuaCKgOjjLH6\n\tPvLxHD5RTMVcqi2N60GSuaoZC7p0gb8aiTWbzbaRNICgvzG69Qc3kRGjc99TxLUg9bYooAvKT\n\tq0DC7YTxTWyJDZc3AKstLXX0YzkIh5g/obmp6AGj8LYmCBDMOj0Sgr/e+Qx5YH6WOpvN6afGb\n\tj80h0SzImtDbBM9RUM/KrlHeAqcfVdwhJkFtMhbBChOycB7nKzDaHOTKC7u2QLybln6BCJl38\n\tm6fFflCKgS8QDqLmqrYP2x60CjSmBPsQO0swcXIdf0FYKKe/rmraqpYWLlxpgqg+wBhfhRzpD\n\tIu0TiGYug3Pldngw+BKJuSHjm459Rn8zYV0QgNmo96o11nEASxY8foqtw==","Subject":"[libcamera-devel] [PATCH v6 4/5] libcamera: controls: Generate\n\tfixed- and variable-sized Span Controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This defines Controls with a 'size' as either variable-sized Span or as\nfixed-sized Span.\n\nSigned-off-by: Christian Rauch \nReviewed-by: Jacopo Mondi \n---\n utils/gen-controls.py | 32 ++++++++++++++++++++++----------\n 1 file changed, 22 insertions(+), 10 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..46ba4394 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -7,6 +7,8 @@\n # gen-controls.py - Generate control definitions from YAML\n\n import argparse\n+from functools import reduce\n+import operator\n import string\n import sys\n import yaml\n@@ -22,6 +24,24 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+\n+ if ctrl_type == 'string':\n+ return 'std::string'\n+ elif ctrl_size_arr is not None:\n+ if len(ctrl_size_arr) > 0:\n+ # fixed-sized Span\n+ ctrl_span_size = reduce(operator.mul, ctrl_size_arr)\n+ return f\"Span\"\n+ else:\n+ # variable-sized Span\n+ return f\"Span\"\n+ else:\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +70,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +151,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n","prefixes":["libcamera-devel","v6","4/5"]}