[{"id":23315,"web_url":"https://patchwork.libcamera.org/comment/23315/","msgid":"<20220604073246.qryntpxilr7mly3z@uno.localdomain>","date":"2022-06-04T07:32:46","subject":"Re: [libcamera-devel] [PATCH v6 2/5] fix whitespace for indentation\n\t(replace spaces with tab)","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"You need a proper patch subject, with a prefix, and a minimum commit\nmessage. Something as simple as:\n\nlibcamera: ipu3: Fix rougue whitespace\n\nFix a comment line wrongly indented with spaces.\n\nOn Fri, Jun 03, 2022 at 11:07:09PM +0100, Christian Rauch via libcamera-devel wrote:\n> Signed-off-by: Christian Rauch \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 53332826..f1de87dc 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1449,7 +1449,7 @@ void IPU3CameraData::frameStart(uint32_t sequence)\n> \t/*\n> \t * Handle controls to be set immediately on the next frame.\n> \t * This currently only handle the TestPatternMode control.\n> - *\n> +\t *\n> \t * \\todo Synchronize with the sequence number\n> \t */\n> \tRequest *request = processingRequests_.front();\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D9C9BD160\n\tfor ;\n\tSat, 4 Jun 2022 07:32:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46FB165631;\n\tSat, 4 Jun 2022 09:32:50 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D40C06559A\n\tfor ;\n\tSat, 4 Jun 2022 09:32:48 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5B3EF20002;\n\tSat, 4 Jun 2022 07:32:48 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654327970;\n\tbh=u27VhaxFH21/K1RI0dBh25xVbqDSuLbVKMWd8NuMEYA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=E1MBfT7m0DbaQXQZTHSLBXMhzyFa8soT+jqBFIVV6PZ8OD5crBmw0kiokEq5s73pa\n\tSzbDkV5izDBGztU2flfPjYx+VkkB1banWVmPEcHL9MSmG5IfLlQpHFYTS0RL2qxa/0\n\tdxzKksRpfX9i9ZIktKpqvu5baosLDnYbXfEhNUxPoPfqvMrWhROrDOwpwMJewzW8uK\n\tHNWtYRI52S2u2/NCv/h4ULairVivNjHruN17aI0PkShPKxcjxMMww8MszLGgSvZ+HA\n\tZnU25ekM4WTz+IpzBGvVGo6o4V3zOt1AaOQ5Ah07YoVNl+I27s0crcLVLfe4fpzJKe\n\tina/sVTFGJFjg==","Date":"Sat, 4 Jun 2022 09:32:46 +0200","To":"Christian Rauch ","Message-ID":"<20220604073246.qryntpxilr7mly3z@uno.localdomain>","References":"<20220603220712.73673-1-Rauch.Christian@gmx.de>\n\t<20220603220712.73673-3-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220603220712.73673-3-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH v6 2/5] fix whitespace for indentation\n\t(replace spaces with tab)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]